No description
Find a file
rsc 9fd9f80431 Re: why cpuid() in locking code?
rtm wrote:
> Why does acquire() call cpuid()? Why does release() call cpuid()?

The cpuid in acquire is redundant with the cmpxchg, as you said.
I have removed the cpuid from acquire.

The cpuid in release is actually doing something important,
but not on the hardware.  It keeps gcc from reordering the
lock->locked assignment above the other two during optimization.
(Not that current gcc -O2 would choose to do that, but it is allowed to.)
I have replaced the cpuid in release with a "gcc barrier" that
keeps gcc from moving things around but has no hardware effect.

On a related note, I don't think the cpuid in mpmain is necessary,
for the same reason that the cpuid wasn't needed in release.

As to the question of whether

  acquire();
  x = protected;
  release();

might read protected after release(), I still haven't convinced
myself whether it can.  I'll put the cpuid back into release if
we determine that it can.

Russ
2007-09-30 14:30:04 +00:00
.cvsignore New formatting scripts. 2006-09-05 15:50:55 +00:00
asm.h continuous quality management 2007-08-31 19:55:27 +00:00
bio.c formatting 2007-08-28 05:00:53 +00:00
bootasm.S fix comments 2007-09-15 20:05:47 +00:00
bootmain.c fix comments 2007-09-15 20:05:47 +00:00
bootother.S bootothers now in main 2007-08-29 19:20:49 +00:00
buf.h Another attempt at the bio.c comment. 2007-08-27 14:09:30 +00:00
BUGS sh 2007-09-05 15:55:43 +00:00
cat.c more consistent spacing 2007-08-28 18:32:08 +00:00
console.c nit 2007-09-27 20:25:32 +00:00
cuth delete unnecessary #include lines 2007-08-27 23:26:33 +00:00
defs.h cleaner 2007-09-27 21:02:03 +00:00
dev.h Change dev read/write functions 2007-08-28 17:49:49 +00:00
dot-bochsrc kernel SMP interruptibility fixes. 2007-09-27 12:58:42 +00:00
echo.c Remove puts in favor of printf. 2007-08-24 20:03:40 +00:00
elf.h clumsy blank pages to make some files align better 2007-08-28 05:00:39 +00:00
exec.c oops - broke arg counting 2007-08-30 18:19:52 +00:00
fcntl.h nit 2007-08-28 04:13:24 +00:00
file.c remove _ from pipe; be like file 2007-08-28 04:22:35 +00:00
file.h Remove struct uinode. 2007-08-24 20:54:23 +00:00
forktest.c test that fork fails gracefully 2007-08-24 20:20:23 +00:00
fs.c final nits 2007-08-28 19:39:49 +00:00
fs.h comment nits 2007-08-24 19:52:49 +00:00
fsvar.h nits 2007-08-28 18:23:48 +00:00
grep.c add grep; add lost echo 2007-08-28 04:26:34 +00:00
ide.c make new Homework 8 work 2007-08-30 18:21:35 +00:00
init.c comments; rename irq_ to pic_ 2007-08-28 19:04:36 +00:00
initcode.S Rename main0 to main. 2007-08-27 23:32:16 +00:00
ioapic.c comments; rename irq_ to pic_ 2007-08-28 19:04:36 +00:00
kalloc.c delete unnecessary #include lines 2007-08-27 23:26:33 +00:00
kbd.c comments; rename irq_ to pic_ 2007-08-28 19:04:36 +00:00
kbd.h formatting; split kbd constants into kbd.h 2007-08-14 19:31:16 +00:00
kill.c add kill 2007-08-08 08:50:23 +00:00
lapic.c cleaner 2007-09-27 21:02:03 +00:00
ln.c add ln 2007-08-22 05:54:55 +00:00
ls.c Remove puts in favor of printf. 2007-08-24 20:03:40 +00:00
main.c Re: why cpuid() in locking code? 2007-09-30 14:30:04 +00:00
Makefile This should fix building on FreeBSD 2007-09-19 23:49:52 +00:00
mkdir.c more consistent spacing 2007-08-28 18:32:08 +00:00
mkfs.c fix comments 2007-09-15 20:05:47 +00:00
mmu.h don't call it ss - that's the stack segment 2007-09-27 16:47:50 +00:00
mp.c comments; rename irq_ to pic_ 2007-08-28 19:04:36 +00:00
mp.h Simplify MP hardware code. 2007-08-27 22:53:31 +00:00
Notes nit in console interrupts 2006-09-07 00:00:33 +00:00
param.h simplify ide queuing 2007-08-24 19:32:36 +00:00
picirq.c comments; rename irq_ to pic_ 2007-08-28 19:04:36 +00:00
pipe.c spaces around else for rtm 2007-08-28 18:37:41 +00:00
pr.pl runoff changes 2006-09-08 13:53:18 +00:00
printf.c spaces around else for rtm 2007-08-28 18:37:41 +00:00
proc.c Final word on the locking fiasco? 2007-09-27 21:25:37 +00:00
proc.h Final word on the locking fiasco? 2007-09-27 21:25:37 +00:00
README spelling 2007-08-29 18:18:57 +00:00
rm.c more consistent spacing 2007-08-28 18:32:08 +00:00
runoff tweak 2007-08-30 14:12:19 +00:00
runoff.list final nits 2007-08-28 19:39:49 +00:00
runoff.spec nits 2007-08-28 05:01:04 +00:00
runoff1 PDF at http://am.lcs.mit.edu/~rsc/xv6.pdf 2007-08-22 06:01:32 +00:00
sh.c clumsy cd 2007-08-30 18:30:26 +00:00
show1 PDF at http://am.lcs.mit.edu/~rsc/xv6.pdf 2007-08-22 06:01:32 +00:00
sign.pl spacing fixes: no tabs, 2-space indents (for rtm) 2006-09-06 17:04:06 +00:00
spinlock.c Re: why cpuid() in locking code? 2007-09-30 14:30:04 +00:00
spinlock.h clumsy blank pages to make some files align better 2007-08-28 05:00:39 +00:00
stat.h more comments 2006-09-07 14:12:30 +00:00
string.c spaces around else for rtm 2007-08-28 18:37:41 +00:00
swtch.S yank out stack overflow checking ugliness 2007-09-27 20:38:53 +00:00
symlink.patch symlink implementation 2007-08-30 18:36:38 +00:00
syscall.c spaces around else for rtm 2007-08-28 18:37:41 +00:00
syscall.h Replace yield system call with sleep. 2007-08-27 13:34:35 +00:00
sysfile.c believe it or not, this was working 2007-09-27 05:13:10 +00:00
sysproc.c kernel SMP interruptibility fixes. 2007-09-27 12:58:42 +00:00
timer.c comments; rename irq_ to pic_ 2007-08-28 19:04:36 +00:00
toc.ftr nits 2007-08-28 19:25:04 +00:00
toc.hdr nits 2007-08-28 18:23:48 +00:00
trap.c interrupts during system calls 2007-09-27 21:37:45 +00:00
trapasm.S nits 2007-08-28 18:23:48 +00:00
traps.h typo 2007-08-08 08:27:32 +00:00
TRICKS tricks 2007-09-30 14:20:47 +00:00
types.h align 2007-08-24 20:27:47 +00:00
ulib.c Remove puts in favor of printf. 2007-08-24 20:03:40 +00:00
umalloc.c spaces around else for rtm 2007-08-28 18:37:41 +00:00
user.h add struct stat decl 2007-08-28 04:20:25 +00:00
usertests.c make slow bigdir last test 2007-09-27 12:29:06 +00:00
usys.S Replace yield system call with sleep. 2007-08-27 13:34:35 +00:00
vectors.pl PDF at http://am.lcs.mit.edu/~rsc/xv6.pdf 2007-08-22 06:01:32 +00:00
wc.c more consistent spacing 2007-08-28 18:32:08 +00:00
x86.h Re: why cpuid() in locking code? 2007-09-30 14:30:04 +00:00
xv6-rev0.tar.gz dist tarball 2006-09-08 15:44:42 +00:00
xv6-rev1.tar.gz DO NOT MAIL: xv6-rev1 2007-08-30 14:11:21 +00:00
xv6.pdf final xv6 for 2007 2007-08-30 14:09:14 +00:00
xv6.ps final xv6 for 2007 2007-08-30 14:09:14 +00:00
zombie.c delete unnecessary #include lines 2007-08-27 23:26:33 +00:00

xv6 is a re-implementation of Dennis Ritchie's and Ken Thompson's Unix
Version 6 (v6).  xv6 loosely follows the structure and style of v6,
but is implemented for a modern x86-based multiprocessor using ANSI C.

ACKNOWLEDGMENTS

xv6 is inspired by John Lions's Commentary on UNIX 6th Edition (Peer
to Peer Communications; ISBN: 1-57398-013-7; 1st edition (June 14,
2000)). See also http://pdos.csail.mit.edu/6.828/2007/v6.html, which
provides pointers to on-line resources for v6.

xv6 borrows code from the following sources:
    JOS (asm.h, elf.h, mmu.h, bootasm.S, ide.c, console.c, and others)
    Plan 9 (bootother.S, mp.h, mp.c, lapic.c)
    FreeBSD (ioapic.c)
    NetBSD (console.c)

The following people made contributions:
    Russ Cox (context switching, locking)
    Cliff Frey (MP)
    Xiao Yu (MP)

The code in the files that constitute xv6 is
Copyright 2006-2007 Frans Kaashoek, Robert Morris, and Russ Cox.

ERROR REPORTS

If you spot errors or have suggestions for improvement, please send
email to Frans Kaashoek and Robert Morris (kaashoek,rtm@csail.mit.edu). 

BUILDING AND RUNNING XV6

To build xv6 on an x86 ELF machine (like Linux or FreeBSD), run "make".
On non-x86 or non-ELF machines (like OS X, even on x86), you will
need to install a cross-compiler gcc suite capable of producing x86 ELF
binaries.  See http://pdos.csail.mit.edu/6.828/2007/tools.html.
Then run "make TOOLPREFIX=i386-jos-elf-".

To run xv6, you can use Bochs or QEMU, both PC simulators.
Bochs makes debugging easier, but QEMU is much faster. 
To run in Bochs, run "make bochs" and then type "c" at the bochs prompt.
To run in QEMU, run "make qemu".  Both log the xv6 screen output to 
standard output.

To create a typeset version of the code, run "make xv6.pdf".
This requires the "mpage" text formatting utility.
See http://www.mesa.nl/pub/mpage/.