sanchayanmaity/minix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
minix/kernel/system/do_endksig.c

41 lines
1.2 KiB
C
Raw Normal View History

Al's system call -> kernel call renaming
2005-10-14 10:58:59 +02:00
/* The kernel call that is implemented in this file:
System processes can be signaled; signals are transformed in SYS_EVENT message that passes signal map along. This mechanisms is also used for nonuser signals like SIGKMESS, SIGKSTOP, SIGKSIG. Revised comments of many system call handlers. Renamed setpriority to nice.
2005-07-19 14:21:36 +02:00
* m_type: SYS_ENDKSIG
Reorganized system call library; uses separate file per call now. New configuration header file to include/ exclude functionality. Extracted privileged features from struct proc and create new struct priv. Renamed various system calls for readability.
2005-07-14 17:12:12 +02:00
*
Al's system call -> kernel call renaming
2005-10-14 10:58:59 +02:00
* The parameters for this kernel call are:
'proc number' is process slot, 'endpoint' are generation-aware process instance numbers, encoded and decoded using macros in <minix/endpoint.h>. proc number -> endpoint migration . proc_nr in the interrupt hook is now an endpoint, proc_nr_e. . m_source for messages and notifies is now an endpoint, instead of proc number. . isokendpt() converts an endpoint to a process number, returns success (but fails if the process number is out of range, the process slot is not a living process, or the given endpoint number does not match the endpoint number in the process slot, indicating an old process). . okendpt() is the same as isokendpt(), but panic()s if the conversion fails. This is mainly used for decoding message.m_source endpoints, and other endpoint numbers in kernel data structures, which should always be correct. . if DEBUG_ENABLE_IPC_WARNINGS is enabled, isokendpt() and okendpt() get passed the __FILE__ and __LINE__ of the calling lines, and print messages about what is wrong with the endpoint number (out of range proc, empty proc, or inconsistent endpoint number), with the caller, making finding where the conversion failed easy without having to include code for every call to print where things went wrong. Sometimes this is harmless (wrong arg to a kernel call), sometimes it's a fatal internal inconsistency (bogus m_source). . some process table fields have been appended an _e to indicate it's become and endpoint. . process endpoint is stored in p_endpoint, without generation number. it turns out the kernel never needs the generation number, except when fork()ing, so it's decoded then. . kernel calls all take endpoints as arguments, not proc numbers. the one exception is sys_fork(), which needs to know in which slot to put the child.
2006-03-03 11:00:02 +01:00
* m2_i1: SIG_ENDPT # process for which PM is done
Reorganized system call library; uses separate file per call now. New configuration header file to include/ exclude functionality. Extracted privileged features from struct proc and create new struct priv. Renamed various system calls for readability.
2005-07-14 17:12:12 +02:00
*/
#include "../system.h"
#if USE_ENDKSIG
/*===========================================================================*
* do_endksig *
*===========================================================================*/
This patch removes the global variables who_p and who_e from the kernel (sys task). The main reason is that these would have to become cpu local variables on SMP. Once the system task is not a task but a genuine part of the kernel there is even less reason to have these extra variables as proc_ptr will already contain all neccessary information. In addition converting who_e to the process pointer and back again all the time will be avoided. Although proc_ptr will contain all important information, accessing it as a cpu local variable will be fairly expensive, hence the value would be assigned to some on stack local variable. Therefore it is better to add the 'caller' argument to the syscall handlers to pass the value on stack anyway. It also clearly denotes on who's behalf is the syscall being executed. This patch also ANSIfies the syscall function headers. Last but not least, it also fixes a potential bug in virtual_copy_f() in case the check is disabled. So far the function in case of a failure could possible reuse an old who_p in case this function had not been called from the system task. virtual_copy_f() takes the caller as a parameter too. In case the checking is disabled, the caller must be NULL and non NULL if it is enabled as we must be able to suspend the caller.
2010-02-03 10:04:48 +01:00
PUBLIC int do_endksig(struct proc * caller, message * m_ptr)
Reorganized system call library; uses separate file per call now. New configuration header file to include/ exclude functionality. Extracted privileged features from struct proc and create new struct priv. Renamed various system calls for readability.
2005-07-14 17:12:12 +02:00
{
/* Finish up after a kernel type signal, caused by a SYS_KILL message or a
* call to cause_sig by a task. This is called by the PM after processing a
* signal it got with SYS_GETKSIG.
*/
register struct proc *rp;
proc_addr() returns address based on location in proc array - pproc_addr is not neccessary to get the address of a process if we know its number - local proc variables in system calls implementation (sys_task) conflicts with the global proc array of all process, therefore the variable were renamed to proc_nr as they hold the process number
2009-09-15 11:57:22 +02:00
int proc_nr;
Reorganized system call library; uses separate file per call now. New configuration header file to include/ exclude functionality. Extracted privileged features from struct proc and create new struct priv. Renamed various system calls for readability.
2005-07-14 17:12:12 +02:00
- Kernel call handlers cleaned up. More strict checking of input parameters. - Moved generic_handler() from system.c to system/do_irqctl.c. - Set privileges of system processes somewhat stricter.
2005-07-29 17:26:23 +02:00
/* Get process pointer and verify that it had signals pending. If the
* process is already dead its flags will be reset.
*/
proc_addr() returns address based on location in proc array - pproc_addr is not neccessary to get the address of a process if we know its number - local proc variables in system calls implementation (sys_task) conflicts with the global proc array of all process, therefore the variable were renamed to proc_nr as they hold the process number
2009-09-15 11:57:22 +02:00
if(!isokendpt(m_ptr->SIG_ENDPT, &proc_nr))
Better initialization of the memory map of processes that are part of the image. Removed NO_MAP flag.
2006-05-11 16:49:46 +02:00
return EINVAL;
'proc number' is process slot, 'endpoint' are generation-aware process instance numbers, encoded and decoded using macros in <minix/endpoint.h>. proc number -> endpoint migration . proc_nr in the interrupt hook is now an endpoint, proc_nr_e. . m_source for messages and notifies is now an endpoint, instead of proc number. . isokendpt() converts an endpoint to a process number, returns success (but fails if the process number is out of range, the process slot is not a living process, or the given endpoint number does not match the endpoint number in the process slot, indicating an old process). . okendpt() is the same as isokendpt(), but panic()s if the conversion fails. This is mainly used for decoding message.m_source endpoints, and other endpoint numbers in kernel data structures, which should always be correct. . if DEBUG_ENABLE_IPC_WARNINGS is enabled, isokendpt() and okendpt() get passed the __FILE__ and __LINE__ of the calling lines, and print messages about what is wrong with the endpoint number (out of range proc, empty proc, or inconsistent endpoint number), with the caller, making finding where the conversion failed easy without having to include code for every call to print where things went wrong. Sometimes this is harmless (wrong arg to a kernel call), sometimes it's a fatal internal inconsistency (bogus m_source). . some process table fields have been appended an _e to indicate it's become and endpoint. . process endpoint is stored in p_endpoint, without generation number. it turns out the kernel never needs the generation number, except when fork()ing, so it's decoded then. . kernel calls all take endpoints as arguments, not proc numbers. the one exception is sys_fork(), which needs to know in which slot to put the child.
2006-03-03 11:00:02 +01:00
proc_addr() returns address based on location in proc array - pproc_addr is not neccessary to get the address of a process if we know its number - local proc variables in system calls implementation (sys_task) conflicts with the global proc array of all process, therefore the variable were renamed to proc_nr as they hold the process number
2009-09-15 11:57:22 +02:00
rp = proc_addr(proc_nr);
All macros defining rts flags are prefixed with RTS_ - macros used with RTS_SET group of macros to define struct proc p_rts_flags are now prefixed with RTS_ to make things clear
2009-11-10 10:11:13 +01:00
if (!RTS_ISSET(rp, RTS_SIG_PENDING)) return(EINVAL);
Reorganized system call library; uses separate file per call now. New configuration header file to include/ exclude functionality. Extracted privileged features from struct proc and create new struct priv. Renamed various system calls for readability.
2005-07-14 17:12:12 +02:00
/* PM has finished one kernel signal. Perhaps process is ready now? */
All macros defining rts flags are prefixed with RTS_ - macros used with RTS_SET group of macros to define struct proc p_rts_flags are now prefixed with RTS_ to make things clear
2009-11-10 10:11:13 +01:00
if (!RTS_ISSET(rp, RTS_SIGNALED)) /* new signal arrived */
No locking in kernel code - No locking in RTS_(UN)SET macros - No lock_notify() - Removed unused lock_send() - No lock/unlock macros anymore
2010-02-09 16:26:58 +01:00
RTS_UNSET(rp, RTS_SIG_PENDING); /* remove pending flag */
Reorganized system call library; uses separate file per call now. New configuration header file to include/ exclude functionality. Extracted privileged features from struct proc and create new struct priv. Renamed various system calls for readability.
2005-07-14 17:12:12 +02:00
return(OK);
}
#endif /* USE_ENDKSIG */
Reference in a new issue Copy permalink