sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix a bug to handle the fact that a CPU can send Functional accesses while a sendTiming has not returned in the call stack.

Browse source 
src/mem/cache/base_cache.cc:
    Sometimes a functional access comes while waiting on a outstanding packet being sent.
    This could be because Timing CPU does some post processing on the recvTiming which send functional access.
    Either the CPU should leave the pkt/req around (so They can be referenced in the mem system). Or the mem
    system should remove them from outstanding lists and reinsert them if they fail in the sendTiming.

    I did the later, eventually we should consider doing the former if that is the correct behavior.

--HG--
extra : convert_revision : be41e0d2632369dca9d7c15e96e5576d7583fe6a
This commit is contained in:
Ron Dreslinski 2006-11-13 22:37:22 -05:00
parent db0895084d
commit 903a618714
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/mem/cache/base_cache.cc vendored
View file

@ -160,11 +160,14 @@ BaseCache::CachePort::recvRetry()
PacketPtr pkt; PacketPtr pkt;
assert(waitingOnRetry); assert(waitingOnRetry);
if (!drainList.empty()) { if (!drainList.empty()) {
DPRINTF(CachePort, "%s attempting to send a retry for response\n", name()); DPRINTF(CachePort, "%s attempting to send a retry for response (%i waiting)\n"
, name(), drainList.size());
//We have some responses to drain first //We have some responses to drain first
if (sendTiming(drainList.front())) { pkt = drainList.front();
DPRINTF(CachePort, "%s sucessful in sending a retry for response\n", name()); drainList.pop_front();
drainList.pop_front(); if (sendTiming(pkt)) {
DPRINTF(CachePort, "%s sucessful in sending a retry for"
"response (%i still waiting)\n", name(), drainList.size());
if (!drainList.empty() || if (!drainList.empty() ||
!isCpuSide && cache->doMasterRequest() || !isCpuSide && cache->doMasterRequest() ||
isCpuSide && cache->doSlaveRequest()) { isCpuSide && cache->doSlaveRequest()) {
@ -175,6 +178,9 @@ BaseCache::CachePort::recvRetry()
} }
waitingOnRetry = false; waitingOnRetry = false;
} }
else {
drainList.push_front(pkt);
}
// Check if we're done draining once this list is empty // Check if we're done draining once this list is empty
if (drainList.empty()) if (drainList.empty())
cache->checkDrain(); cache->checkDrain();