From 8139713c46aa63abb65d53fc237a21ffe91aa0bb Mon Sep 17 00:00:00 2001 From: rsc Date: Fri, 10 Aug 2007 17:19:15 +0000 Subject: [PATCH] add note --- BUGS | 11 ++++++++--- trap.c | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/BUGS b/BUGS index 6cc2434..12f245a 100644 --- a/BUGS +++ b/BUGS @@ -11,9 +11,8 @@ proc.c: factor out switching and scheduling code from process code -trap.c - if spin locks are ever held without cli, - trap should call yield() only if nlock == 0 +kalloc.c + more cleanups ide.c: synchronous disk write -> polling disk write. search for (a)synchronous; xv6 doesn't have asynchronous writes. @@ -32,3 +31,9 @@ sysfile.c: general: sizeof parens? +usertests.c: + check for rm of . or .. + +L=$HOME/mit/l +(for i in *.c; do xoc -x xgnu -x ./nodecleq.zeta --typesonly $i; done) 2>&1 | grep warning + diff --git a/trap.c b/trap.c index ed66e99..1faa49e 100644 --- a/trap.c +++ b/trap.c @@ -57,6 +57,7 @@ trap(struct trapframe *tf) proc_exit(); // Force process to give up CPU and let others run. + // If locks were held with interrupts on, would need to check nlock. if(cp->state == RUNNING) yield(); }