bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
152 lines
4.8 KiB
C
152 lines
4.8 KiB
C
/* This file contains a few general purpose utility routines.
|
|
*
|
|
* The entry points into this file are
|
|
* clock_time: ask the clock task for the real time
|
|
* copy: copy a block of data
|
|
* fetch_name: go get a path name from user space
|
|
* no_sys: reject a system call that FS does not handle
|
|
* panic: something awful has occurred; MINIX cannot continue
|
|
* conv2: do byte swapping on a 16-bit int
|
|
* conv4: do byte swapping on a 32-bit long
|
|
*/
|
|
|
|
#include "fs.h"
|
|
#include <minix/com.h>
|
|
#include <minix/endpoint.h>
|
|
#include <unistd.h>
|
|
#include "file.h"
|
|
#include "fproc.h"
|
|
#include "param.h"
|
|
#include "vmnt.h"
|
|
|
|
PRIVATE int panicking; /* inhibits recursive panics during sync */
|
|
|
|
/*===========================================================================*
|
|
* fetch_name *
|
|
*===========================================================================*/
|
|
PUBLIC int fetch_name(path, len, flag)
|
|
char *path; /* pointer to the path in user space */
|
|
int len; /* path length, including 0 byte */
|
|
int flag; /* M3 means path may be in message */
|
|
{
|
|
/* Go get path and put it in 'user_path'.
|
|
* If 'flag' = M3 and 'len' <= M3_STRING, the path is present in 'message'.
|
|
* If it is not, go copy it from user space.
|
|
*/
|
|
register char *rpu, *rpm;
|
|
int r;
|
|
|
|
if (len > PATH_MAX) {
|
|
err_code = ENAMETOOLONG;
|
|
return(EGENERIC);
|
|
}
|
|
|
|
if(len >= sizeof(user_fullpath)) {
|
|
panic(__FILE__, "fetch_name: len too much for user_fullpath", len);
|
|
}
|
|
|
|
/* Check name length for validity. */
|
|
if (len <= 0) {
|
|
err_code = EINVAL;
|
|
printf("vfs: fetch_name: len %d?\n", len);
|
|
return(EGENERIC);
|
|
}
|
|
|
|
if (flag == M3 && len <= M3_STRING) {
|
|
/* Just copy the path from the message to 'user_path'. */
|
|
rpu = &user_fullpath[0];
|
|
rpm = m_in.pathname; /* contained in input message */
|
|
do { *rpu++ = *rpm++; } while (--len);
|
|
r = OK;
|
|
} else {
|
|
/* String is not contained in the message. Get it from user space. */
|
|
r = sys_datacopy(who_e, (vir_bytes) path,
|
|
FS_PROC_NR, (vir_bytes) user_fullpath, (phys_bytes) len);
|
|
}
|
|
|
|
if(user_fullpath[len-1] != '\0') {
|
|
int i;
|
|
printf("vfs: fetch_name: name not null-terminated: ");
|
|
for(i = 0; i < len; i++) {
|
|
printf("%c", user_fullpath[i]);
|
|
}
|
|
printf("\n");
|
|
user_fullpath[len-1] = '\0';
|
|
}
|
|
|
|
return(r);
|
|
}
|
|
|
|
/*===========================================================================*
|
|
* no_sys *
|
|
*===========================================================================*/
|
|
PUBLIC int no_sys()
|
|
{
|
|
/* Somebody has used an illegal system call number */
|
|
printf("VFSno_sys: call %d from %d\n", call_nr, who_e);
|
|
return(SUSPEND);
|
|
}
|
|
|
|
/*===========================================================================*
|
|
* panic *
|
|
*===========================================================================*/
|
|
PUBLIC void panic(who, mess, num)
|
|
char *who; /* who caused the panic */
|
|
char *mess; /* panic message string */
|
|
int num; /* number to go with it */
|
|
{
|
|
/* Something awful has happened. Panics are caused when an internal
|
|
* inconsistency is detected, e.g., a programming error or illegal value of a
|
|
* defined constant.
|
|
*/
|
|
if (panicking) return; /* do not panic during a sync */
|
|
panicking = TRUE; /* prevent another panic during the sync */
|
|
|
|
printf("VFS panic (%s): %s ", who, mess);
|
|
if (num != NO_NUM) printf("%d",num);
|
|
(void) do_sync(); /* flush everything to the disk */
|
|
sys_exit(SELF);
|
|
}
|
|
|
|
|
|
/*===========================================================================*
|
|
* isokendpt_f *
|
|
*===========================================================================*/
|
|
PUBLIC int isokendpt_f(char *file, int line, int endpoint, int *proc, int fatal)
|
|
{
|
|
int failed = 0;
|
|
*proc = _ENDPOINT_P(endpoint);
|
|
if(*proc < 0 || *proc >= NR_PROCS) {
|
|
printf("vfs:%s:%d: proc (%d) from endpoint (%d) out of range\n",
|
|
file, line, *proc, endpoint);
|
|
failed = 1;
|
|
} else if(fproc[*proc].fp_endpoint != endpoint) {
|
|
printf("vfs:%s:%d: proc (%d) from endpoint (%d) doesn't match "
|
|
"known endpoint (%d)\n",
|
|
file, line, *proc, endpoint, fproc[*proc].fp_endpoint);
|
|
failed = 1;
|
|
}
|
|
|
|
if(failed && fatal)
|
|
panic(__FILE__, "isokendpt_f failed", NO_NUM);
|
|
|
|
return failed ? EDEADSRCDST : OK;
|
|
}
|
|
|
|
/*===========================================================================*
|
|
* clock_time *
|
|
*===========================================================================*/
|
|
PUBLIC time_t clock_time()
|
|
{
|
|
/* This routine returns the time in seconds since 1.1.1970. MINIX is an
|
|
* astrophysically naive system that assumes the earth rotates at a constant
|
|
* rate and that such things as leap seconds do not exist.
|
|
*/
|
|
|
|
register int k;
|
|
clock_t uptime;
|
|
|
|
if ( (k=getuptime(&uptime)) != OK) panic(__FILE__,"clock_time err", k);
|
|
return( (time_t) (boottime + (uptime/HZ)));
|
|
}
|
|
|