a209c3ae12
This patch fixes most of current reasons to generate compiler warnings. The changes consist of: - adding missing casts - hiding or unhiding function declarations - including headers where missing - add __UNCONST when assigning a const char * to a char * - adding missing return statements - changing some types from unsigned to signed, as the code seems to want signed ints - converting old-style function definitions to current style (i.e., void func(param1, param2) short param1, param2; {...} to void func (short param1, short param2) {...}) - making the compiler silent about signed vs unsigned comparisons. We have too many of those in the new libc to fix. A number of bugs in the test set were fixed. These bugs were never triggered with our old libc. Consequently, these tests are now forced to link with the new libc or they will generate errors (in particular tests 43 and 55). Most changes in NetBSD libc are limited to moving aroudn "#ifndef __minix" or stuff related to Minix-specific things (code in sys-minix or gen/minix).
225 lines
4.9 KiB
C
225 lines
4.9 KiB
C
/* test 11 */
|
|
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/wait.h>
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <stdio.h>
|
|
|
|
#define ITERATIONS 10
|
|
#define MAX_ERROR 1
|
|
|
|
int errct, subtest;
|
|
char *envp[3] = {"spring", "summer", 0};
|
|
char *passwd_file = "/etc/passwd";
|
|
|
|
_PROTOTYPE(int main, (int argc, char *argv[]));
|
|
_PROTOTYPE(void test11a, (void));
|
|
_PROTOTYPE(void test11b, (void));
|
|
_PROTOTYPE(void test11c, (void));
|
|
_PROTOTYPE(void test11d, (void));
|
|
_PROTOTYPE(void e, (int n));
|
|
|
|
int main(argc, argv)
|
|
int argc;
|
|
char *argv[];
|
|
{
|
|
int i, m = 0xFFFF;
|
|
|
|
if (argc == 2) m = atoi(argv[1]);
|
|
|
|
printf("Test 11 ");
|
|
fflush(stdout); /* have to flush for child's benefit */
|
|
|
|
if (geteuid() != 0) {
|
|
printf("must be setuid root; test aborted\n");
|
|
exit(1);
|
|
}
|
|
if (getuid() == 0) {
|
|
printf("must be setuid root logged in as someone else; test aborted\n");
|
|
exit(1);
|
|
}
|
|
|
|
/*
|
|
system("rm -rf DIR_11; mkdir DIR_11");
|
|
chdir("DIR_11");
|
|
*/
|
|
|
|
for (i = 0; i < ITERATIONS; i++) {
|
|
if (m & 0001) test11a();
|
|
if (m & 0002) test11b();
|
|
if (m & 0004) test11c();
|
|
if (m & 0010) test11d();
|
|
}
|
|
if (errct == 0)
|
|
printf("ok\n");
|
|
else
|
|
printf(" %d errors\n", errct);
|
|
|
|
/*
|
|
chdir("..");
|
|
system("rm -rf DIR_11");
|
|
*/
|
|
return(0);
|
|
}
|
|
|
|
void test11a()
|
|
{
|
|
/* Test exec */
|
|
int n, fd;
|
|
char aa[4];
|
|
|
|
subtest = 1;
|
|
|
|
if (fork()) {
|
|
wait(&n);
|
|
if (n != 25600) e(1);
|
|
unlink("t1");
|
|
unlink("t2");
|
|
} else {
|
|
if (chown("t11a", 10, 20) < 0) e(2);
|
|
chmod("t11a", 0666);
|
|
|
|
/* The following call should fail because the mode has no X
|
|
* bits on. If a bug lets it unexpectedly succeed, the child
|
|
* will print an error message since the arguments are wrong.
|
|
*/
|
|
execl("t11a", (char *) 0, envp); /* should fail -- no X bits */
|
|
|
|
/* Control should come here after the failed execl(). */
|
|
chmod("t11a", 06555);
|
|
if ((fd = creat("t1", 0600)) != 3) e(3);
|
|
if (close(fd) < 0) e(4);
|
|
if (open("t1", O_RDWR) != 3) e(5);
|
|
if (chown("t1", 10, 99) < 0) e(6);
|
|
if ((fd = creat("t2", 0060)) != 4) e(7);
|
|
if (close(fd) < 0) e(8);
|
|
if (open("t2", O_RDWR) != 4) e(9);
|
|
if (chown("t2", 99, 20) < 0) e(10);
|
|
if (setgid(6) < 0) e(11);
|
|
if (setuid(5) < 0) e(12);
|
|
if (getuid() != 5) e(13);
|
|
if (geteuid() != 5) e(14);
|
|
if (getgid() != 6) e(15);
|
|
if (getegid() != 6) e(16);
|
|
aa[0] = 3;
|
|
aa[1] = 5;
|
|
aa[2] = 7;
|
|
aa[3] = 9;
|
|
if (write(3, aa, 4) != 4) e(17);
|
|
lseek(3, 2L, 0);
|
|
execle("t11a", "t11a", "arg0", "arg1", "arg2", (char *) 0, envp);
|
|
e(18);
|
|
printf("Can't exec t11a\n");
|
|
exit(3);
|
|
}
|
|
}
|
|
|
|
void test11b()
|
|
{
|
|
int n;
|
|
char *argv[5];
|
|
|
|
subtest = 2;
|
|
if (fork()) {
|
|
wait(&n);
|
|
if (n != (75 << 8)) e(20);
|
|
} else {
|
|
/* Child tests execv. */
|
|
argv[0] = "t11b";
|
|
argv[1] = "abc";
|
|
argv[2] = "defghi";
|
|
argv[3] = "j";
|
|
argv[4] = 0;
|
|
execv("t11b", argv);
|
|
e(19);
|
|
}
|
|
}
|
|
|
|
void test11c()
|
|
{
|
|
/* Test getlogin() and cuserid(). This test MUST run setuid root. */
|
|
|
|
int n, etc_uid;
|
|
uid_t ruid, euid;
|
|
char *lnamep, *cnamep, *p;
|
|
#define MAXLINELEN 200
|
|
char array[MAXLINELEN], save[L_cuserid], save2[L_cuserid];
|
|
FILE *stream;
|
|
|
|
subtest = 3;
|
|
errno = -2000; /* None of these calls set errno. */
|
|
array[0] = '@';
|
|
array[1] = '0';
|
|
save[0] = '#';
|
|
save[1] = '0';
|
|
ruid = getuid();
|
|
euid = geteuid();
|
|
lnamep = getlogin();
|
|
strcpy(save, lnamep);
|
|
cnamep = cuserid(array);
|
|
strcpy(save2, cnamep);
|
|
|
|
/* Because we are setuid root, cuser == array == 'root'; login != 'root' */
|
|
if (euid != 0) e(1);
|
|
if (ruid == 0) e(2);
|
|
if (strcmp(cnamep, "root") != 0) e(3);
|
|
if (strcmp(array, "root") != 0) e(4);
|
|
if ( (n = strlen(save)) == 0) e(5);
|
|
if (strcmp(save, cnamep) == 0) e(6); /* they must be different */
|
|
cnamep = cuserid(NULL);
|
|
if (strcmp(cnamep, save2) != 0) e(7);
|
|
|
|
/* Check login against passwd file. First lookup login in /etc/passwd. */
|
|
if (n == 0) return; /* if login not found, don't look it up */
|
|
if ( (stream = fopen(passwd_file, "r")) == NULL) e(8);
|
|
while (fgets(array, sizeof(array), stream) != NULL) {
|
|
if (strncmp(array, save, n) == 0) {
|
|
p = &array[0]; /* hunt for uid */
|
|
while (*p != ':') p++;
|
|
p++;
|
|
while (*p != ':') p++;
|
|
p++; /* p now points to uid */
|
|
etc_uid = atoi(p);
|
|
if (etc_uid != ruid) e(9);
|
|
break; /* 1 entry per login please */
|
|
}
|
|
}
|
|
fclose(stream);
|
|
}
|
|
|
|
void test11d()
|
|
{
|
|
int fd;
|
|
struct stat statbuf;
|
|
|
|
subtest = 4;
|
|
fd = creat("T11.1", 0750);
|
|
if (fd < 0) e(1);
|
|
if (chown("T11.1", 8, 1) != 0) e(2);
|
|
if (chmod("T11.1", 0666) != 0) e(3);
|
|
if (stat("T11.1", &statbuf) != 0) e(4);
|
|
if ((statbuf.st_mode & (S_IRWXU | S_IRWXG | S_IRWXO)) != 0666) e(5);
|
|
if (close(fd) != 0) e(6);
|
|
if (unlink("T11.1") != 0) e(7);
|
|
}
|
|
|
|
void e(n)
|
|
int n;
|
|
{
|
|
int err_num = errno; /* save errno in case printf clobbers it */
|
|
|
|
printf("Subtest %d, error %d errno=%d ", subtest, n, errno);
|
|
errno = err_num; /* restore errno, just in case */
|
|
perror("");
|
|
if (errct++ > MAX_ERROR) {
|
|
printf("Too many errors; test aborted\n");
|
|
chdir("..");
|
|
system("rm -rf DIR*");
|
|
exit(1);
|
|
}
|
|
}
|