41e9fedf87
bugfixes:
SYSTEM:
. removed
rc->p_priv->s_flags = 0;
for the priv struct shared by all user processes in get_priv(). this
should only be done once. doing a SYS_PRIV_USER in sys_privctl()
caused the flags of all user processes to be reset, so they were no
longer PREEMPTIBLE. this happened when RS executed a policy script.
(this broke test1 in the test set)
VFS/MFS:
. chown can change the mode of a file, and chmod arguments are only
part of the full file mode so the full filemode is slightly magic.
changed these calls so that the final modes are returned to VFS, so
that the vnode can be kept up-to-date.
(this broke test11 in the test set)
MFS:
. lookup() checked for sizeof(string) instead of sizeof(user_path),
truncating long path names
(caught by test 23)
. truncate functions neglected to update ctime
(this broke test16)
VFS:
. corner case of an empty filename lookup caused fields of a request
not to be filled in in the lookup functions, not making it clear
that the lookup had failed, causing messages to garbage processes,
causing strange failures.
(caught by test 30)
. trust v_size in vnode when doing reads or writes on non-special
files, truncating i/o where necessary; this is necessary for pipes,
as MFS can't tell when a pipe has been truncated without it being
told explicitly each time.
when the last reader/writer on a pipe closes, tell FS about
the new size using truncate_vn().
(this broke test 25, among others)
. permission check for chdir() had disappeared; added a
forbidden() call
(caught by test 23)
new code, shouldn't change anything:
. introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their
LOCK variants. These macros set and clear the p_rts_flags field,
causing a lot of duplicated logic like
old_flags = rp->p_rts_flags; /* save value of the flags */
rp->p_rts_flags &= ~NO_PRIV;
if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp);
to change into the simpler
RTS_LOCK_UNSET(rp, NO_PRIV);
so the macros take care of calling dequeue() and enqueue() (or lock_*()),
as the case may be). This makes the code a bit more readable and a
bit less fragile.
. removed return code from do_clocktick in CLOCK as it currently
never replies
. removed some debug code from VFS
. fixed grant debug message in device.c
preemptive checks, tests, changes:
. added return code checks of receive() to SYSTEM and CLOCK
. O_TRUNC should never arrive at MFS (added sanity check and removed
O_TRUNC code)
. user_path declared with PATH_MAX+1 to let it be null-terminated
. checks in MFS to see if strings passed by VFS are null-terminated
IS:
. static irq name table thrown out
37 lines
1.7 KiB
C
37 lines
1.7 KiB
C
/* EXTERN should be extern except for the table file */
|
|
#ifdef _TABLE
|
|
#undef EXTERN
|
|
#define EXTERN
|
|
#endif
|
|
|
|
/* File System global variables */
|
|
EXTERN struct fproc *fp; /* pointer to caller's fproc struct */
|
|
EXTERN int super_user; /* 1 if caller is super_user, else 0 */
|
|
EXTERN int susp_count; /* number of procs suspended on pipe */
|
|
EXTERN int nr_locks; /* number of locks currently in place */
|
|
EXTERN int reviving; /* number of pipe processes to be revived */
|
|
|
|
EXTERN Dev_t root_dev; /* device number of the root device */
|
|
EXTERN int ROOT_FS_E; /* kernel endpoint of the root FS proc */
|
|
EXTERN int last_login_fs_e; /* endpoint of the FS proc that logged in
|
|
before the corresponding mount request */
|
|
EXTERN time_t boottime; /* time in seconds at system boot */
|
|
|
|
/* The parameters of the call are kept here. */
|
|
EXTERN message m_in; /* the input message itself */
|
|
EXTERN message m_out; /* the output message used for reply */
|
|
EXTERN int who_p, who_e; /* caller's proc number, endpoint */
|
|
EXTERN int call_nr; /* system call number */
|
|
EXTERN message mount_m_in; /* the input message itself */
|
|
|
|
EXTERN char user_fullpath[PATH_MAX+1]; /* storage for user path name */
|
|
EXTERN short cum_path_processed; /* number of characters processed */
|
|
|
|
/* The following variables are used for returning results to the caller. */
|
|
EXTERN int err_code; /* temporary storage for error number */
|
|
EXTERN int rdwt_err; /* status of last disk i/o request */
|
|
|
|
/* Data initialized elsewhere. */
|
|
extern _PROTOTYPE (int (*call_vec[]), (void) ); /* sys call table */
|
|
extern char dot1[2]; /* dot1 (&dot1[0]) and dot2 (&dot2[0]) have a special */
|
|
extern char dot2[3]; /* meaning to search_dir: no access permission check. */
|