565f13088f
Change the kernel to add features to vircopy and safecopies so that
transparent copy fixing won't happen to avoid deadlocks, and such copies
fail with EFAULT.
Transparently making copying work from filesystems (as normally done by
the kernel & VM when copying fails because of missing/readonly memory)
is problematic as it can happen that, for file-mapped ranges, that that
same filesystem that is blocked on the copy request is needed to satisfy
the memory range, leading to deadlock. Dito for VFS itself, if done with
a blocking call.
This change makes the copying done from a filesystem fail in such cases
with EFAULT by VFS adding the CPF_TRY flag to the grants. If a FS call
fails with EFAULT, VFS will then request the range to be made available
to VM after the FS is unblocked, allowing it to be used to satisfy the
range if need be in another VFS thread.
Similarly, for datacopies that VFS itself does, it uses the failable
vircopy variant and callers use a wrapper that talk to VM if necessary
to get the copy to work.
. kernel: add CPF_TRY flag to safecopies
. kernel: only request writable ranges to VM for the
target buffer when copying fails
. do copying in VFS TRY-first
. some fixes in VM to build SANITYCHECK mode
. add regression test for the cases where
- a FS system call needs memory mapped in a process that the
FS itself must map.
- such a range covers more than one file-mapped region.
. add 'try' mode to vircopy, physcopy
. add flags field to copy kernel call messages
. if CP_FLAG_TRY is set, do not transparently try
to fix memory ranges
. for use by VFS when accessing user buffers to avoid
deadlock
. remove some obsolete backwards compatability assignments
. VFS: let thread scheduling work for VM requests too
Allows VFS to make calls to VM while suspending and resuming
the currently running thread. Does currently not work for the
main thread.
. VM: add fix memory range call for use by VFS
Change-Id: I295794269cea51a3163519a9cfe5901301d90b32
93 lines
3 KiB
C
93 lines
3 KiB
C
/* The kernel call implemented in this file:
|
|
* m_type: SYS_VIRCOPY, SYS_PHYSCOPY
|
|
*
|
|
* The parameters for this kernel call are:
|
|
* m5_l1: CP_SRC_ADDR source offset within segment
|
|
* m5_i1: CP_SRC_ENDPT source process number
|
|
* m5_l2: CP_DST_ADDR destination offset within segment
|
|
* m5_i2: CP_DST_ENDPT destination process number
|
|
* m5_l3: CP_NR_BYTES number of bytes to copy
|
|
*/
|
|
|
|
#include "kernel/system.h"
|
|
#include "kernel/vm.h"
|
|
#include <minix/type.h>
|
|
#include <assert.h>
|
|
|
|
#if (USE_VIRCOPY || USE_PHYSCOPY)
|
|
|
|
/*===========================================================================*
|
|
* do_copy *
|
|
*===========================================================================*/
|
|
int do_copy(struct proc * caller, message * m_ptr)
|
|
{
|
|
/* Handle sys_vircopy() and sys_physcopy(). Copy data using virtual or
|
|
* physical addressing. Although a single handler function is used, there
|
|
* are two different kernel calls so that permissions can be checked.
|
|
*/
|
|
struct vir_addr vir_addr[2]; /* virtual source and destination address */
|
|
phys_bytes bytes; /* number of bytes to copy */
|
|
int i;
|
|
|
|
#if 0
|
|
if (caller->p_endpoint != PM_PROC_NR && caller->p_endpoint != VFS_PROC_NR &&
|
|
caller->p_endpoint != RS_PROC_NR && caller->p_endpoint != MEM_PROC_NR &&
|
|
caller->p_endpoint != VM_PROC_NR)
|
|
{
|
|
static int first=1;
|
|
if (first)
|
|
{
|
|
first= 0;
|
|
printf(
|
|
"do_copy: got request from %d (source %d, destination %d)\n",
|
|
caller->p_endpoint,
|
|
m_ptr->CP_SRC_ENDPT,
|
|
m_ptr->CP_DST_ENDPT);
|
|
}
|
|
}
|
|
#endif
|
|
|
|
/* Dismember the command message. */
|
|
vir_addr[_SRC_].proc_nr_e = m_ptr->CP_SRC_ENDPT;
|
|
vir_addr[_DST_].proc_nr_e = m_ptr->CP_DST_ENDPT;
|
|
|
|
vir_addr[_SRC_].offset = (vir_bytes) m_ptr->CP_SRC_ADDR;
|
|
vir_addr[_DST_].offset = (vir_bytes) m_ptr->CP_DST_ADDR;
|
|
bytes = (phys_bytes) m_ptr->CP_NR_BYTES;
|
|
|
|
/* Now do some checks for both the source and destination virtual address.
|
|
* This is done once for _SRC_, then once for _DST_.
|
|
*/
|
|
for (i=_SRC_; i<=_DST_; i++) {
|
|
int p;
|
|
/* Check if process number was given implicitly with SELF and is valid. */
|
|
if (vir_addr[i].proc_nr_e == SELF)
|
|
vir_addr[i].proc_nr_e = caller->p_endpoint;
|
|
if (vir_addr[i].proc_nr_e != NONE) {
|
|
if(! isokendpt(vir_addr[i].proc_nr_e, &p)) {
|
|
printf("do_copy: %d: %d not ok endpoint\n", i, vir_addr[i].proc_nr_e);
|
|
return(EINVAL);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Check for overflow. This would happen for 64K segments and 16-bit
|
|
* vir_bytes. Especially copying by the PM on do_fork() is affected.
|
|
*/
|
|
if (bytes != (phys_bytes) (vir_bytes) bytes) return(E2BIG);
|
|
|
|
/* Now try to make the actual virtual copy. */
|
|
if(m_ptr->CP_FLAGS & CP_FLAG_TRY) {
|
|
int r;
|
|
assert(caller->p_endpoint == VFS_PROC_NR);
|
|
r = virtual_copy(&vir_addr[_SRC_], &vir_addr[_DST_], bytes);
|
|
if(r == EFAULT_SRC || r == EFAULT_DST) return r = EFAULT;
|
|
return r;
|
|
} else {
|
|
return( virtual_copy_vmcheck(caller, &vir_addr[_SRC_],
|
|
&vir_addr[_DST_], bytes) );
|
|
}
|
|
}
|
|
#endif /* (USE_VIRCOPY || USE_PHYSCOPY) */
|
|
|