f4a2713ac8
Change-Id: Ia40e9ffdf29b5dab2f122f673ff6802a58bc690f
92 lines
3 KiB
C++
92 lines
3 KiB
C++
//== ArrayBoundChecker.cpp ------------------------------*- C++ -*--==//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines ArrayBoundChecker, which is a path-sensitive check
|
|
// which looks for an out-of-bound array element access.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ClangSACheckers.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
class ArrayBoundChecker :
|
|
public Checker<check::Location> {
|
|
mutable OwningPtr<BuiltinBug> BT;
|
|
public:
|
|
void checkLocation(SVal l, bool isLoad, const Stmt* S,
|
|
CheckerContext &C) const;
|
|
};
|
|
}
|
|
|
|
void ArrayBoundChecker::checkLocation(SVal l, bool isLoad, const Stmt* LoadS,
|
|
CheckerContext &C) const {
|
|
// Check for out of bound array element access.
|
|
const MemRegion *R = l.getAsRegion();
|
|
if (!R)
|
|
return;
|
|
|
|
const ElementRegion *ER = dyn_cast<ElementRegion>(R);
|
|
if (!ER)
|
|
return;
|
|
|
|
// Get the index of the accessed element.
|
|
DefinedOrUnknownSVal Idx = ER->getIndex().castAs<DefinedOrUnknownSVal>();
|
|
|
|
// Zero index is always in bound, this also passes ElementRegions created for
|
|
// pointer casts.
|
|
if (Idx.isZeroConstant())
|
|
return;
|
|
|
|
ProgramStateRef state = C.getState();
|
|
|
|
// Get the size of the array.
|
|
DefinedOrUnknownSVal NumElements
|
|
= C.getStoreManager().getSizeInElements(state, ER->getSuperRegion(),
|
|
ER->getValueType());
|
|
|
|
ProgramStateRef StInBound = state->assumeInBound(Idx, NumElements, true);
|
|
ProgramStateRef StOutBound = state->assumeInBound(Idx, NumElements, false);
|
|
if (StOutBound && !StInBound) {
|
|
ExplodedNode *N = C.generateSink(StOutBound);
|
|
if (!N)
|
|
return;
|
|
|
|
if (!BT)
|
|
BT.reset(new BuiltinBug("Out-of-bound array access",
|
|
"Access out-of-bound array element (buffer overflow)"));
|
|
|
|
// FIXME: It would be nice to eventually make this diagnostic more clear,
|
|
// e.g., by referencing the original declaration or by saying *why* this
|
|
// reference is outside the range.
|
|
|
|
// Generate a report for this bug.
|
|
BugReport *report =
|
|
new BugReport(*BT, BT->getDescription(), N);
|
|
|
|
report->addRange(LoadS->getSourceRange());
|
|
C.emitReport(report);
|
|
return;
|
|
}
|
|
|
|
// Array bound check succeeded. From this point forward the array bound
|
|
// should always succeed.
|
|
C.addTransition(StInBound);
|
|
}
|
|
|
|
void ento::registerArrayBoundChecker(CheckerManager &mgr) {
|
|
mgr.registerChecker<ArrayBoundChecker>();
|
|
}
|