cca24d06d8
kernel (sys task). The main reason is that these would have to become cpu local variables on SMP. Once the system task is not a task but a genuine part of the kernel there is even less reason to have these extra variables as proc_ptr will already contain all neccessary information. In addition converting who_e to the process pointer and back again all the time will be avoided. Although proc_ptr will contain all important information, accessing it as a cpu local variable will be fairly expensive, hence the value would be assigned to some on stack local variable. Therefore it is better to add the 'caller' argument to the syscall handlers to pass the value on stack anyway. It also clearly denotes on who's behalf is the syscall being executed. This patch also ANSIfies the syscall function headers. Last but not least, it also fixes a potential bug in virtual_copy_f() in case the check is disabled. So far the function in case of a failure could possible reuse an old who_p in case this function had not been called from the system task. virtual_copy_f() takes the caller as a parameter too. In case the checking is disabled, the caller must be NULL and non NULL if it is enabled as we must be able to suspend the caller.
44 lines
1.5 KiB
C
44 lines
1.5 KiB
C
/* The kernel call that is implemented in this file:
|
|
* m_type: SYS_KILL
|
|
*
|
|
* The parameters for this kernel call are:
|
|
* m2_i1: SIG_ENDPT # process to signal/ pending
|
|
* m2_i2: SIG_NUMBER # signal number to send to process
|
|
*/
|
|
|
|
#include "../system.h"
|
|
#include <signal.h>
|
|
|
|
#if USE_KILL
|
|
|
|
/*===========================================================================*
|
|
* do_kill *
|
|
*===========================================================================*/
|
|
PUBLIC int do_kill(struct proc * caller, message * m_ptr)
|
|
{
|
|
/* Handle sys_kill(). Cause a signal to be sent to a process. The PM is the
|
|
* central server where all signals are processed and handler policies can
|
|
* be registered. Any request, except for PM requests, is added to the map
|
|
* of pending signals and the PM is informed about the new signal.
|
|
* Since system servers cannot use normal POSIX signal handlers (because they
|
|
* are usually blocked on a RECEIVE), they can request the PM to transform
|
|
* signals into messages. This is done by the PM with a call to sys_kill().
|
|
*/
|
|
proc_nr_t proc_nr, proc_nr_e;
|
|
int sig_nr = m_ptr->SIG_NUMBER;
|
|
|
|
proc_nr_e= (proc_nr_t) m_ptr->SIG_ENDPT;
|
|
|
|
if (!isokendpt(proc_nr_e, &proc_nr)) return(EINVAL);
|
|
if (sig_nr >= _NSIG) return(EINVAL);
|
|
if (iskerneln(proc_nr)) return(EPERM);
|
|
|
|
/* Set pending signal to be processed by the PM. */
|
|
cause_sig(proc_nr, sig_nr);
|
|
if (sig_nr == SIGKILL)
|
|
clear_endpoint(proc_addr(proc_nr));
|
|
return(OK);
|
|
}
|
|
|
|
#endif /* USE_KILL */
|
|
|