TTY: printer better diagnostics

.tell when a line is not initialized
.don't print when a request has failed, we use error codes for that
This commit is contained in:
Thomas Veerman 2012-09-24 15:25:37 +00:00
parent a458e9d00d
commit e61268c454
2 changed files with 3 additions and 3 deletions

View file

@ -444,7 +444,9 @@ void rs_init(tty_t *tp)
* for all requests on it from userland. (The kernel will use it.) * for all requests on it from userland. (The kernel will use it.)
*/ */
if(env_get_param(SERVARNAME, l, sizeof(l)-1) == OK && atoi(l) == line) { if(env_get_param(SERVARNAME, l, sizeof(l)-1) == OK && atoi(l) == line) {
return; printf("TTY: not initializing rs232 line %d (in use by kernel)\n",
line);
return;
} }
rs = tp->tty_priv = &rs_lines[line]; rs = tp->tty_priv = &rs_lines[line];

View file

@ -258,8 +258,6 @@ int main(void)
/* If the device doesn't exist or is not configured return ENXIO. */ /* If the device doesn't exist or is not configured return ENXIO. */
if (tp == NULL || ! tty_active(tp)) { if (tp == NULL || ! tty_active(tp)) {
printf("Warning, TTY got illegal request %d from %d\n",
tty_mess.m_type, tty_mess.m_source);
if (tty_mess.m_source != LOG_PROC_NR) if (tty_mess.m_source != LOG_PROC_NR)
{ {
tty_reply(TASK_REPLY, tty_mess.m_source, tty_reply(TASK_REPLY, tty_mess.m_source,