sanchayanmaity/minix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

VFS: fix short select(2) timeouts

Browse source 
Some select queries require a response from device drivers.  If a
select call is nonblocking (with a zero timeout), the response to
the caller may have to be deferred until all involved drivers have
responded to the initial query.  This is handled just fine.

However, if the select call has a timeout that is so short that it
triggers before all the involved drivers have responded, the
resulting alarm would be discarded, possibly resulting in the call
blocking forever.  This fix changes the alarm handler such that if
the alarm triggers too early, the select call is further handled
as though it was nonblocking.

This fix resolves a test77 deadlock on really slow systems.

Change-Id: Ib487c8fe436802c3e11c57355ae0c8480721f06e
This commit is contained in:
David van Moolenbroek 2015-09-16 10:41:46 +00:00
parent fefec20e6b
commit de95c84d3e
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
minix/servers/vfs/select.c
View file

@ -755,8 +755,10 @@ void select_timeout_check(minix_timer_t *timer)
if (se->requestor == NULL) return;
if (se->expiry <= 0) return; /* Strange, did we even ask for a timeout? */
se->expiry = 0;
if (is_deferred(se)) return; /* Wait for initial replies to CDEV_SELECT */
select_return(se);
if (!is_deferred(se))
select_return(se);
else
se->block = 0; /* timer triggered "too soon", treat as nonblocking */
}