sanchayanmaity/minix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tests: don't chmod 777 everything upon cleanup

Browse source 
rm -rf works just fine no matter what mode bits are set (modulo
file ownership and current user id). Test 43 creates a symlink
to / and the chmod operation would change file permissions outside
of the test directory.
This commit is contained in:
Thomas Veerman 2012-09-19 14:58:32 +00:00
parent bc4c07f4f1
commit 6cb94cc91b
1 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
test/common.c
View file

@ -80,14 +80,6 @@ int test_nr;
{ {
char buf[128]; char buf[128];
/* "rm -rf dir" will not work unless all the subdirectories have suitable
* permissions. Minix chmod is not recursive so it is not easy to change
* all the permissions. I had to fix opendir() to stop the bash shell
* from hanging when it opendir()s fifos.
*/
sprintf(buf, "chmod 777 DIR_%02d DIR_%02d/* DIR_%02d/*/* >/dev/null 2>&1",
test_nr, test_nr, test_nr);
(void) system(buf); /* usually fails */
sprintf(buf, "rm -rf DIR_%02d >/dev/null 2>&1", test_nr); sprintf(buf, "rm -rf DIR_%02d >/dev/null 2>&1", test_nr);
if (system(buf) != 0) printf("Warning: system(\"%s\") failed\n", buf); if (system(buf) != 0) printf("Warning: system(\"%s\") failed\n", buf);
} }