do_schedule() cleanup
- it is not neccessary to test whether the scheduler is a system process as the process already head permissions to make this call. - it is better to test whether the scheduler has permission to make changes to this process before testing whether the values are valid.
This commit is contained in:
parent
65ef539739
commit
485a037563
|
@ -12,19 +12,15 @@ PUBLIC int do_schedule(struct proc * caller, message * m_ptr)
|
||||||
|
|
||||||
p = proc_addr(_ENDPOINT_P(m_ptr->SCHEDULING_ENDPOINT));
|
p = proc_addr(_ENDPOINT_P(m_ptr->SCHEDULING_ENDPOINT));
|
||||||
|
|
||||||
|
/* Only this process' scheduler can schedule it */
|
||||||
|
if (caller != p->p_scheduler)
|
||||||
|
return(EPERM);
|
||||||
|
|
||||||
/* Make sure the priority number given is within the allowed range.*/
|
/* Make sure the priority number given is within the allowed range.*/
|
||||||
if (m_ptr->SCHEDULING_PRIORITY < TASK_Q ||
|
if (m_ptr->SCHEDULING_PRIORITY < TASK_Q ||
|
||||||
m_ptr->SCHEDULING_PRIORITY > NR_SCHED_QUEUES)
|
m_ptr->SCHEDULING_PRIORITY > NR_SCHED_QUEUES)
|
||||||
return(EINVAL);
|
return(EINVAL);
|
||||||
|
|
||||||
/* Only system processes can schedule processes */
|
|
||||||
if (! (priv(caller)->s_flags & SYS_PROC))
|
|
||||||
return(EPERM);
|
|
||||||
|
|
||||||
/* Only this process' scheduler can schedule it */
|
|
||||||
if (caller != p->p_scheduler)
|
|
||||||
return(EPERM);
|
|
||||||
|
|
||||||
/* In some cases, we might be rescheduling a runnable process. In such
|
/* In some cases, we might be rescheduling a runnable process. In such
|
||||||
* a case (i.e. if we are updating the priority) we set the NO_QUANTUM
|
* a case (i.e. if we are updating the priority) we set the NO_QUANTUM
|
||||||
* flag before the generic unset to dequeue/enqueue the process
|
* flag before the generic unset to dequeue/enqueue the process
|
||||||
|
|
Loading…
Reference in a new issue