sanchayanmaity/minix
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

PM: a few Coverity inspired fixes

Browse source 
.initialize variable to prevent negative array indexing
.remove dead code
This commit is contained in:
Thomas Veerman 2012-07-26 15:18:21 +00:00
parent ca085c16ef
commit 238a9a057b
2 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
servers/pm/forkexit.c
View file

@ -47,7 +47,7 @@ int do_fork()
register struct mproc *rmp; /* pointer to parent */ register struct mproc *rmp; /* pointer to parent */
register struct mproc *rmc; /* pointer to child */ register struct mproc *rmc; /* pointer to child */
pid_t new_pid; pid_t new_pid;
static int next_child; static int next_child = 0;
int i, n = 0, s; int i, n = 0, s;
endpoint_t child_ep; endpoint_t child_ep;
message m; message m;
@ -146,7 +146,7 @@ int do_srv_fork()
register struct mproc *rmc; /* pointer to child */ register struct mproc *rmc; /* pointer to child */
int s; int s;
pid_t new_pid; pid_t new_pid;
static int next_child; static int next_child = 0;
int i, n = 0; int i, n = 0;
endpoint_t child_ep; endpoint_t child_ep;
message m; message m;

9
servers/pm/main.c
View file

@ -90,18 +90,11 @@ int main()
/* Check for system notifications first. Special cases. */ /* Check for system notifications first. Special cases. */
if (is_ipc_notify(ipc_status)) { if (is_ipc_notify(ipc_status)) {
switch(who_p) { if (who_p == CLOCK) {
case CLOCK:
expire_timers(m_in.NOTIFY_TIMESTAMP); expire_timers(m_in.NOTIFY_TIMESTAMP);
result = SUSPEND; /* don't reply */
break;
default :
/* ignore notify() from unknown sender */
result = SUSPEND;
} }
/* done, send reply and continue */ /* done, send reply and continue */
if (result != SUSPEND) setreply(who_p, result);
sendreply(); sendreply();
continue; continue;
} }