From 013226c417480e0645e83b8ca4ef7cfe64614446 Mon Sep 17 00:00:00 2001 From: Ben Gras Date: Wed, 5 Mar 2014 15:12:54 +0100 Subject: [PATCH] vfs: call pipe_check before reviving select() . select callback on close() on a pipe would falsely revive a read-select on the pipe . the extra pipe_check catches it . fixes the new import of the netbsd make in -j N mode (make jobs that communicate with pipes) --- servers/vfs/pipe.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/servers/vfs/pipe.c b/servers/vfs/pipe.c index ce0909727..f9e2c6ad6 100644 --- a/servers/vfs/pipe.c +++ b/servers/vfs/pipe.c @@ -392,7 +392,16 @@ int count; /* max number of processes to release */ if (f->filp_count < 1 || !(f->filp_pipe_select_ops & selop) || f->filp_vno != vp) continue; + + /* Do a pipe_check to see if we really want to callback this + * select; a close() doesn't always warrant it. + */ + if(pipe_check(f, op == VFS_READ ? READING : WRITING, + f->filp_flags & ~O_NONBLOCK, 1, 1) == SUSPEND) { + continue; + } select_callback(f, selop); + f->filp_pipe_select_ops &= ~selop; } }