minix/servers/vfs/request.c

1427 lines
35 KiB
C
Raw Normal View History

2007-08-07 14:52:47 +02:00
/* This file deals with protection in the file system. It contains the code
* for four system calls that relate to protection.
*
2007-08-07 14:52:47 +02:00
* The entry points into this file are
* do_chmod: perform the CHMOD and FCHMOD system calls
* do_chown: perform the CHOWN and FCHOWN system calls
* do_umask: perform the UMASK system call
* do_access: perform the ACCESS system call
*
* Changes for VFS:
* Jul 2006 (Balazs Gerofi)
*/
#include "fs.h"
#include <unistd.h>
2007-08-07 14:52:47 +02:00
#include <minix/callnr.h>
#include "file.h"
#include "fproc.h"
#include "param.h"
#include <minix/vfsif.h>
#include "vnode.h"
2007-08-07 14:52:47 +02:00
#include "vmnt.h"
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* do_chmod *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int do_chmod()
{
2007-08-07 14:52:47 +02:00
struct filp *flp;
struct vnode *vp;
int r;
uid_t uid;
gid_t gid;
mode_t new_mode;
if (call_nr == CHMOD) {
/* Perform the chmod(name, mode) system call. */
if (fetch_name(m_in.name, m_in.name_length, M3) != OK) return(err_code);
/* Request lookup */
r = lookup_vp(0 /*flags*/, 0 /*!use_realuid*/, &vp);
if (r != OK) return r;
}
else if (call_nr == FCHMOD) {
if (!(flp = get_filp(m_in.m3_i1))) return err_code;
vp= flp->filp_vno;
dup_vnode(vp);
}
else panic(__FILE__, "do_chmod called with strange call_nr", call_nr);
2007-08-07 14:52:47 +02:00
uid= fp->fp_effuid;
gid= fp->fp_effgid;
2007-08-07 14:52:47 +02:00
/* Only the owner or the super_user may change the mode of a file.
* No one may change the mode of a file on a read-only file system.
*/
if (vp->v_uid != uid && uid != SU_UID)
r = EPERM;
else
r = read_only(vp);
2007-08-07 14:52:47 +02:00
/* If error, return inode. */
if (r != OK) {
put_vnode(vp);
return(r);
}
2007-08-07 14:52:47 +02:00
/* Now make the change. Clear setgid bit if file is not in caller's grp */
if (uid != SU_UID && vp->v_gid != gid)
m_in.mode &= ~I_SET_GID_BIT;
2007-08-07 14:52:47 +02:00
/* Issue request */
r = req_chmod(vp->v_fs_e, vp->v_inode_nr, m_in.mode, &new_mode);
2007-08-07 14:52:47 +02:00
if (r == OK)
vp->v_mode = new_mode;
put_vnode(vp);
2007-08-07 14:52:47 +02:00
return OK;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* do_chown *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int do_chown()
{
2007-08-07 14:52:47 +02:00
int inode_nr;
int fs_e;
struct filp *flp;
struct vnode *vp;
int r;
uid_t uid;
gid_t gid;
mode_t new_mode;
if (call_nr == CHOWN) {
/* Perform the chmod(name, mode) system call. */
if (fetch_name(m_in.name1, m_in.name1_length, M1) != OK) return(err_code);
/* Request lookup */
r = lookup_vp(0 /*flags*/, 0 /*!use_realuid*/, &vp);
if (r != OK) return r;
}
else if (call_nr == FCHOWN) {
if (!(flp = get_filp(m_in.m1_i1))) return err_code;
vp= flp->filp_vno;
dup_vnode(vp);
}
else panic(__FILE__, "do_chmod called with strange call_nr", call_nr);
uid= fp->fp_effuid;
gid= fp->fp_effgid;
r= OK;
if (uid == SU_UID) {
/* The super user can do anything. */
} else {
/* Regular users can only change groups of their own files. */
if (vp->v_uid != uid)
r = EPERM; /* File does not belong to the caller */
if (vp->v_uid != m_in.owner)
r = EPERM; /* no giving away */
if (gid != m_in.group)
r = EPERM; /* only change to the current gid */
}
if (r != OK) {
put_vnode(vp);
return r;
}
2007-08-07 14:52:47 +02:00
/* Issue request */
r = req_chown(vp->v_fs_e, vp->v_inode_nr, m_in.owner, m_in.group, &new_mode);
2007-08-07 14:52:47 +02:00
if(r == OK) {
vp->v_uid = m_in.owner;
vp->v_gid = m_in.group;
vp->v_mode = new_mode;
}
2007-08-07 14:52:47 +02:00
put_vnode(vp);
2007-08-07 14:52:47 +02:00
return r;
}
2007-01-05 17:36:55 +01:00
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* do_umask *
2007-01-05 17:36:55 +01:00
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int do_umask()
2007-01-05 17:36:55 +01:00
{
2007-08-07 14:52:47 +02:00
/* Perform the umask(co_mode) system call. */
register mode_t r;
2007-01-05 17:36:55 +01:00
2007-08-07 14:52:47 +02:00
r = ~fp->fp_umask; /* set 'r' to complement of old mask */
fp->fp_umask = ~(m_in.co_mode & RWX_MODES);
return(r); /* return complement of old mask */
2007-01-05 17:36:55 +01:00
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* do_access *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int do_access()
{
2007-08-07 14:52:47 +02:00
/* Perform the access(name, mode) system call. */
int r;
struct vnode *vp;
2007-08-07 14:52:47 +02:00
/* First check to see if the mode is correct. */
if ( (m_in.mode & ~(R_OK | W_OK | X_OK)) != 0 && m_in.mode != F_OK)
return(EINVAL);
2007-08-07 14:52:47 +02:00
if (fetch_name(m_in.name, m_in.name_length, M3) != OK) return(err_code);
2007-08-07 14:52:47 +02:00
/* Request lookup */
r = lookup_vp(0 /*flags*/, TRUE /*use_realuid*/, &vp);
if (r != OK) return r;
2007-08-07 14:52:47 +02:00
r= forbidden(vp, m_in.mode, 1 /*use_realuid*/);
put_vnode(vp);
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* forbidden *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int forbidden(struct vnode *vp, mode_t access_desired, int use_realuid)
{
2007-08-07 14:52:47 +02:00
/* Given a pointer to an inode, 'rip', and the access desired, determine
* if the access is allowed, and if not why not. The routine looks up the
* caller's uid in the 'fproc' table. If access is allowed, OK is returned
* if it is forbidden, EACCES is returned.
*/
2007-08-07 14:52:47 +02:00
register struct super_block *sp;
register mode_t bits, perm_bits;
uid_t uid;
gid_t gid;
int r, shift, type;
2007-08-07 14:52:47 +02:00
if (vp->v_uid == (uid_t)-1 || vp->v_gid == (gid_t)-1)
{
printf("forbidden: bad uid/gid in vnode: inode %d on dev 0x%x\n",
vp->v_inode_nr, vp->v_dev);
printf("forbidden: last allocated at %s, %d\n", vp->v_file, vp->v_line);
return EACCES;
}
2007-08-07 14:52:47 +02:00
/* Isolate the relevant rwx bits from the mode. */
bits = vp->v_mode;
if (use_realuid)
{
uid= fp->fp_realuid;
gid= fp->fp_realgid;
}
else
{
uid= fp->fp_effuid;
gid= fp->fp_effgid;
}
if (uid == SU_UID) {
/* Grant read and write permission. Grant search permission for
* directories. Grant execute permission (for non-directories) if
* and only if one of the 'X' bits is set.
*/
if ( (bits & I_TYPE) == I_DIRECTORY ||
bits & ((X_BIT << 6) | (X_BIT << 3) | X_BIT))
perm_bits = R_BIT | W_BIT | X_BIT;
else
perm_bits = R_BIT | W_BIT;
} else {
if (uid == vp->v_uid) shift = 6; /* owner */
else if (gid == vp->v_gid ) shift = 3; /* group */
else shift = 0; /* other */
perm_bits = (bits >> shift) & (R_BIT | W_BIT | X_BIT);
}
/* If access desired is not a subset of what is allowed, it is refused. */
r = OK;
if ((perm_bits | access_desired) != perm_bits) {
r = EACCES;
}
/* Check to see if someone is trying to write on a file system that is
* mounted read-only.
*/
if (r == OK)
if (access_desired & W_BIT)
r = read_only(vp);
return(r);
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* read_only *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int read_only(vp)
struct vnode *vp; /* ptr to inode whose file sys is to be cked */
{
2007-08-07 14:52:47 +02:00
/* Check to see if the file system on which the inode 'ip' resides is mounted
* read only. If so, return EROFS, else return OK.
*/
register struct vmnt *mp;
2007-08-07 14:52:47 +02:00
mp = vp->v_vmnt;
return(mp->m_flags ? EROFS : OK);
}
2007-08-07 14:52:47 +02:00
/* This file contains the wrapper functions for issueing a request
* and receiving response from FS processes.
* Each function builds a request message according to the request
* parameter, calls the most low-level fs_sendrec and copies
* back the response.
* The low-level fs_sendrec handles the recovery mechanism from
* a dead driver and reissues the request.
*
* Sep 2006 (Balazs Gerofi)
*/
#include "fs.h"
#include <string.h>
#include <sys/stat.h>
#include <sys/statfs.h>
#include <minix/callnr.h>
#include <minix/com.h>
#include <minix/keymap.h>
#include <minix/const.h>
#include <minix/endpoint.h>
#include <minix/u64.h>
#include <unistd.h>
#include <minix/vfsif.h>
#include "fproc.h"
#include "vmnt.h"
#include "vnode.h"
#include "param.h"
FORWARD _PROTOTYPE(int fs_sendrec_f, (char *file, int line, endpoint_t fs_e, message *reqm));
#define fs_sendrec(e, m) fs_sendrec_f(__FILE__, __LINE__, (e), (m))
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_breadwrite *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_breadwrite(fs_e, user_e, dev, pos, num_of_bytes, user_addr,
rw_flag, new_posp, cum_iop)
endpoint_t fs_e;
endpoint_t user_e;
dev_t dev;
u64_t pos;
unsigned int num_of_bytes;
char *user_addr;
int rw_flag;
u64_t *new_posp;
unsigned int *cum_iop;
{
2007-08-07 14:52:47 +02:00
int r;
cp_grant_id_t gid;
message m;
2007-08-07 14:52:47 +02:00
gid= cpf_grant_magic(fs_e, user_e, (vir_bytes)user_addr,
num_of_bytes, (rw_flag == READING ? CPF_WRITE : CPF_READ));
if (gid == -1)
panic(__FILE__, "req_breadwrite: cpf_grant_magic failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = rw_flag == READING ? REQ_BREAD_S : REQ_BWRITE_S;
m.REQ_XFD_BDEV = dev;
m.REQ_XFD_GID = gid;
m.REQ_XFD_POS_LO = ex64lo(pos);
m.REQ_XFD_POS_HI = ex64hi(pos);
m.REQ_XFD_NBYTES = num_of_bytes;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
cpf_revoke(gid);
if (r != OK) return r;
/* Fill in response structure */
*new_posp = make64(m.RES_XFD_POS_LO, m.RES_XFD_POS_HI);
*cum_iop = m.RES_XFD_CUM_IO;
return OK;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_chmod *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_chmod(fs_e, inode_nr, rmode, new_modep)
int fs_e;
ino_t inode_nr;
mode_t rmode;
mode_t *new_modep;
{
message m;
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
int r;
/* Fill in request message */
m.m_type = REQ_CHMOD;
2007-08-07 14:52:47 +02:00
m.REQ_INODE_NR = inode_nr;
m.REQ_MODE = rmode;
m.REQ_UID = fp->fp_effuid;
m.REQ_GID = fp->fp_effgid;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
/* Copy back actual mode. */
2007-08-07 14:52:47 +02:00
if (r == OK)
*new_modep = m.RES_MODE;
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
return r;
}
2007-08-07 14:52:47 +02:00
/* Structure for REQ_CHOWN request */
typedef struct chown_req {
int fs_e;
ino_t inode_nr;
uid_t uid;
gid_t gid;
uid_t newuid;
gid_t newgid;
} chown_req_t;
/*===========================================================================*
* req_chown *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_chown(fs_e, inode_nr, newuid, newgid, new_modep)
endpoint_t fs_e;
ino_t inode_nr;
uid_t newuid;
gid_t newgid;
mode_t *new_modep;
{
message m;
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
int r;
/* Fill in request message */
m.m_type = REQ_CHOWN;
2007-08-07 14:52:47 +02:00
m.REQ_INODE_NR = inode_nr;
m.REQ_UID = fp->fp_effuid;
m.REQ_GID = fp->fp_effgid;
m.REQ_NEW_UID = newuid;
m.REQ_NEW_GID = newgid;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
/* Return new mode to caller. */
2007-08-07 14:52:47 +02:00
*new_modep = m.RES_MODE;
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_create *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
int req_create(fs_e, inode_nr, omode, uid, gid, path, res)
int fs_e;
ino_t inode_nr;
int omode;
uid_t uid;
gid_t gid;
char *path;
node_details_t *res;
{
2007-08-07 14:52:47 +02:00
int r;
cp_grant_id_t grant_id;
size_t len;
message m;
2007-08-07 14:52:47 +02:00
len= strlen(path) + 1;
grant_id= cpf_grant_direct(fs_e, (vir_bytes)path, len, CPF_READ);
if (grant_id == -1)
panic(__FILE__, "req_create: cpf_grant_direct failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_CREATE_S;
m.REQ_INODE_NR = inode_nr;
m.REQ_MODE = omode;
m.REQ_UID = uid;
m.REQ_GID = gid;
m.REQ_GRANT = grant_id;
m.REQ_PATH_LEN = len;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
2007-08-07 14:52:47 +02:00
cpf_revoke(grant_id);
2007-08-07 14:52:47 +02:00
if (r != OK) return r;
2007-08-07 14:52:47 +02:00
/* Fill in response structure */
res->fs_e = m.m_source;
res->inode_nr = m.RES_INODE_NR;
res->fmode = m.RES_MODE;
res->fsize = m.RES_FILE_SIZE;
res->uid = m.RES_UID;
res->gid = m.RES_GID;
res->dev = m.RES_DEV;
res->inode_index = m.RES_INODE_INDEX;
2007-08-07 14:52:47 +02:00
return OK;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_flush *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_flush(fs_e, dev)
endpoint_t fs_e;
dev_t dev;
{
message m;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_FLUSH;
m.REQ_DEV = dev;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
return fs_sendrec(fs_e, &m);
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_fstatfs *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_fstatfs(fs_e, inode_nr, who_e, buf)
2007-01-05 17:36:55 +01:00
int fs_e;
ino_t inode_nr;
int who_e;
char *buf;
{
2007-01-05 17:36:55 +01:00
int r;
2007-08-07 14:52:47 +02:00
cp_grant_id_t gid;
2007-01-05 17:36:55 +01:00
message m;
2007-08-07 14:52:47 +02:00
gid= cpf_grant_magic(fs_e, who_e, (vir_bytes)buf, sizeof(struct statfs),
2007-01-05 17:36:55 +01:00
CPF_WRITE);
if (gid < 0)
return gid;
2007-01-05 17:36:55 +01:00
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_FSTATFS;
2007-01-05 17:36:55 +01:00
m.REQ_INODE_NR = inode_nr;
m.REQ_GRANT = gid;
2007-01-05 17:36:55 +01:00
/* Send/rec request */
r= fs_sendrec(fs_e, &m);
2007-01-05 17:36:55 +01:00
cpf_revoke(gid);
2007-01-05 17:36:55 +01:00
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_ftrunc *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_ftrunc(fs_e, inode_nr, start, end)
endpoint_t fs_e;
2007-01-05 17:36:55 +01:00
ino_t inode_nr;
2007-08-07 14:52:47 +02:00
off_t start;
off_t end;
{
2007-08-07 14:52:47 +02:00
message m;
2007-08-07 14:52:47 +02:00
/* Fill in request message */
m.m_type = REQ_FTRUNC;
m.REQ_FD_INODE_NR = inode_nr;
m.REQ_FD_START = start;
m.REQ_FD_END = end;
2007-08-07 14:52:47 +02:00
/* Send/rec request */
return fs_sendrec(fs_e, &m);
}
2007-01-05 17:36:55 +01:00
2007-08-07 14:52:47 +02:00
/*===========================================================================*
* req_getdents *
*===========================================================================*/
PUBLIC int req_getdents(fs_e, inode_nr, pos, gid, size, pos_change)
endpoint_t fs_e;
ino_t inode_nr;
off_t pos;
cp_grant_id_t gid;
size_t size;
off_t *pos_change;
{
int r;
message m;
2007-01-05 17:36:55 +01:00
2007-08-07 14:52:47 +02:00
m.m_type= REQ_GETDENTS;
m.REQ_GDE_INODE= inode_nr;
m.REQ_GDE_GRANT= gid;
m.REQ_GDE_SIZE= size;
m.REQ_GDE_POS= pos;
r = fs_sendrec(fs_e, &m);
*pos_change= m.RES_GDE_POS_CHANGE;
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_inhibread *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_inhibread(fs_e, inode_nr)
endpoint_t fs_e;
ino_t inode_nr;
{
message m;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_INHIBREAD;
m.REQ_INODE_NR = inode_nr;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
return fs_sendrec(fs_e, &m);
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_link *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_link(fs_e, link_parent, lastc, linked_file)
endpoint_t fs_e;
ino_t link_parent;
char *lastc;
ino_t linked_file;
{
2007-08-07 14:52:47 +02:00
int r;
cp_grant_id_t gid;
size_t len;
message m;
2007-08-07 14:52:47 +02:00
len= strlen(lastc) + 1;
gid= cpf_grant_direct(fs_e, (vir_bytes)lastc, len, CPF_READ);
if (gid == -1)
panic(__FILE__, "req_link: cpf_grant_direct failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_LINK_S;
m.REQ_LINKED_FILE = linked_file;
m.REQ_LINK_PARENT = link_parent;
m.REQ_GRANT = gid;
m.REQ_PATH_LEN = len;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
2007-08-07 14:52:47 +02:00
cpf_revoke(gid);
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_lookup *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_lookup(fs_e, path_off, dir_ino, root_ino, uid, gid, flags, res)
endpoint_t fs_e;
size_t path_off;
ino_t dir_ino;
ino_t root_ino;
uid_t uid;
gid_t gid;
int flags;
lookup_res_t *res;
{
2007-08-07 14:52:47 +02:00
int r;
size_t len;
cp_grant_id_t grant_id;
message m;
2007-08-07 14:52:47 +02:00
#if 0
printf("req_lookup_s: fs %d, ino %d, root %d, string (off %d) '%s'\n",
fs_e, dir_ino, root_ino, path_off, user_fullpath+path_off);
#endif
grant_id= cpf_grant_direct(fs_e, (vir_bytes)user_fullpath,
sizeof(user_fullpath), CPF_READ|CPF_WRITE);
if (grant_id == -1)
panic(__FILE__, "req_lookup_s: cpf_grant_direct failed", NO_NUM);
len= strlen(user_fullpath+path_off) + 1;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_LOOKUP_S;
m.REQ_L_GRANT = grant_id;
m.REQ_L_PATH_LEN = len;
m.REQ_L_PATH_SIZE = sizeof(user_fullpath);
m.REQ_L_PATH_OFF = path_off;
m.REQ_L_DIR_INO = dir_ino;
m.REQ_L_ROOT_INO = root_ino;
m.REQ_L_FLAGS = flags;
m.REQ_L_UID = uid;
m.REQ_L_GID = gid;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
cpf_revoke(grant_id);
/* Fill in response according to the return value */
res->fs_e = m.m_source;
switch (r) {
case OK:
res->inode_nr = m.RES_INODE_NR;
res->fmode = m.RES_MODE;
res->fsize = m.RES_FILE_SIZE;
res->dev = m.RES_DEV;
res->uid= m.RES_UID;
res->gid= m.RES_GID;
break;
case EENTERMOUNT:
res->inode_nr = m.RES_INODE_NR;
res->char_processed = m.RES_OFFSET;
res->symloop = m.RES_SYMLOOP2;
break;
case ELEAVEMOUNT:
res->char_processed = m.RES_OFFSET;
res->symloop = m.RES_SYMLOOP2;
break;
case ESYMLINK:
res->char_processed = m.RES_OFFSET;
res->symloop = m.RES_SYMLOOP2;
break;
default:
break;
}
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_mkdir *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_mkdir(fs_e, inode_nr, lastc, uid, gid, dmode)
endpoint_t fs_e;
ino_t inode_nr;
char *lastc;
uid_t uid;
gid_t gid;
mode_t dmode;
{
2007-08-07 14:52:47 +02:00
int r;
cp_grant_id_t grant_id;
size_t len;
message m;
2007-08-07 14:52:47 +02:00
len= strlen(lastc) + 1;
grant_id= cpf_grant_direct(fs_e, (vir_bytes)lastc, len, CPF_READ);
if (gid == -1)
panic(__FILE__, "req_mkdir: cpf_grant_direct failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_MKDIR_S;
m.REQ_INODE_NR = inode_nr;
m.REQ_MODE = dmode;
m.REQ_UID = uid;
m.REQ_GID = gid;
m.REQ_GRANT = grant_id;
m.REQ_PATH_LEN = len;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
cpf_revoke(grant_id);
return r;
}
2007-08-07 14:52:47 +02:00
/* Structure for REQ_MKNOD request */
typedef struct mknod_req {
int fs_e;
ino_t inode_nr;
uid_t uid;
gid_t gid;
mode_t rmode;
dev_t dev;
char *lastc;
} mknod_req_t;
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_newnode *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_newnode(fs_e, uid, gid, dmode, dev, res)
endpoint_t fs_e;
uid_t uid;
gid_t gid;
mode_t dmode;
dev_t dev;
struct node_details *res;
{
2007-08-07 14:52:47 +02:00
int r;
message m;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_NEWNODE;
m.REQ_MODE = dmode;
m.REQ_DEVx = dev;
m.REQ_UID = uid;
m.REQ_GID = gid;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
res->fs_e = m.m_source;
res->inode_nr = m.RES_INODE_NR;
res->fmode = m.RES_MODE;
res->fsize = m.RES_FILE_SIZE;
res->dev = m.RES_DEV;
res->uid= m.RES_UID;
res->gid= m.RES_GID;
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_mountpoint *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_mountpoint(fs_e, inode_nr)
endpoint_t fs_e;
ino_t inode_nr;
{
2007-08-07 14:52:47 +02:00
int r;
message m;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_MOUNTPOINT_S;
m.REQ_INODE_NR = inode_nr;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
return fs_sendrec(fs_e, &m);
}
2007-08-07 14:52:47 +02:00
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_mknod *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_mknod(fs_e, inode_nr, lastc, uid, gid, dmode, dev)
endpoint_t fs_e;
ino_t inode_nr;
char *lastc;
uid_t uid;
gid_t gid;
mode_t dmode;
dev_t dev;
{
2007-08-07 14:52:47 +02:00
int r;
size_t len;
cp_grant_id_t grant_id;
message m;
2007-08-07 14:52:47 +02:00
len= strlen(lastc) + 1;
grant_id= cpf_grant_direct(fs_e, (vir_bytes)lastc, len, CPF_READ);
if (gid == -1)
panic(__FILE__, "req_mknod: cpf_grant_direct failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_MKNOD_S;
m.REQ_INODE_NR = inode_nr;
m.REQ_MODE = dmode;
m.REQ_DEVx = dev;
m.REQ_UID = uid;
m.REQ_GID = gid;
m.REQ_GRANT = grant_id;
m.REQ_PATH_LEN = len;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
cpf_revoke(grant_id);
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_putnode *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_putnode(fs_e, inode_nr, count)
int fs_e;
ino_t inode_nr;
int count;
{
message m;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_PUTNODE;
m.REQ_INODE_NR = inode_nr;
m.REQ_COUNT = count;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
return fs_sendrec(fs_e, &m);
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_rdlink *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_rdlink(fs_e, inode_nr, who_e, buf, len)
endpoint_t fs_e;
ino_t inode_nr;
endpoint_t who_e;
vir_bytes buf;
size_t len;
{
message m;
2007-08-07 14:52:47 +02:00
int r;
cp_grant_id_t gid;
gid= cpf_grant_magic(fs_e, who_e, buf, len, CPF_WRITE);
if (gid == -1)
panic(__FILE__, "req_rdlink: cpf_grant_magic failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_RDLINK_S;
m.REQ_INODE_NR = inode_nr;
m.REQ_GRANT = gid;
m.REQ_SLENGTH = len;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r= fs_sendrec(fs_e, &m);
cpf_revoke(gid);
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_readsuper *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_readsuper(fs_e, label, dev, readonly, isroot, res_nodep)
endpoint_t fs_e;
char *label;
dev_t dev;
int readonly;
int isroot;
struct node_details *res_nodep;
{
int r;
2007-08-07 14:52:47 +02:00
cp_grant_id_t gid;
size_t len;
message m;
2007-08-07 14:52:47 +02:00
len= strlen(label)+1;
gid= cpf_grant_direct(fs_e, (vir_bytes)label, len, CPF_READ);
if (gid == -1)
panic(__FILE__, "req_req_readsuper: cpf_grant_direct failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_READSUPER_S;
m.REQ_READONLY = readonly;
m.REQ_GRANT2 = gid;
m.REQ_DEV = dev;
m.REQ_ISROOT = isroot;
m.REQ_PATH_LEN = len;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
if ((r = fs_sendrec(fs_e, &m)) != OK) return r;
/* Fill in response structure */
2007-08-07 14:52:47 +02:00
res_nodep->fs_e = m.m_source;
res_nodep->inode_nr = m.RES_INODE_NR;
res_nodep->fmode = m.RES_MODE;
res_nodep->fsize = m.RES_FILE_SIZE;
res_nodep->uid = m.RES_UID;
res_nodep->gid = m.RES_GID;
return OK;
}
2007-08-07 14:52:47 +02:00
/* Structure for REQ_READ and REQ_WRITE request */
typedef struct readwrite_req {
int rw_flag;
endpoint_t fs_e;
endpoint_t user_e;
ino_t inode_nr;
unsigned short inode_index;
int seg;
u64_t pos;
unsigned int num_of_bytes;
char *user_addr;
} readwrite_req_t;
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_readwrite *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_readwrite(fs_e, inode_nr, inode_index, pos, rw_flag, user_e,
user_addr, num_of_bytes, new_posp, cum_iop)
endpoint_t fs_e;
ino_t inode_nr;
unsigned short inode_index;
u64_t pos;
int rw_flag;
endpoint_t user_e;
char *user_addr;
unsigned int num_of_bytes;
u64_t *new_posp;
unsigned int *cum_iop;
{
int r;
2007-08-07 14:52:47 +02:00
cp_grant_id_t gid;
message m;
2007-08-07 14:52:47 +02:00
if (ex64hi(pos) != 0)
panic(__FILE__, "req_readwrite: pos too large", NO_NUM);
gid= cpf_grant_magic(fs_e, user_e, (vir_bytes)user_addr,
num_of_bytes, (rw_flag == READING ? CPF_WRITE : CPF_READ));
if (gid == -1)
panic(__FILE__, "req_readwrite: cpf_grant_magic failed", NO_NUM);
2007-08-07 14:52:47 +02:00
/* Fill in request message */
m.m_type = rw_flag == READING ? REQ_READ_S : REQ_WRITE_S;
m.REQ_FD_INODE_NR = inode_nr;
m.REQ_FD_GID = gid;
m.REQ_FD_POS = ex64lo(pos);
m.REQ_FD_NBYTES = num_of_bytes;
m.REQ_FD_INODE_INDEX = inode_index;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
cpf_revoke(gid);
if (r != OK) return r;
/* Fill in response structure */
2007-08-07 14:52:47 +02:00
*new_posp = cvul64(m.RES_FD_POS);
*cum_iop = m.RES_FD_CUM_IO;
return OK;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_rename *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_rename(fs_e, old_dir, old_name, new_dir, new_name)
endpoint_t fs_e;
ino_t old_dir;
char *old_name;
ino_t new_dir;
char *new_name;
{
2007-08-07 14:52:47 +02:00
int r;
cp_grant_id_t gid_old, gid_new;
size_t len_old, len_new;
message m;
2007-08-07 14:52:47 +02:00
len_old= strlen(old_name) + 1;
gid_old= cpf_grant_direct(fs_e, (vir_bytes)old_name, len_old,
CPF_READ);
if (gid_old == -1)
panic(__FILE__, "req_rename: cpf_grant_direct failed", NO_NUM);
len_new= strlen(new_name) + 1;
gid_new= cpf_grant_direct(fs_e, (vir_bytes)new_name, len_new,
CPF_READ);
if (gid_new == -1)
panic(__FILE__, "req_rename: cpf_grant_direct failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_RENAME_S;
m.REQ_REN_OLD_DIR = old_dir;
m.REQ_REN_NEW_DIR = new_dir;
m.REQ_REN_GRANT_OLD = gid_old;
m.REQ_REN_LEN_OLD = len_old;
m.REQ_REN_GRANT_NEW = gid_new;
m.REQ_REN_LEN_NEW = len_new;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
cpf_revoke(gid_old);
cpf_revoke(gid_new);
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_rmdir *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_rmdir(fs_e, inode_nr, lastc)
endpoint_t fs_e;
ino_t inode_nr;
char *lastc;
{
2007-08-07 14:52:47 +02:00
int r;
cp_grant_id_t gid;
size_t len;
message m;
2007-08-07 14:52:47 +02:00
len= strlen(lastc) + 1;
gid= cpf_grant_direct(fs_e, (vir_bytes)lastc, len, CPF_READ);
if (gid == -1)
panic(__FILE__, "req_rmdir: cpf_grant_direct failed", NO_NUM);
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_RMDIR_S;
m.REQ_INODE_NR = inode_nr;
m.REQ_GRANT = gid;
m.REQ_PATH_LEN = len;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
r = fs_sendrec(fs_e, &m);
2007-08-07 14:52:47 +02:00
cpf_revoke(gid);
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_slink *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_slink(fs_e, inode_nr, lastc, who_e, path_addr, path_length,
uid, gid)
endpoint_t fs_e;
2007-08-07 14:52:47 +02:00
ino_t inode_nr;
char *lastc;
endpoint_t who_e;
char *path_addr;
unsigned short path_length;
uid_t uid;
gid_t gid;
{
int r;
2007-08-07 14:52:47 +02:00
size_t len;
cp_grant_id_t gid_name, gid_buf;
message m;
len= strlen(lastc) + 1;
gid_name= cpf_grant_direct(fs_e, (vir_bytes)lastc, len,
CPF_READ);
if (gid_name == -1)
panic(__FILE__, "req_slink: cpf_grant_direct failed", NO_NUM);
gid_buf= cpf_grant_magic(fs_e, who_e, (vir_bytes)path_addr,
path_length, CPF_READ);
if (gid_buf == -1)
{
cpf_revoke(gid_buf);
panic(__FILE__, "req_slink: cpf_grant_magic failed", NO_NUM);
}
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_SLINK_S;
m.REQ_INODE_NR = inode_nr;
m.REQ_UID = uid;
m.REQ_GID = gid;
m.REQ_GRANT = gid_name;
m.REQ_PATH_LEN = len;
m.REQ_GRANT2 = gid_buf;
m.REQ_SLENGTH = path_length;
2007-08-07 14:52:47 +02:00
/* Send/rec request */
r = fs_sendrec(fs_e, &m);
2007-08-07 14:52:47 +02:00
cpf_revoke(gid_name);
cpf_revoke(gid_buf);
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_stat *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_stat(fs_e, inode_nr, who_e, buf, pos)
int fs_e;
ino_t inode_nr;
int who_e;
char *buf;
int pos;
{
2007-08-07 14:52:47 +02:00
cp_grant_id_t gid;
int r;
message m;
struct stat sb;
2007-08-07 14:52:47 +02:00
if (pos != 0)
{
gid= cpf_grant_direct(fs_e, (vir_bytes)&sb, sizeof(struct stat),
CPF_WRITE);
}
else
{
gid= cpf_grant_magic(fs_e, who_e, (vir_bytes)buf, sizeof(struct stat),
CPF_WRITE);
}
if (gid < 0)
return gid;
2007-08-07 14:52:47 +02:00
/* Fill in request message */
m.m_type = REQ_STAT;
m.REQ_INODE_NR = inode_nr;
m.REQ_GRANT = gid;
2007-08-07 14:52:47 +02:00
/* Send/rec request */
r= fs_sendrec(fs_e, &m);
2007-08-07 14:52:47 +02:00
cpf_revoke(gid);
if (r == OK && pos != 0)
{
sb.st_size -= pos;
r= sys_vircopy(SELF, D, (vir_bytes)&sb, who_e, D, (vir_bytes)buf,
sizeof(struct stat));
}
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_sync *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_sync(fs_e)
endpoint_t fs_e;
{
message m;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_SYNC;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
return fs_sendrec(fs_e, &m);
}
2007-08-07 14:52:47 +02:00
/* Structure for REQ_UNLINK request */
typedef struct unlink_req {
int fs_e;
ino_t d_inode_nr;
uid_t uid;
gid_t gid;
char *lastc;
} unlink_req_t;
2007-08-07 14:52:47 +02:00
/*===========================================================================*
* req_unlink *
*===========================================================================*/
PUBLIC int req_unlink(fs_e, inode_nr, lastc)
endpoint_t fs_e;
ino_t inode_nr;
2007-08-07 14:52:47 +02:00
char *lastc;
{
2007-08-07 14:52:47 +02:00
cp_grant_id_t gid;
size_t len;
int r;
message m;
2007-08-07 14:52:47 +02:00
len= strlen(lastc) + 1;
gid= cpf_grant_direct(fs_e, (vir_bytes)lastc, len, CPF_READ);
if (gid == -1)
panic(__FILE__, "req_unlink: cpf_grant_direct failed", NO_NUM);
2007-08-07 14:52:47 +02:00
/* Fill in request message */
m.m_type = REQ_UNLINK_S;
m.REQ_INODE_NR = inode_nr;
m.REQ_GRANT = gid;
m.REQ_PATH_LEN = len;
/* Send/rec request */
r = fs_sendrec(fs_e, &m);
cpf_revoke(gid);
return r;
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_unmount *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_unmount(fs_e)
endpoint_t fs_e;
{
message m;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_UNMOUNT;
/* Send/rec request */
return fs_sendrec(fs_e, &m);
}
/*===========================================================================*
2007-08-07 14:52:47 +02:00
* req_utime *
*===========================================================================*/
2007-08-07 14:52:47 +02:00
PUBLIC int req_utime(fs_e, inode_nr, actime, modtime)
endpoint_t fs_e;
ino_t inode_nr;
time_t actime;
time_t modtime;
{
message m;
/* Fill in request message */
2007-08-07 14:52:47 +02:00
m.m_type = REQ_UTIME;
m.REQ_INODE_NR = inode_nr;
m.REQ_ACTIME = actime;
m.REQ_MODTIME = modtime;
/* Send/rec request */
2007-08-07 14:52:47 +02:00
return fs_sendrec(fs_e, &m);
}
/*===========================================================================*
* req_newdriver *
*===========================================================================*/
PUBLIC int req_newdriver(fs_e, dev, driver_e)
endpoint_t fs_e;
Dev_t dev;
endpoint_t driver_e;
{
/* Note: this is the only request function that doesn't use the
* fs_sendrec internal routine, since we want to avoid the dead
* driver recovery mechanism here. This function is actually called
* during the recovery.
*/
message m;
int r;
/* Fill in request message */
m.m_type = REQ_NEW_DRIVER;
m.REQ_DEV = dev;
m.REQ_DRIVER_E = driver_e;
2007-08-07 14:52:47 +02:00
/* Issue request */
if ((r = sendrec(fs_e, &m)) != OK) {
printf("VFSreq_newdriver: error sending message to %d: %d\n", fs_e, r);
return r;
}
return OK;
}
2007-08-07 14:52:47 +02:00
/*===========================================================================*
* fs_sendrec *
*===========================================================================*/
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
PRIVATE int fs_sendrec_f(char *file, int line, endpoint_t fs_e, message *reqm)
{
/* This is the low level function that sends requests to FS processes.
* It also handles driver recovery mechanism and reissuing the
* request which failed due to a dead driver.
*/
int r, old_driver_e, new_driver_e;
message origm, m;
struct vmnt *vmp;
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
2007-08-07 14:52:47 +02:00
if (fs_e == PM_PROC_NR)
{
printf("from %s, %d\n", file, line);
panic(__FILE__, "talking to PM", NO_NUM);
}
/* Make a copy of the request so that we can load it back in
* case of a dead driver */
origm = *reqm;
for (;;) {
/* Do the actual send, receive */
if (OK != (r=sendrec(fs_e, reqm))) {
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
printf("VFS:fs_sendrec:%s:%d: error sending message. FS_e: %d req_nr: %d err: %d\n",
file, line, fs_e, reqm->m_type, r);
}
if(r == OK) {
/* Sendrec was okay */
break;
}
/* Dead driver */
if (r == EDEADSRCDST || r == EDSTDIED || r == ESRCDIED) {
old_driver_e = NONE;
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
/* Find old driver by endpoint */
for (vmp = &vmnt[0]; vmp < &vmnt[NR_MNTS]; ++vmp) {
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
if (vmp->m_fs_e == fs_e) { /* found FS */
old_driver_e = vmp->m_driver_e;
dmap_unmap_by_endpt(old_driver_e); /* unmap driver */
break;
}
}
/* No FS ?? */
Mostly bugfixes of bugs triggered by the test set. bugfixes: SYSTEM: . removed rc->p_priv->s_flags = 0; for the priv struct shared by all user processes in get_priv(). this should only be done once. doing a SYS_PRIV_USER in sys_privctl() caused the flags of all user processes to be reset, so they were no longer PREEMPTIBLE. this happened when RS executed a policy script. (this broke test1 in the test set) VFS/MFS: . chown can change the mode of a file, and chmod arguments are only part of the full file mode so the full filemode is slightly magic. changed these calls so that the final modes are returned to VFS, so that the vnode can be kept up-to-date. (this broke test11 in the test set) MFS: . lookup() checked for sizeof(string) instead of sizeof(user_path), truncating long path names (caught by test 23) . truncate functions neglected to update ctime (this broke test16) VFS: . corner case of an empty filename lookup caused fields of a request not to be filled in in the lookup functions, not making it clear that the lookup had failed, causing messages to garbage processes, causing strange failures. (caught by test 30) . trust v_size in vnode when doing reads or writes on non-special files, truncating i/o where necessary; this is necessary for pipes, as MFS can't tell when a pipe has been truncated without it being told explicitly each time. when the last reader/writer on a pipe closes, tell FS about the new size using truncate_vn(). (this broke test 25, among others) . permission check for chdir() had disappeared; added a forbidden() call (caught by test 23) new code, shouldn't change anything: . introduced RTS_SET, RTS_UNSET, and RTS_ISSET macro's, and their LOCK variants. These macros set and clear the p_rts_flags field, causing a lot of duplicated logic like old_flags = rp->p_rts_flags; /* save value of the flags */ rp->p_rts_flags &= ~NO_PRIV; if (old_flags != 0 && rp->p_rts_flags == 0) lock_enqueue(rp); to change into the simpler RTS_LOCK_UNSET(rp, NO_PRIV); so the macros take care of calling dequeue() and enqueue() (or lock_*()), as the case may be). This makes the code a bit more readable and a bit less fragile. . removed return code from do_clocktick in CLOCK as it currently never replies . removed some debug code from VFS . fixed grant debug message in device.c preemptive checks, tests, changes: . added return code checks of receive() to SYSTEM and CLOCK . O_TRUNC should never arrive at MFS (added sanity check and removed O_TRUNC code) . user_path declared with PATH_MAX+1 to let it be null-terminated . checks in MFS to see if strings passed by VFS are null-terminated IS: . static irq name table thrown out
2007-02-01 18:50:02 +01:00
if (old_driver_e == NONE)
panic(__FILE__, "VFSdead_driver: couldn't find FS\n", fs_e);
/* Wait for a new driver. */
for (;;) {
new_driver_e = 0;
printf("VFSdead_driver: waiting for new driver\n");
r = receive(RS_PROC_NR, &m);
if (r != OK) {
panic(__FILE__, "VFSdead_driver: unable to receive from RS",
r);
}
if (m.m_type == DEVCTL) {
/* Map new driver */
r = fs_devctl(m.ctl_req, m.dev_nr, m.driver_nr,
m.dev_style, m.m_force);
if (m.ctl_req == DEV_MAP && r == OK) {
new_driver_e = m.driver_nr;
printf("VFSdead_driver: new driver endpoint: %d\n",
new_driver_e);
}
}
else {
panic(__FILE__, "VFSdead_driver: got message from RS, type",
m.m_type);
}
m.m_type = r;
if ((r = send(RS_PROC_NR, &m)) != OK) {
panic(__FILE__, "VFSdead_driver: unable to send to RS",
r);
}
/* New driver is ready */
if (new_driver_e) break;
}
/* Copy back original request */
*reqm = origm;
continue;
}
printf("fs_sendrec: unhandled error %d sending to %d\n", r, fs_e);
panic(__FILE__, "fs_sendrec: unhandled error", NO_NUM);
}
/* Return message type */
return reqm->m_type;
}