sanchayanmaity/minix
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
minix/kernel/system/do_setgrant.c

31 lines
759 B
C
Raw Normal View History

Rename paramctl to setgrant.
2006-06-23 17:35:05 +02:00
/* The kernel call implemented in this file:
* m_type: SYS_SETGRANT
*
* The parameters for this kernel call are:
* SG_ADDR address of grant table in own address space
* SG_SIZE number of entries
*/
#include "../system.h"
#include <minix/safecopies.h>
/*===========================================================================*
* do_setgrant *
*===========================================================================*/
This patch removes the global variables who_p and who_e from the kernel (sys task). The main reason is that these would have to become cpu local variables on SMP. Once the system task is not a task but a genuine part of the kernel there is even less reason to have these extra variables as proc_ptr will already contain all neccessary information. In addition converting who_e to the process pointer and back again all the time will be avoided. Although proc_ptr will contain all important information, accessing it as a cpu local variable will be fairly expensive, hence the value would be assigned to some on stack local variable. Therefore it is better to add the 'caller' argument to the syscall handlers to pass the value on stack anyway. It also clearly denotes on who's behalf is the syscall being executed. This patch also ANSIfies the syscall function headers. Last but not least, it also fixes a potential bug in virtual_copy_f() in case the check is disabled. So far the function in case of a failure could possible reuse an old who_p in case this function had not been called from the system task. virtual_copy_f() takes the caller as a parameter too. In case the checking is disabled, the caller must be NULL and non NULL if it is enabled as we must be able to suspend the caller.
2010-02-03 10:04:48 +01:00
PUBLIC int do_setgrant(struct proc * caller, message * m_ptr)
Rename paramctl to setgrant.
2006-06-23 17:35:05 +02:00
{
int r;
/* Copy grant table set in priv. struct. */
This patch removes the global variables who_p and who_e from the kernel (sys task). The main reason is that these would have to become cpu local variables on SMP. Once the system task is not a task but a genuine part of the kernel there is even less reason to have these extra variables as proc_ptr will already contain all neccessary information. In addition converting who_e to the process pointer and back again all the time will be avoided. Although proc_ptr will contain all important information, accessing it as a cpu local variable will be fairly expensive, hence the value would be assigned to some on stack local variable. Therefore it is better to add the 'caller' argument to the syscall handlers to pass the value on stack anyway. It also clearly denotes on who's behalf is the syscall being executed. This patch also ANSIfies the syscall function headers. Last but not least, it also fixes a potential bug in virtual_copy_f() in case the check is disabled. So far the function in case of a failure could possible reuse an old who_p in case this function had not been called from the system task. virtual_copy_f() takes the caller as a parameter too. In case the checking is disabled, the caller must be NULL and non NULL if it is enabled as we must be able to suspend the caller.
2010-02-03 10:04:48 +01:00
if (RTS_ISSET(caller, RTS_NO_PRIV) || !(priv(caller))) {
Rename paramctl to setgrant.
2006-06-23 17:35:05 +02:00
r = EPERM;
} else {
This patch removes the global variables who_p and who_e from the kernel (sys task). The main reason is that these would have to become cpu local variables on SMP. Once the system task is not a task but a genuine part of the kernel there is even less reason to have these extra variables as proc_ptr will already contain all neccessary information. In addition converting who_e to the process pointer and back again all the time will be avoided. Although proc_ptr will contain all important information, accessing it as a cpu local variable will be fairly expensive, hence the value would be assigned to some on stack local variable. Therefore it is better to add the 'caller' argument to the syscall handlers to pass the value on stack anyway. It also clearly denotes on who's behalf is the syscall being executed. This patch also ANSIfies the syscall function headers. Last but not least, it also fixes a potential bug in virtual_copy_f() in case the check is disabled. So far the function in case of a failure could possible reuse an old who_p in case this function had not been called from the system task. virtual_copy_f() takes the caller as a parameter too. In case the checking is disabled, the caller must be NULL and non NULL if it is enabled as we must be able to suspend the caller.
2010-02-03 10:04:48 +01:00
_K_SET_GRANT_TABLE(caller,
Rename paramctl to setgrant.
2006-06-23 17:35:05 +02:00
(vir_bytes) m_ptr->SG_ADDR,
m_ptr->SG_SIZE);
r = OK;
}
return r;
}
Reference in a new issue Copy permalink