d765dbf22c
Currently, the wire format of register values in g- and G-packets is modelled using a union of uint8/16/32/64 arrays. The offset positions of each register are expressed as a "register count" scaled according to the width of the register in question. This results in counter- intuitive and error-prone "register count arithmetic", and some formats would even be altogether unrepresentable in such model, e.g. a 64-bit register following a 32-bit one would have a fractional index in the regs64 array. Another difficulty is that the array is allocated before the actual architecture of the workload is known (and therefore before the correct size for the array can be calculated). With this patch I propose a simpler mechanism for expressing the register set structure. In the new code, GdbRegCache is an abstract class; its subclasses contain straightforward structs reflecting the register representation. The determination whether to use e.g. the AArch32 vs. AArch64 register set (or SPARCv8 vs SPARCv9, etc.) is made by polymorphically dispatching getregs() to the concrete subclass. The subclass is not instantiated until it is needed for actual g-/G-packet processing, when the mode is already known. This patch is not meant to be merged in on its own, because it changes the contract between src/base/remote_gdb.* and src/arch/*/remote_gdb.*, so as it stands right now, it would break the other architectures. In this patch only the base and the ARM code are provided for review; once we agree on the structure, I will provide src/arch/*/remote_gdb.* for the other architectures; those patches could then be merged in together. Review Request: http://reviews.gem5.org/r/3207/ Pushed by Joel Hestness <jthestness@gmail.com>
111 lines
3.9 KiB
C++
111 lines
3.9 KiB
C++
/*
|
|
* Copyright 2015 LabWare
|
|
* Copyright 2014 Google, Inc.
|
|
* Copyright (c) 2013 ARM Limited
|
|
* All rights reserved
|
|
*
|
|
* The license below extends only to copyright in the software and shall
|
|
* not be construed as granting a license to any other intellectual
|
|
* property including but not limited to intellectual property relating
|
|
* to a hardware implementation of the functionality of the software
|
|
* licensed hereunder. You may use the software subject to the license
|
|
* terms below provided that you ensure that this notice is replicated
|
|
* unmodified and in its entirety in all distributions of the software,
|
|
* modified or unmodified, in source code or in binary form.
|
|
*
|
|
* Copyright (c) 2002-2005 The Regents of The University of Michigan
|
|
* Copyright (c) 2007-2008 The Florida State University
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are
|
|
* met: redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer;
|
|
* redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution;
|
|
* neither the name of the copyright holders nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
* Authors: Nathan Binkert
|
|
* Stephen Hines
|
|
* Boris Shingarov
|
|
*/
|
|
|
|
#ifndef __ARCH_ARM_REMOTE_GDB_HH__
|
|
#define __ARCH_ARM_REMOTE_GDB_HH__
|
|
|
|
#include <algorithm>
|
|
|
|
#include "arch/arm/utility.hh"
|
|
#include "base/remote_gdb.hh"
|
|
|
|
class System;
|
|
class ThreadContext;
|
|
|
|
namespace ArmISA
|
|
{
|
|
|
|
class RemoteGDB : public BaseRemoteGDB
|
|
{
|
|
protected:
|
|
bool acc(Addr addr, size_t len);
|
|
|
|
class AArch32GdbRegCache : public BaseGdbRegCache
|
|
{
|
|
using BaseGdbRegCache::BaseGdbRegCache;
|
|
private:
|
|
struct {
|
|
uint32_t gpr[16];
|
|
uint32_t fpr[8*3];
|
|
uint32_t fpscr;
|
|
uint32_t cpsr;
|
|
} r;
|
|
public:
|
|
char *data() const { return (char *)&r; }
|
|
size_t size() const { return sizeof(r); }
|
|
void getRegs(ThreadContext*);
|
|
void setRegs(ThreadContext*) const;
|
|
const std::string name() const { return gdb->name() + ".AArch32GdbRegCache"; }
|
|
};
|
|
|
|
class AArch64GdbRegCache : public BaseGdbRegCache
|
|
{
|
|
using BaseGdbRegCache::BaseGdbRegCache;
|
|
private:
|
|
struct {
|
|
uint64_t x[31];
|
|
uint64_t spx;
|
|
uint64_t pc;
|
|
uint64_t cpsr;
|
|
uint32_t v[32*4];
|
|
} r;
|
|
public:
|
|
char *data() const { return (char *)&r; }
|
|
size_t size() const { return sizeof(r); }
|
|
void getRegs(ThreadContext*);
|
|
void setRegs(ThreadContext*) const;
|
|
const std::string name() const { return gdb->name() + ".AArch64GdbRegCache"; }
|
|
};
|
|
|
|
public:
|
|
RemoteGDB(System *_system, ThreadContext *tc);
|
|
BaseGdbRegCache *gdbRegs();
|
|
};
|
|
} // namespace ArmISA
|
|
|
|
#endif /* __ARCH_ARM_REMOTE_GDB_H__ */
|