gem5/src/base/pollevent.cc
Andreas Sandberg c033ead992 base: Fix race in PollQueue and remove SIGALRM workaround
There is a race between enabling asynchronous IO for a file descriptor
and IO events happening on that descriptor. A SIGIO won't normally be
delivered if an event is pending when asynchronous IO is
enabled. Instead, the signal will be raised the next time there is an
event on the FD. This changeset simulates a SIGIO by setting the
async_io flag when setting up asynchronous IO for an FD. This causes
the main event loop to poll all file descriptors to check for pending
IO. As a consequence of this, the old SIGALRM hack should no longer be
needed and is therefore removed.
2013-11-29 14:36:10 +01:00

228 lines
5.3 KiB
C++

/*
* Copyright (c) 2002-2005 The Regents of The University of Michigan
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are
* met: redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer;
* redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution;
* neither the name of the copyright holders nor the names of its
* contributors may be used to endorse or promote products derived from
* this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*
* Authors: Nathan Binkert
*/
#include <sys/ioctl.h>
#include <sys/types.h>
#if defined(__sun__) || defined(__SUNPRO_CC)
#include <sys/file.h>
#endif
#include <fcntl.h>
#include <unistd.h>
#include <csignal>
#include "base/misc.hh"
#include "base/pollevent.hh"
#include "base/types.hh"
#include "sim/async.hh"
#include "sim/core.hh"
#include "sim/serialize.hh"
using namespace std;
PollQueue pollQueue;
/////////////////////////////////////////////////////
//
PollEvent::PollEvent(int _fd, int _events)
: queue(NULL), enabled(true)
{
pfd.fd = _fd;
pfd.events = _events;
}
PollEvent::~PollEvent()
{
if (queue)
queue->remove(this);
}
void
PollEvent::disable()
{
if (!enabled) return;
enabled = false;
if (queue)
queue->copy();
}
void
PollEvent::enable()
{
if (enabled) return;
enabled = true;
if (queue)
queue->copy();
}
void
PollEvent::serialize(ostream &os)
{
SERIALIZE_SCALAR(pfd.fd);
SERIALIZE_SCALAR(pfd.events);
SERIALIZE_SCALAR(enabled);
}
void
PollEvent::unserialize(Checkpoint *cp, const std::string &section)
{
UNSERIALIZE_SCALAR(pfd.fd);
UNSERIALIZE_SCALAR(pfd.events);
UNSERIALIZE_SCALAR(enabled);
}
/////////////////////////////////////////////////////
//
PollQueue::PollQueue()
: poll_fds(NULL), max_size(0), num_fds(0)
{ }
PollQueue::~PollQueue()
{
for (int i = 0; i < num_fds; i++)
setupAsyncIO(poll_fds[0].fd, false);
delete [] poll_fds;
}
void
PollQueue::copy()
{
eventvec_t::iterator i = events.begin();
eventvec_t::iterator end = events.end();
num_fds = 0;
while (i < end) {
if ((*i)->enabled)
poll_fds[num_fds++] = (*i)->pfd;
++i;
}
}
void
PollQueue::remove(PollEvent *event)
{
eventvec_t::iterator i = events.begin();
eventvec_t::iterator end = events.end();
while (i < end) {
if (*i == event) {
events.erase(i);
copy();
event->queue = NULL;
return;
}
++i;
}
panic("Event does not exist. Cannot remove.");
}
void
PollQueue::schedule(PollEvent *event)
{
if (event->queue)
panic("Event already scheduled!");
event->queue = this;
events.push_back(event);
setupAsyncIO(event->pfd.fd, true);
// if we ran out of space in the fd array, double the capacity
// if this is the first time that we've scheduled an event, create
// the array with an initial size of 16
if (++num_fds > max_size) {
if (max_size > 0) {
delete [] poll_fds;
max_size *= 2;
} else {
max_size = 16;
}
poll_fds = new pollfd[max_size];
}
copy();
}
void
PollQueue::service()
{
int ret = poll(poll_fds, num_fds, 0);
if (ret <= 0)
return;
for (int i = 0; i < num_fds; i++) {
int revents = poll_fds[i].revents;
if (revents) {
events[i]->process(revents);
if (--ret <= 0)
break;
}
}
}
void
PollQueue::setupAsyncIO(int fd, bool set)
{
int flags = fcntl(fd, F_GETFL);
if (flags == -1)
panic("Could not set up async IO");
if (set)
flags |= FASYNC;
else
flags &= ~(FASYNC);
if (set) {
if (fcntl(fd, F_SETOWN, getpid()) == -1)
panic("Could not set up async IO");
}
if (fcntl(fd, F_SETFL, flags) == -1)
panic("Could not set up async IO");
// The file descriptor might already have events pending. We won't
// see them if they occurred before we set the FASYNC
// flag. Simulate a SIGIO to ensure that the FD will be polled in
// next iteration of the simulation loop. We could just poll it,
// but this is much simpler.
if (set) {
async_event = true;
async_io = true;
}
}