21aa5734a0
The Ruby banked array resource checks (initiated from SLICC) did a check and allocate at the same time. If a transition needs more than one resource, then it might check/allocate resource #1, then fail to get resource #2. Another transition might then try to get the same resources, but in reverse order. Deadlock. This patch separates resource checking and resource reservation into two steps to avoid deadlock.
79 lines
2.7 KiB
C++
79 lines
2.7 KiB
C++
/*
|
|
* Copyright (c) 2012 Advanced Micro Devices, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are
|
|
* met: redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer;
|
|
* redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution;
|
|
* neither the name of the copyright holders nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
* Author: Brad Beckmann
|
|
*
|
|
*/
|
|
|
|
#ifndef __MEM_RUBY_STRUCTURES_BANKEDARRAY_HH__
|
|
#define __MEM_RUBY_STRUCTURES_BANKEDARRAY_HH__
|
|
|
|
#include <vector>
|
|
|
|
#include "mem/ruby/common/TypeDefines.hh"
|
|
#include "mem/ruby/system/System.hh"
|
|
#include "sim/core.hh"
|
|
|
|
class BankedArray
|
|
{
|
|
private:
|
|
unsigned int banks;
|
|
Cycles accessLatency;
|
|
unsigned int bankBits;
|
|
unsigned int startIndexBit;
|
|
RubySystem *m_ruby_system;
|
|
|
|
class AccessRecord
|
|
{
|
|
public:
|
|
AccessRecord() : idx(0), startAccess(0), endAccess(0) {}
|
|
int64 idx;
|
|
Tick startAccess;
|
|
Tick endAccess;
|
|
};
|
|
|
|
// If the tick event is scheduled then the bank is busy
|
|
// otherwise, schedule the event and wait for it to complete
|
|
std::vector<AccessRecord> busyBanks;
|
|
|
|
unsigned int mapIndexToBank(int64 idx);
|
|
|
|
public:
|
|
BankedArray(unsigned int banks, Cycles accessLatency,
|
|
unsigned int startIndexBit, RubySystem *rs);
|
|
|
|
// Note: We try the access based on the cache index, not the address
|
|
// This is so we don't get aliasing on blocks being replaced
|
|
bool tryAccess(int64 idx);
|
|
|
|
void reserve(int64 idx);
|
|
|
|
Cycles getLatency() const { return accessLatency; }
|
|
};
|
|
|
|
#endif
|