sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

bus.cc:

Browse source 
Fix atomic timing issue.

src/mem/bus.cc:
    Fix atomic timing issue.

--HG--
extra : convert_revision : a22ff80cd75f83c785b0604c2a4fde2e2e9f71ef
This commit is contained in:
Steve Reinhardt 2007-07-02 01:02:35 -07:00
parent 3ad761bc8e
commit ffd697e149
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/mem/bus.cc
View file

@ -377,7 +377,8 @@ Bus::recvAtomic(PacketPtr pkt)
// original command so that additional snoops can take place // original command so that additional snoops can take place
// properly // properly
MemCmd orig_cmd = pkt->cmd; MemCmd orig_cmd = pkt->cmd;
MemCmd response_cmd = MemCmd::InvalidCmd; MemCmd snoop_response_cmd = MemCmd::InvalidCmd;
Tick snoop_response_latency = 0;
int orig_src = pkt->getSrc(); int orig_src = pkt->getSrc();
Port *target_port = findPort(pkt->getAddr(), pkt->getSrc()); Port *target_port = findPort(pkt->getAddr(), pkt->getSrc());
@ -388,15 +389,16 @@ Bus::recvAtomic(PacketPtr pkt)
// same port should not have both target addresses and snooping // same port should not have both target addresses and snooping
assert(p != target_port); assert(p != target_port);
if (p->getId() != pkt->getSrc()) { if (p->getId() != pkt->getSrc()) {
p->sendAtomic(pkt); Tick latency = p->sendAtomic(pkt);
if (pkt->isResponse()) { if (pkt->isResponse()) {
// response from snoop agent // response from snoop agent
assert(pkt->cmd != orig_cmd); assert(pkt->cmd != orig_cmd);
assert(pkt->memInhibitAsserted()); assert(pkt->memInhibitAsserted());
// should only happen once // should only happen once
assert(response_cmd == MemCmd::InvalidCmd); assert(snoop_response_cmd == MemCmd::InvalidCmd);
// save response state // save response state
response_cmd = pkt->cmd; snoop_response_cmd = pkt->cmd;
snoop_response_latency = latency;
// restore original packet state for remaining snoopers // restore original packet state for remaining snoopers
pkt->cmd = orig_cmd; pkt->cmd = orig_cmd;
pkt->setSrc(orig_src); pkt->setSrc(orig_src);
@ -405,19 +407,20 @@ Bus::recvAtomic(PacketPtr pkt)
} }
} }
Tick response_time = target_port->sendAtomic(pkt); Tick response_latency = target_port->sendAtomic(pkt);
// if we got a response from a snooper, restore it here // if we got a response from a snooper, restore it here
if (response_cmd != MemCmd::InvalidCmd) { if (snoop_response_cmd != MemCmd::InvalidCmd) {
// no one else should have responded // no one else should have responded
assert(!pkt->isResponse()); assert(!pkt->isResponse());
assert(pkt->cmd == orig_cmd); assert(pkt->cmd == orig_cmd);
pkt->cmd = response_cmd; pkt->cmd = snoop_response_cmd;
response_latency = snoop_response_latency;
} }
// why do we have this packet field and the return value both??? // why do we have this packet field and the return value both???
pkt->finishTime = std::max(response_time, curTick + clock); pkt->finishTime = curTick + response_latency;
return pkt->finishTime; return response_latency;
} }
/** Function called by the port when the bus is receiving a Functional /** Function called by the port when the bus is receiving a Functional