mem: Remove redundant findVictim() input argument

The patch
(1) removes the redundant writeback argument from findVictim()
(2) fixes the description of access() function

Committed by: Nilay Vaish <nilay@cs.wisc.edu>
This commit is contained in:
Amin Farmahini 2014-01-28 18:00:50 -06:00
parent 575a73f4a1
commit ffbdaa7cce
6 changed files with 6 additions and 8 deletions

View file

@ -195,9 +195,9 @@ class Cache : public BaseCache
/**
* Does all the processing necessary to perform the provided request.
* @param pkt The memory request to perform.
* @param blk The cache block to be updated.
* @param lat The latency of the access.
* @param writebacks List for any writebacks that need to be performed.
* @param update True if the replacement data should be updated.
* @return Boolean indicating whether the request was satisfied.
*/
bool access(PacketPtr pkt, BlkType *&blk,

View file

@ -1192,7 +1192,7 @@ typename Cache<TagStore>::BlkType*
Cache<TagStore>::allocateBlock(Addr addr, bool is_secure,
PacketList &writebacks)
{
BlkType *blk = tags->findVictim(addr, writebacks);
BlkType *blk = tags->findVictim(addr);
if (blk->isValid()) {
Addr repl_addr = tags->regenerateBlkAddr(blk->tag, blk->set);

View file

@ -224,7 +224,7 @@ FALRU::findBlock(Addr addr, bool is_secure) const
}
FALRUBlk*
FALRU::findVictim(Addr addr, PacketList &writebacks)
FALRU::findVictim(Addr addr)
{
FALRUBlk * blk = tail;
assert(blk->inCache == 0);

View file

@ -203,10 +203,9 @@ public:
/**
* Find a replacement block for the address provided.
* @param pkt The request to a find a replacement candidate for.
* @param writebacks List for any writebacks to be performed.
* @return The block to place the replacement in.
*/
FALRUBlk* findVictim(Addr addr, PacketList & writebacks);
FALRUBlk* findVictim(Addr addr);
void insertBlock(PacketPtr pkt, BlkType *blk);

View file

@ -172,7 +172,7 @@ LRU::findBlock(Addr addr, bool is_secure) const
}
LRU::BlkType*
LRU::findVictim(Addr addr, PacketList &writebacks)
LRU::findVictim(Addr addr)
{
unsigned set = extractSet(addr);
// grab a replacement candidate

View file

@ -169,10 +169,9 @@ public:
/**
* Find a block to evict for the address provided.
* @param addr The addr to a find a replacement candidate for.
* @param writebacks List for any writebacks to be performed.
* @return The candidate block.
*/
BlkType* findVictim(Addr addr, PacketList &writebacks);
BlkType* findVictim(Addr addr);
/**
* Insert the new block into the cache. For LRU this means inserting into