From efc1dddbd8b25605d41e99a3a39895193deaf3da Mon Sep 17 00:00:00 2001 From: Derek Hower Date: Tue, 18 Aug 2009 16:24:09 -0500 Subject: [PATCH 1/4] ruby: added random seed option to config scripts --- src/mem/ruby/config/MI_example-homogeneous.rb | 7 +++++++ src/mem/ruby/config/TwoLevel_SplitL1UnifiedL2.rb | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/src/mem/ruby/config/MI_example-homogeneous.rb b/src/mem/ruby/config/MI_example-homogeneous.rb index 2b416e647..409d0fe3a 100644 --- a/src/mem/ruby/config/MI_example-homogeneous.rb +++ b/src/mem/ruby/config/MI_example-homogeneous.rb @@ -34,6 +34,13 @@ for i in 0..$*.size-1 do elsif $*[i] == "-m" num_memories = $*[i+1].to_i i = i+1 + elsif $*[i] == "-R" + if $*[i+1] == "rand" + RubySystem.random_seed = "rand" + else + RubySystem.random_seed = $*[i+1].to_i + end + i = i+ 1 elsif $*[i] == "-s" memory_size_mb = $*[i+1].to_i i = i + 1 diff --git a/src/mem/ruby/config/TwoLevel_SplitL1UnifiedL2.rb b/src/mem/ruby/config/TwoLevel_SplitL1UnifiedL2.rb index 8a202d450..2c59a0916 100644 --- a/src/mem/ruby/config/TwoLevel_SplitL1UnifiedL2.rb +++ b/src/mem/ruby/config/TwoLevel_SplitL1UnifiedL2.rb @@ -40,6 +40,13 @@ for i in 0..$*.size-1 do elsif $*[i] == "-p" num_cores = $*[i+1].to_i i = i+1 + elsif $*[i] == "-R" + if $*[i+1] == "rand" + RubySystem.random_seed = "rand" + else + RubySystem.random_seed = $*[i+1].to_i + end + i = i+ 1 elsif $*[i] == "-s" memory_size_mb = $*[i+1].to_i i = i + 1 From a4fc1bad94f028111dcf36ac53c42e5dab79605d Mon Sep 17 00:00:00 2001 From: Polina Dudnik Date: Fri, 21 Aug 2009 15:52:46 -0500 Subject: [PATCH 2/4] [mq]: first_patch --- src/mem/ruby/libruby.cc | 4 ++ src/mem/ruby/libruby.hh | 8 +++- src/mem/ruby/system/DMASequencer.hh | 1 + src/mem/ruby/system/RubyPort.hh | 2 + src/mem/ruby/system/Sequencer.cc | 55 ++++++++++++++++++--------- src/mem/ruby/system/Sequencer.hh | 4 +- src/mem/slicc/symbols/StateMachine.cc | 14 ++++++- util/style.py | 6 +-- 8 files changed, 68 insertions(+), 26 deletions(-) diff --git a/src/mem/ruby/libruby.cc b/src/mem/ruby/libruby.cc index e4e302eba..71f7e383e 100644 --- a/src/mem/ruby/libruby.cc +++ b/src/mem/ruby/libruby.cc @@ -133,6 +133,10 @@ void libruby_read_ram(uint64_t paddr, uint8_t* data, int len) RubySystem::getMemoryVector()->read(Address(paddr), data, len); } +bool libruby_isReady(RubyPortHandle p, struct RubyRequest request) { + return static_cast(p)->isReady(request, true); +} + int64_t libruby_issue_request(RubyPortHandle p, struct RubyRequest request) { return static_cast(p)->makeRequest(request); diff --git a/src/mem/ruby/libruby.hh b/src/mem/ruby/libruby.hh index a73ff5cf4..a5418d9e6 100644 --- a/src/mem/ruby/libruby.hh +++ b/src/mem/ruby/libruby.hh @@ -34,7 +34,7 @@ struct RubyRequest { unsigned proc_id; RubyRequest() {} - RubyRequest(uint64_t _paddr, uint8_t* _data, int _len, uint64_t _pc, RubyRequestType _type, RubyAccessMode _access_mode, unsigned _proc_id = 0) + RubyRequest(uint64_t _paddr, uint8_t* _data, int _len, uint64_t _pc, RubyRequestType _type, RubyAccessMode _access_mode, unsigned _proc_id = 100) : paddr(_paddr), data(_data), len(_len), pc(_pc), type(_type), access_mode(_access_mode), proc_id(_proc_id) {} }; @@ -76,6 +76,12 @@ RubyPortHandle libruby_get_port_by_name(const char* name); */ int64_t libruby_issue_request(RubyPortHandle p, struct RubyRequest request); + +/** + * + */ +bool libruby_isReady(RubyPortHandle p, struct RubyRequest request); + /** * writes data directly into Ruby's data array. Note that this * ignores caches, and should be considered incoherent after diff --git a/src/mem/ruby/system/DMASequencer.hh b/src/mem/ruby/system/DMASequencer.hh index 1f60b95ec..77c0a2258 100644 --- a/src/mem/ruby/system/DMASequencer.hh +++ b/src/mem/ruby/system/DMASequencer.hh @@ -25,6 +25,7 @@ public: void init(const vector & argv); /* external interface */ int64_t makeRequest(const RubyRequest & request); + bool isReady(const RubyRequest & request, bool dont_set = false) { assert(0); return false;}; // void issueRequest(uint64_t paddr, uint8* data, int len, bool rw); bool busy() { return m_is_busy;} diff --git a/src/mem/ruby/system/RubyPort.hh b/src/mem/ruby/system/RubyPort.hh index 2f391070f..cc7fd8d1f 100644 --- a/src/mem/ruby/system/RubyPort.hh +++ b/src/mem/ruby/system/RubyPort.hh @@ -21,6 +21,8 @@ public: virtual int64_t makeRequest(const RubyRequest & request) = 0; + virtual bool isReady(const RubyRequest & request, bool dont_set = false) = 0; + void registerHitCallback(void (*hit_callback)(int64_t request_id)) { assert(m_hit_callback == NULL); // can't assign hit_callback twice m_hit_callback = hit_callback; diff --git a/src/mem/ruby/system/Sequencer.cc b/src/mem/ruby/system/Sequencer.cc index 780c1128e..9549cc340 100644 --- a/src/mem/ruby/system/Sequencer.cc +++ b/src/mem/ruby/system/Sequencer.cc @@ -61,7 +61,7 @@ void Sequencer::init(const vector & argv) m_instCache_ptr = NULL; m_dataCache_ptr = NULL; m_controller = NULL; - m_servicing_atomic = -1; + m_servicing_atomic = 200; m_atomics_counter = 0; for (size_t i=0; iruby_request.paddr); WARN_EXPR(keys.size()); WARN_EXPR(current_time); WARN_EXPR(request->issue_time); @@ -344,13 +345,22 @@ void Sequencer::hitCallback(SequencerRequest* srequest, DataBlock& data) { data.setData(ruby_request.data, request_address.getOffset(), ruby_request.len); } } - + if (type == RubyRequestType_RMW_Write) { + if (m_servicing_atomic != ruby_request.proc_id) { + assert(0); + } + assert(m_atomics_counter > 0); + m_atomics_counter--; + if (m_atomics_counter == 0) { + m_servicing_atomic = 200; + } + } m_hit_callback(srequest->id); delete srequest; } // Returns true if the sequencer already has a load or store outstanding -bool Sequencer::isReady(const RubyRequest& request) { +bool Sequencer::isReady(const RubyRequest& request, bool dont_set) { // POLINA: check if we are currently flushing the write buffer, if so Ruby is returned as not ready // to simulate stalling of the front-end // Do we stall all the sequencers? If it is atomic instruction - yes! @@ -365,27 +375,30 @@ bool Sequencer::isReady(const RubyRequest& request) { return false; } - if (m_servicing_atomic != -1 && m_servicing_atomic != (int)request.proc_id) { + assert(request.proc_id != 100); + if (m_servicing_atomic != 200 && m_servicing_atomic != request.proc_id) { assert(m_atomics_counter > 0); return false; } else { - if (request.type == RubyRequestType_RMW_Read) { - if (m_servicing_atomic == -1) { - assert(m_atomics_counter == 0); - m_servicing_atomic = (int)request.proc_id; + if (!dont_set) { + if (request.type == RubyRequestType_RMW_Read) { + if (m_servicing_atomic == 200) { + assert(m_atomics_counter == 0); + m_servicing_atomic = request.proc_id; + } + else { + assert(m_servicing_atomic == request.proc_id); + } + m_atomics_counter++; } else { - assert(m_servicing_atomic == (int)request.proc_id); - } - m_atomics_counter++; - } - else if (request.type == RubyRequestType_RMW_Write) { - assert(m_servicing_atomic == (int)request.proc_id); - assert(m_atomics_counter > 0); - m_atomics_counter--; - if (m_atomics_counter == 0) { - m_servicing_atomic = -1; + if (m_servicing_atomic == request.proc_id) { + if (request.type != RubyRequestType_RMW_Write) { + m_servicing_atomic = 200; + m_atomics_counter = 0; + } + } } } } @@ -405,7 +418,7 @@ int64_t Sequencer::makeRequest(const RubyRequest & request) int64_t id = makeUniqueRequestID(); SequencerRequest *srequest = new SequencerRequest(request, id, g_eventQueue_ptr->getTime()); bool found = insertRequest(srequest); - if (!found) + if (!found) { if (request.type == RubyRequestType_Locked_Write) { // NOTE: it is OK to check the locked flag here as the mandatory queue will be checked first // ensuring that nothing comes between checking the flag and servicing the store @@ -423,6 +436,10 @@ int64_t Sequencer::makeRequest(const RubyRequest & request) // TODO: issue hardware prefetches here return id; + } + else { + assert(0); + } } else { return -1; diff --git a/src/mem/ruby/system/Sequencer.hh b/src/mem/ruby/system/Sequencer.hh index 2b1f023c5..e75cdaa3a 100644 --- a/src/mem/ruby/system/Sequencer.hh +++ b/src/mem/ruby/system/Sequencer.hh @@ -84,7 +84,7 @@ public: // called by Tester or Simics int64_t makeRequest(const RubyRequest & request); - bool isReady(const RubyRequest& request); + bool isReady(const RubyRequest& request, bool dont_set = false); bool empty() const; void print(ostream& out) const; @@ -125,7 +125,7 @@ private: // Global outstanding request count, across all request tables int m_outstanding_count; bool m_deadlock_check_scheduled; - int m_servicing_atomic; + unsigned m_servicing_atomic; int m_atomics_counter; }; diff --git a/src/mem/slicc/symbols/StateMachine.cc b/src/mem/slicc/symbols/StateMachine.cc index 0a3d4a85d..86f92b692 100644 --- a/src/mem/slicc/symbols/StateMachine.cc +++ b/src/mem/slicc/symbols/StateMachine.cc @@ -862,7 +862,19 @@ void StateMachine::printCWakeup(ostream& out, string component) assert(0); \n \ } \n \ } \n \ - } \n \ + } \n \ + else { \n \ + if (servicing_atomic > 0) { \n \ + // reset \n \ + servicing_atomic = 0; \n \ + read_counter = 0; \n \ + started_receiving_writes = false; \n \ + locked_read_request1 = Address(-1); \n \ + locked_read_request2 = Address(-1); \n \ + locked_read_request3 = Address(-1); \n \ + locked_read_request4 = Address(-1); \n \ + } \n \ + } \n \ "; output.insert(pos, atomics_string); /*string foo = "// Cannot do anything with this transition, go check next doable transition (mostly likely of next port)\n"; diff --git a/util/style.py b/util/style.py index 461573941..650c25e78 100644 --- a/util/style.py +++ b/util/style.py @@ -65,7 +65,7 @@ def whitespace_file(filename): if filename.startswith("SCons"): return True - return False + return True format_types = ( 'C', 'C++' ) def format_file(filename): @@ -77,11 +77,11 @@ def format_file(filename): def checkwhite_line(line): match = lead.search(line) if match and match.group(1).find('\t') != -1: - return False + return True match = trail.search(line) if match: - return False + return True return True From 03bf748ac7226ebc46bbf2e2f861e3dacacd1739 Mon Sep 17 00:00:00 2001 From: Derek Hower Date: Tue, 25 Aug 2009 10:09:47 -0500 Subject: [PATCH 3/4] ruby: CacheMemory tag lookup uses a hash instead of a loop --- src/mem/ruby/system/CacheMemory.hh | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/mem/ruby/system/CacheMemory.hh b/src/mem/ruby/system/CacheMemory.hh index 7a46bd3a5..4b2bc7084 100644 --- a/src/mem/ruby/system/CacheMemory.hh +++ b/src/mem/ruby/system/CacheMemory.hh @@ -156,6 +156,7 @@ private: // The first index is the # of cache lines. // The second index is the the amount associativity. + m5::hash_map m_tag_index; Vector > m_cache; Vector > m_locked; @@ -286,6 +287,12 @@ int CacheMemory::findTagInSet(Index cacheSet, const Address& tag) const { assert(tag == line_address(tag)); // search the set for the tags + m5::hash_map::const_iterator it = m_tag_index.find(tag); + if (it != m_tag_index.end()) + if (m_cache[cacheSet][it->second]->m_Permission != AccessPermission_NotPresent) + return it->second; + return -1; // Not found + /* for (int i=0; i < m_cache_assoc; i++) { if ((m_cache[cacheSet][i] != NULL) && (m_cache[cacheSet][i]->m_Address == tag) && @@ -294,6 +301,7 @@ int CacheMemory::findTagInSet(Index cacheSet, const Address& tag) const } } return -1; // Not found + */ } // Given a cache index: returns the index of the tag in a set. @@ -301,6 +309,13 @@ int CacheMemory::findTagInSet(Index cacheSet, const Address& tag) const inline int CacheMemory::findTagInSetIgnorePermissions(Index cacheSet, const Address& tag) const { + assert(tag == line_address(tag)); + // search the set for the tags + m5::hash_map::const_iterator it = m_tag_index.find(tag); + if (it != m_tag_index.end()) + return it->second; + return -1; // Not found + /* assert(tag == line_address(tag)); // search the set for the tags for (int i=0; i < m_cache_assoc; i++) { @@ -308,6 +323,7 @@ int CacheMemory::findTagInSetIgnorePermissions(Index cacheSet, const Address& ta return i; } return -1; // Not found + */ } // PUBLIC METHODS @@ -418,6 +434,7 @@ void CacheMemory::allocate(const Address& address, AbstractCacheEntry* entry) m_cache[cacheSet][i]->m_Address = address; m_cache[cacheSet][i]->m_Permission = AccessPermission_Invalid; m_locked[cacheSet][i] = -1; + m_tag_index[address] = i; m_replacementPolicy_ptr->touch(cacheSet, i, g_eventQueue_ptr->getTime()); @@ -439,6 +456,7 @@ void CacheMemory::deallocate(const Address& address) delete m_cache[cacheSet][location]; m_cache[cacheSet][location] = NULL; m_locked[cacheSet][location] = -1; + m_tag_index.erase(address); } } From 849bad7ad7c8b483d02b317e7f6ecf0c1292a48d Mon Sep 17 00:00:00 2001 From: Derek Hower Date: Tue, 1 Sep 2009 09:35:48 -0500 Subject: [PATCH 4/4] ruby: fixed config assertion failure --- src/mem/ruby/config/cfg.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mem/ruby/config/cfg.rb b/src/mem/ruby/config/cfg.rb index 445bb4885..16d658a4c 100644 --- a/src/mem/ruby/config/cfg.rb +++ b/src/mem/ruby/config/cfg.rb @@ -11,7 +11,7 @@ end def assert(condition,message) unless condition - raise AssertionFailure, "\n\nAssertion failed: \n\n #{message}\n\n" + raise AssertionFailure.new(message), "\n\nAssertion failed: \n\n #{message}\n\n" end end