diff --git a/src/cpu/o3/fetch_impl.hh b/src/cpu/o3/fetch_impl.hh index 990db88ac..25be9d455 100644 --- a/src/cpu/o3/fetch_impl.hh +++ b/src/cpu/o3/fetch_impl.hh @@ -672,9 +672,9 @@ DefaultFetch::doSquash(const Addr &new_PC, unsigned tid) assert(cacheBlocked); cacheBlocked = false; retryTid = -1; - retryPkt = NULL; delete retryPkt->req; delete retryPkt; + retryPkt = NULL; } fetchStatus[tid] = Squashing; diff --git a/src/cpu/o3/lsq_impl.hh b/src/cpu/o3/lsq_impl.hh index db2c253e1..2bbab71f0 100644 --- a/src/cpu/o3/lsq_impl.hh +++ b/src/cpu/o3/lsq_impl.hh @@ -71,6 +71,11 @@ template void LSQ::DcachePort::recvRetry() { + if (lsq->retryTid == -1) + { + //Squashed, so drop it + return; + } lsq->thread[lsq->retryTid].recvRetry(); // Speculatively clear the retry Tid. This will get set again if // the LSQUnit was unable to complete its access. diff --git a/src/cpu/o3/lsq_unit.hh b/src/cpu/o3/lsq_unit.hh index 512b5a63c..1358a3699 100644 --- a/src/cpu/o3/lsq_unit.hh +++ b/src/cpu/o3/lsq_unit.hh @@ -646,6 +646,8 @@ LSQUnit::read(Request *req, T &data, int load_idx) // handle it. if (lsq->cacheBlocked()) { ++lsqCacheBlocked; + + iewStage->decrWb(load_inst->seqNum); // There's an older load that's already going to squash. if (isLoadBlocked && blockedLoadSeqNum < load_inst->seqNum) return NoFault; diff --git a/src/cpu/o3/lsq_unit_impl.hh b/src/cpu/o3/lsq_unit_impl.hh index 4f5dbbf1c..fa716c712 100644 --- a/src/cpu/o3/lsq_unit_impl.hh +++ b/src/cpu/o3/lsq_unit_impl.hh @@ -626,6 +626,7 @@ LSQUnit::writebackStores() ++lsqCacheBlocked; assert(retryPkt == NULL); retryPkt = data_pkt; + lsq->setRetryTid(lsqID); } else { storePostSend(data_pkt); } @@ -869,6 +870,7 @@ LSQUnit::recvRetry() storePostSend(retryPkt); retryPkt = NULL; isStoreBlocked = false; + lsq->setRetryTid(-1); } else { // Still blocked! ++lsqCacheBlocked;