sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

kvm: x86: Always assume segments to be usable

Browse source 
When transferring segment registers into kvm, we need to find the
value of the unusable bit. We used to assume that this could be
inferred from the selector since segments are generally unusable if
their selector is 0. This assumption breaks in some weird corner
cases.  Instead, we just assume that segments are always usable. This
is what qemu does so it should work.
This commit is contained in:
Andreas Sandberg 2014-03-03 14:34:33 +01:00
parent 739cc0128b
commit e7d230ede0
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/cpu/kvm/x86_cpu.cc
View file

@ -721,11 +721,11 @@ setKvmSegmentReg(ThreadContext *tc, struct kvm_segment &kvm_seg,
kvm_seg.g = attr.granularity;
kvm_seg.avl = attr.avl;
// A segment is unusable when the selector is zero. There is a
// attr.unusable flag in gem5, but it seems unused.
//
// TODO: Are there corner cases where this doesn't work?
kvm_seg.unusable = (kvm_seg.selector == 0);
// A segment is normally unusable when the selector is zero. There
// is a attr.unusable flag in gem5, but it seems unused. qemu
// seems to set this to 0 all the time, so we just do the same and
// hope for the best.
kvm_seg.unusable = 0;
}
static inline void