Clean up cache DPRINTFs
--HG-- extra : convert_revision : f836e77efd40e25259d7794dd148696586b79a09
This commit is contained in:
parent
1b21d9ba5e
commit
e321a21e27
2 changed files with 24 additions and 40 deletions
4
src/mem/cache/base_cache.cc
vendored
4
src/mem/cache/base_cache.cc
vendored
|
@ -79,9 +79,7 @@ BaseCache::CachePort::recvTiming(PacketPtr pkt)
|
|||
&& !pkt->isRead() && !pkt->isWrite()) {
|
||||
//Upgrade or Invalidate
|
||||
//Look into what happens if two slave caches on bus
|
||||
DPRINTF(Cache, "%s %x ? blk_addr: %x\n", pkt->cmdString(),
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1),
|
||||
pkt->getAddr() & ~((Addr)cache->blkSize - 1));
|
||||
DPRINTF(Cache, "%s %x ?\n", pkt->cmdString(), pkt->getAddr());
|
||||
|
||||
assert(!(pkt->flags & SATISFIED));
|
||||
pkt->flags |= SATISFIED;
|
||||
|
|
60
src/mem/cache/cache_impl.hh
vendored
60
src/mem/cache/cache_impl.hh
vendored
|
@ -205,9 +205,10 @@ Cache<TagStore,Buffering,Coherence>::access(PacketPtr &pkt)
|
|||
missQueue->doWriteback(writebacks.front());
|
||||
writebacks.pop_front();
|
||||
}
|
||||
DPRINTF(Cache, "%s %x %s blk_addr: %x\n", pkt->cmdString(),
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1), (blk) ? "hit" : "miss",
|
||||
pkt->getAddr() & ~((Addr)blkSize - 1));
|
||||
|
||||
DPRINTF(Cache, "%s %x %s\n", pkt->cmdString(), pkt->getAddr(),
|
||||
(blk) ? "hit" : "miss");
|
||||
|
||||
if (blk) {
|
||||
// Hit
|
||||
hits[pkt->cmdToIndex()][0/*pkt->req->getThreadNum()*/]++;
|
||||
|
@ -288,10 +289,8 @@ Cache<TagStore,Buffering,Coherence>::sendResult(PacketPtr &pkt, MSHR* mshr,
|
|||
CacheBlk::State old_state = (blk) ? blk->status : 0;
|
||||
CacheBlk::State new_state = coherence->getNewState(pkt,old_state);
|
||||
if (old_state != new_state)
|
||||
DPRINTF(Cache, "Block for blk addr %x moving from "
|
||||
"state %i to %i\n",
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1),
|
||||
old_state, new_state);
|
||||
DPRINTF(Cache, "Block for blk addr %x moving from state "
|
||||
"%i to %i\n", pkt->getAddr(), old_state, new_state);
|
||||
//Set the state on the upgrade
|
||||
memcpy(pkt->getPtr<uint8_t>(), blk->data, blkSize);
|
||||
PacketList writebacks;
|
||||
|
@ -331,8 +330,7 @@ Cache<TagStore,Buffering,Coherence>::handleResponse(PacketPtr &pkt)
|
|||
//Make the response a Bad address and send it
|
||||
}
|
||||
// MemDebug::cacheResponse(pkt);
|
||||
DPRINTF(Cache, "Handling reponse to %x, blk addr: %x\n",pkt->getAddr(),
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1));
|
||||
DPRINTF(Cache, "Handling reponse to %x\n", pkt->getAddr());
|
||||
|
||||
if (pkt->isCacheFill() && !pkt->isNoAllocate()) {
|
||||
blk = tags->findBlock(pkt);
|
||||
|
@ -342,7 +340,7 @@ Cache<TagStore,Buffering,Coherence>::handleResponse(PacketPtr &pkt)
|
|||
if (old_state != new_state)
|
||||
DPRINTF(Cache, "Block for blk addr %x moving from "
|
||||
"state %i to %i\n",
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1),
|
||||
pkt->getAddr(),
|
||||
old_state, new_state);
|
||||
blk = tags->handleFill(blk, (MSHR*)pkt->senderState,
|
||||
new_state, writebacks, pkt);
|
||||
|
@ -427,8 +425,8 @@ Cache<TagStore,Buffering,Coherence>::snoop(PacketPtr &pkt)
|
|||
|
||||
//Append the invalidate on
|
||||
missQueue->addTarget(mshr,invalidatePkt);
|
||||
DPRINTF(Cache, "Appending Invalidate to blk_addr: %x\n",
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1));
|
||||
DPRINTF(Cache, "Appending Invalidate to addr: %x\n",
|
||||
pkt->getAddr());
|
||||
return;
|
||||
}
|
||||
}
|
||||
|
@ -436,8 +434,8 @@ Cache<TagStore,Buffering,Coherence>::snoop(PacketPtr &pkt)
|
|||
//We also need to check the writeback buffers and handle those
|
||||
std::vector<MSHR *> writebacks;
|
||||
if (missQueue->findWrites(blk_addr, writebacks)) {
|
||||
DPRINTF(Cache, "Snoop hit in writeback to blk_addr: %x\n",
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1));
|
||||
DPRINTF(Cache, "Snoop hit in writeback to addr: %x\n",
|
||||
pkt->getAddr());
|
||||
|
||||
//Look through writebacks for any non-uncachable writes, use that
|
||||
for (int i=0; i<writebacks.size(); i++) {
|
||||
|
@ -528,12 +526,9 @@ Cache<TagStore,Buffering,Coherence>::probe(PacketPtr &pkt, bool update,
|
|||
{
|
||||
// MemDebug::cacheProbe(pkt);
|
||||
if (!pkt->req->isUncacheable()) {
|
||||
if (pkt->isInvalidate() && !pkt->isRead()
|
||||
&& !pkt->isWrite()) {
|
||||
if (pkt->isInvalidate() && !pkt->isRead() && !pkt->isWrite()) {
|
||||
//Upgrade or Invalidate, satisfy it, don't forward
|
||||
DPRINTF(Cache, "%s %x ? blk_addr: %x\n", pkt->cmdString(),
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1),
|
||||
pkt->getAddr() & ~((Addr)blkSize - 1));
|
||||
DPRINTF(Cache, "%s %x ?\n", pkt->cmdString(), pkt->getAddr());
|
||||
pkt->flags |= SATISFIED;
|
||||
return 0;
|
||||
}
|
||||
|
@ -550,9 +545,8 @@ Cache<TagStore,Buffering,Coherence>::probe(PacketPtr &pkt, bool update,
|
|||
int lat;
|
||||
BlkType *blk = tags->handleAccess(pkt, lat, writebacks, update);
|
||||
|
||||
DPRINTF(Cache, "%s %x %s blk_addr: %x\n", pkt->cmdString(),
|
||||
pkt->getAddr() & (((ULL(1))<<48)-1), (blk) ? "hit" : "miss",
|
||||
pkt->getAddr() & ~((Addr)blkSize - 1));
|
||||
DPRINTF(Cache, "%s %x %s\n", pkt->cmdString(),
|
||||
pkt->getAddr(), (blk) ? "hit" : "miss");
|
||||
|
||||
|
||||
// Need to check for outstanding misses and writes
|
||||
|
@ -611,10 +605,8 @@ Cache<TagStore,Buffering,Coherence>::probe(PacketPtr &pkt, bool update,
|
|||
|
||||
busPkt->time = curTick;
|
||||
|
||||
DPRINTF(Cache, "Sending a atomic %s for %x blk_addr: %x\n",
|
||||
busPkt->cmdString(),
|
||||
busPkt->getAddr() & (((ULL(1))<<48)-1),
|
||||
busPkt->getAddr() & ~((Addr)blkSize - 1));
|
||||
DPRINTF(Cache, "Sending a atomic %s for %x\n",
|
||||
busPkt->cmdString(), busPkt->getAddr());
|
||||
|
||||
lat = memSidePort->sendAtomic(busPkt);
|
||||
|
||||
|
@ -633,19 +625,13 @@ return 0;
|
|||
CacheBlk::State old_state = (blk) ? blk->status : 0;
|
||||
CacheBlk::State new_state =
|
||||
coherence->getNewState(busPkt, old_state);
|
||||
DPRINTF(Cache,
|
||||
"Receive response:%s for blk addr %x in state %i\n",
|
||||
busPkt->cmdString(),
|
||||
busPkt->getAddr() & (((ULL(1))<<48)-1), old_state);
|
||||
DPRINTF(Cache, "Receive response: %s for addr %x in state %i\n",
|
||||
busPkt->cmdString(), busPkt->getAddr(), old_state);
|
||||
if (old_state != new_state)
|
||||
DPRINTF(Cache, "Block for blk addr %x moving from "
|
||||
"state %i to %i\n",
|
||||
busPkt->getAddr() & (((ULL(1))<<48)-1),
|
||||
old_state, new_state);
|
||||
DPRINTF(Cache, "Block for blk addr %x moving from state "
|
||||
"%i to %i\n", busPkt->getAddr(), old_state, new_state);
|
||||
|
||||
tags->handleFill(blk, busPkt,
|
||||
new_state,
|
||||
writebacks, pkt);
|
||||
tags->handleFill(blk, busPkt, new_state, writebacks, pkt);
|
||||
//Free the packet
|
||||
delete busPkt;
|
||||
|
||||
|
|
Loading…
Reference in a new issue