Split BaseCache::CacheEvent into RequestEvent and ResponseEvent.
Compiles but not tested. --HG-- extra : convert_revision : 4e1e28c4b87721ccfcf35a5ea62c1fa324acbaf9
This commit is contained in:
parent
011db5c851
commit
df3fc36fa9
3 changed files with 122 additions and 117 deletions
42
src/mem/cache/base_cache.cc
vendored
42
src/mem/cache/base_cache.cc
vendored
|
@ -134,8 +134,7 @@ BaseCache::CachePort::recvRetry()
|
|||
isCpuSide && cache->doSlaveRequest()) {
|
||||
|
||||
DPRINTF(CachePort, "%s has more responses/requests\n", name());
|
||||
BaseCache::CacheEvent * reqCpu = new BaseCache::CacheEvent(this, false);
|
||||
reqCpu->schedule(curTick + 1);
|
||||
new BaseCache::RequestEvent(this, curTick + 1);
|
||||
}
|
||||
waitingOnRetry = false;
|
||||
}
|
||||
|
@ -178,8 +177,7 @@ BaseCache::CachePort::recvRetry()
|
|||
{
|
||||
DPRINTF(CachePort, "%s has more requests\n", name());
|
||||
//Still more to issue, rerequest in 1 cycle
|
||||
BaseCache::CacheEvent * reqCpu = new BaseCache::CacheEvent(this, false);
|
||||
reqCpu->schedule(curTick + 1);
|
||||
new BaseCache::RequestEvent(this, curTick + 1);
|
||||
}
|
||||
}
|
||||
else
|
||||
|
@ -196,8 +194,7 @@ BaseCache::CachePort::recvRetry()
|
|||
{
|
||||
DPRINTF(CachePort, "%s has more requests\n", name());
|
||||
//Still more to issue, rerequest in 1 cycle
|
||||
BaseCache::CacheEvent * reqCpu = new BaseCache::CacheEvent(this, false);
|
||||
reqCpu->schedule(curTick + 1);
|
||||
new BaseCache::RequestEvent(this, curTick + 1);
|
||||
}
|
||||
}
|
||||
if (waitingOnRetry) DPRINTF(CachePort, "%s STILL Waiting on retry\n", name());
|
||||
|
@ -228,19 +225,16 @@ BaseCache::CachePort::clearBlocked()
|
|||
}
|
||||
}
|
||||
|
||||
BaseCache::CacheEvent::CacheEvent(CachePort *_cachePort, bool _newResponse)
|
||||
: Event(&mainEventQueue, CPU_Tick_Pri), cachePort(_cachePort),
|
||||
newResponse(_newResponse)
|
||||
BaseCache::RequestEvent::RequestEvent(CachePort *_cachePort, Tick when)
|
||||
: Event(&mainEventQueue, CPU_Tick_Pri), cachePort(_cachePort)
|
||||
{
|
||||
if (!newResponse)
|
||||
this->setFlags(AutoDelete);
|
||||
pkt = NULL;
|
||||
schedule(when);
|
||||
}
|
||||
|
||||
void
|
||||
BaseCache::CacheEvent::process()
|
||||
{
|
||||
if (!newResponse)
|
||||
BaseCache::RequestEvent::process()
|
||||
{
|
||||
if (cachePort->waitingOnRetry) return;
|
||||
//We have some responses to drain first
|
||||
|
@ -318,9 +312,23 @@ BaseCache::CacheEvent::process()
|
|||
this->schedule(curTick+1);
|
||||
}
|
||||
}
|
||||
return;
|
||||
}
|
||||
//Else it's a response
|
||||
|
||||
const char *
|
||||
BaseCache::RequestEvent::description()
|
||||
{
|
||||
return "Cache request event";
|
||||
}
|
||||
|
||||
BaseCache::ResponseEvent::ResponseEvent(CachePort *_cachePort)
|
||||
: Event(&mainEventQueue, CPU_Tick_Pri), cachePort(_cachePort)
|
||||
{
|
||||
pkt = NULL;
|
||||
}
|
||||
|
||||
void
|
||||
BaseCache::ResponseEvent::process()
|
||||
{
|
||||
assert(cachePort->transmitList.size());
|
||||
assert(cachePort->transmitList.front().first <= curTick);
|
||||
pkt = cachePort->transmitList.front().second;
|
||||
|
@ -354,9 +362,9 @@ BaseCache::CacheEvent::process()
|
|||
}
|
||||
|
||||
const char *
|
||||
BaseCache::CacheEvent::description()
|
||||
BaseCache::ResponseEvent::description()
|
||||
{
|
||||
return "BaseCache timing event";
|
||||
return "Cache response event";
|
||||
}
|
||||
|
||||
void
|
||||
|
|
27
src/mem/cache/base_cache.hh
vendored
27
src/mem/cache/base_cache.hh
vendored
|
@ -117,13 +117,22 @@ class BaseCache : public MemObject
|
|||
std::list<std::pair<Tick,PacketPtr> > transmitList;
|
||||
};
|
||||
|
||||
struct CacheEvent : public Event
|
||||
struct RequestEvent : public Event
|
||||
{
|
||||
CachePort *cachePort;
|
||||
PacketPtr pkt;
|
||||
bool newResponse;
|
||||
|
||||
CacheEvent(CachePort *_cachePort, bool response);
|
||||
RequestEvent(CachePort *_cachePort, Tick when);
|
||||
void process();
|
||||
const char *description();
|
||||
};
|
||||
|
||||
struct ResponseEvent : public Event
|
||||
{
|
||||
CachePort *cachePort;
|
||||
PacketPtr pkt;
|
||||
|
||||
ResponseEvent(CachePort *_cachePort);
|
||||
void process();
|
||||
const char *description();
|
||||
};
|
||||
|
@ -132,8 +141,8 @@ class BaseCache : public MemObject
|
|||
CachePort *cpuSidePort;
|
||||
CachePort *memSidePort;
|
||||
|
||||
CacheEvent *sendEvent;
|
||||
CacheEvent *memSendEvent;
|
||||
ResponseEvent *sendEvent;
|
||||
ResponseEvent *memSendEvent;
|
||||
|
||||
private:
|
||||
void recvStatusChange(Port::Status status, bool isCpuSide)
|
||||
|
@ -432,9 +441,7 @@ class BaseCache : public MemObject
|
|||
{
|
||||
if (!doMasterRequest() && !memSidePort->waitingOnRetry)
|
||||
{
|
||||
BaseCache::CacheEvent * reqCpu =
|
||||
new BaseCache::CacheEvent(memSidePort, false);
|
||||
reqCpu->schedule(time);
|
||||
new RequestEvent(memSidePort, time);
|
||||
}
|
||||
uint8_t flag = 1<<cause;
|
||||
masterRequests |= flag;
|
||||
|
@ -469,9 +476,7 @@ class BaseCache : public MemObject
|
|||
{
|
||||
if (!doSlaveRequest() && !cpuSidePort->waitingOnRetry)
|
||||
{
|
||||
BaseCache::CacheEvent * reqCpu =
|
||||
new BaseCache::CacheEvent(cpuSidePort, false);
|
||||
reqCpu->schedule(time);
|
||||
new RequestEvent(cpuSidePort, time);
|
||||
}
|
||||
uint8_t flag = 1<<cause;
|
||||
slaveRequests |= flag;
|
||||
|
|
14
src/mem/cache/cache_impl.hh
vendored
14
src/mem/cache/cache_impl.hh
vendored
|
@ -1146,11 +1146,11 @@ template<class TagStore, class Coherence>
|
|||
Port *
|
||||
Cache<TagStore,Coherence>::getPort(const std::string &if_name, int idx)
|
||||
{
|
||||
if (if_name == "")
|
||||
if (if_name == "" || if_name == "cpu_side")
|
||||
{
|
||||
if (cpuSidePort == NULL) {
|
||||
cpuSidePort = new CpuSidePort(name() + "-cpu_side_port", this);
|
||||
sendEvent = new CacheEvent(cpuSidePort, true);
|
||||
sendEvent = new ResponseEvent(cpuSidePort);
|
||||
}
|
||||
return cpuSidePort;
|
||||
}
|
||||
|
@ -1158,20 +1158,12 @@ Cache<TagStore,Coherence>::getPort(const std::string &if_name, int idx)
|
|||
{
|
||||
return new CpuSidePort(name() + "-cpu_side_funcport", this);
|
||||
}
|
||||
else if (if_name == "cpu_side")
|
||||
{
|
||||
if (cpuSidePort == NULL) {
|
||||
cpuSidePort = new CpuSidePort(name() + "-cpu_side_port", this);
|
||||
sendEvent = new CacheEvent(cpuSidePort, true);
|
||||
}
|
||||
return cpuSidePort;
|
||||
}
|
||||
else if (if_name == "mem_side")
|
||||
{
|
||||
if (memSidePort != NULL)
|
||||
panic("Already have a mem side for this cache\n");
|
||||
memSidePort = new MemSidePort(name() + "-mem_side_port", this);
|
||||
memSendEvent = new CacheEvent(memSidePort, true);
|
||||
memSendEvent = new ResponseEvent(memSidePort);
|
||||
return memSidePort;
|
||||
}
|
||||
else panic("Port name %s unrecognized\n", if_name);
|
||||
|
|
Loading…
Reference in a new issue