sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mem: fix assertion in respondEvent

Browse source 
Assertion in the respondEvent erroneously fired.
The assertion verifies that the controller has not moved to a low-power
state prior to receiving read data from the memory.
The original assertion triggered if the state was not:
	PWR_IDLE or PWR_ACT.

In the case that failed, a periodic refresh event occurred around the
read.  The REF is stalled until the final read burst is issued
and the subsequent PRE closes the bank.  While the PRE will temporarily
move the state to PWR_IDLE, state will immediately transition to PWR_REF
due to the pending refresh operation.  This state does not match the
assertion, which is subsequently triggered.

Fixed the assertion by explicitly checking that the state is not a low
power state
	!PWR_SREF && !PWR_PRE_PDN && !PWR_ACT_PDN


Change-Id: I82921a733bbeac2bcb5a487c2f981448d41ed50b
Reviewed-by: Radhika Jagtap <radhika.jagtap@arm.com>
This commit is contained in:
Wendy Elsasser 2017-02-15 09:28:44 -06:00
parent 4b8b9c0585
commit ddc6931573
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/mem/dram_ctrl.cc
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2010-2016 ARM Limited
* Copyright (c) 2010-2017 ARM Limited
* All rights reserved
*
* The license below extends only to copyright in the software and shall
@ -678,18 +678,20 @@ DRAMCtrl::processRespondEvent()
// read response received, decrement count
--dram_pkt->rankRef.outstandingEvents;
// at this moment should be either ACT or IDLE depending on
// if PRE has occurred to close all banks
assert((dram_pkt->rankRef.pwrState == PWR_ACT) ||
(dram_pkt->rankRef.pwrState == PWR_IDLE));
// at this moment should not have transitioned to a low-power state
assert((dram_pkt->rankRef.pwrState != PWR_SREF) &&
(dram_pkt->rankRef.pwrState != PWR_PRE_PDN) &&
(dram_pkt->rankRef.pwrState != PWR_ACT_PDN));
// track if this is the last packet before idling
// and that there are no outstanding commands to this rank
if (dram_pkt->rankRef.lowPowerEntryReady()) {
// if REF in progress, transition to LP state should not occur
// until REF completes
if ((dram_pkt->rankRef.refreshState == REF_IDLE) &&
(dram_pkt->rankRef.lowPowerEntryReady())) {
// verify that there are no events scheduled
assert(!dram_pkt->rankRef.activateEvent.scheduled());
assert(!dram_pkt->rankRef.prechargeEvent.scheduled());
assert(dram_pkt->rankRef.refreshState == REF_IDLE);
// if coming from active state, schedule power event to
// active power-down else go to precharge power-down