mem: Fix sender state bug and delay popping
This patch fixes a newly introduced bug where the sender state was popped before checking that it should be. Amazingly all regressions pass, but Linux fails to boot on the detailed CPU with caches enabled.
This commit is contained in:
parent
a86f67e706
commit
da950caed2
1 changed files with 2 additions and 1 deletions
3
src/mem/cache/cache_impl.hh
vendored
3
src/mem/cache/cache_impl.hh
vendored
|
@ -366,7 +366,7 @@ Cache<TagStore>::recvTimingSnoopResp(PacketPtr pkt)
|
|||
|
||||
// must be cache-to-cache response from upper to lower level
|
||||
ForwardResponseRecord *rec =
|
||||
dynamic_cast<ForwardResponseRecord *>(pkt->popSenderState());
|
||||
dynamic_cast<ForwardResponseRecord *>(pkt->senderState);
|
||||
assert(!system->bypassCaches());
|
||||
|
||||
if (rec == NULL) {
|
||||
|
@ -379,6 +379,7 @@ Cache<TagStore>::recvTimingSnoopResp(PacketPtr pkt)
|
|||
return;
|
||||
}
|
||||
|
||||
pkt->popSenderState();
|
||||
pkt->setDest(rec->prevSrc);
|
||||
delete rec;
|
||||
// @todo someone should pay for this
|
||||
|
|
Loading…
Reference in a new issue