mem: Remove unused arguments (asid/contex_id) from accessBlock

Change-Id: I79c2662fc81630ab321db8a75be6cd15fa07d372
Reviewed-by: Andreas Hansson <andreas.hansson@arm.com>
Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
This commit is contained in:
Nikos Nikoleris 2017-02-21 14:14:44 +00:00
parent e8723310ef
commit cb97118d91
9 changed files with 18 additions and 27 deletions

View file

@ -314,11 +314,9 @@ Cache::access(PacketPtr pkt, CacheBlk *&blk, Cycles &lat,
return false; return false;
} }
ContextID id = pkt->req->hasContextId() ?
pkt->req->contextId() : InvalidContextID;
// Here lat is the value passed as parameter to accessBlock() function // Here lat is the value passed as parameter to accessBlock() function
// that can modify its value. // that can modify its value.
blk = tags->accessBlock(pkt->getAddr(), pkt->isSecure(), lat, id); blk = tags->accessBlock(pkt->getAddr(), pkt->isSecure(), lat);
DPRINTF(Cache, "%s %s\n", pkt->print(), DPRINTF(Cache, "%s %s\n", pkt->print(),
blk ? "hit " + blk->print() : "miss"); blk ? "hit " + blk->print() : "miss");

View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2012-2014 ARM Limited * Copyright (c) 2012-2014,2016 ARM Limited
* All rights reserved. * All rights reserved.
* *
* The license below extends only to copyright in the software and shall * The license below extends only to copyright in the software and shall
@ -225,8 +225,7 @@ class BaseTags : public ClockedObject
virtual void invalidate(CacheBlk *blk) = 0; virtual void invalidate(CacheBlk *blk) = 0;
virtual CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat, virtual CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat) = 0;
int context_src) = 0;
virtual Addr extractTag(Addr addr) const = 0; virtual Addr extractTag(Addr addr) const = 0;

View file

@ -155,12 +155,10 @@ public:
* side effect. * side effect.
* @param addr The address to find. * @param addr The address to find.
* @param is_secure True if the target memory space is secure. * @param is_secure True if the target memory space is secure.
* @param asid The address space ID.
* @param lat The access latency. * @param lat The access latency.
* @return Pointer to the cache block if found. * @return Pointer to the cache block if found.
*/ */
CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat, CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat) override
int context_src) override
{ {
Addr tag = extractTag(addr); Addr tag = extractTag(addr);
int set = extractSet(addr); int set = extractSet(addr);

View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2013 ARM Limited * Copyright (c) 2013,2016 ARM Limited
* All rights reserved. * All rights reserved.
* *
* The license below extends only to copyright in the software and shall * The license below extends only to copyright in the software and shall
@ -171,14 +171,13 @@ FALRU::invalidate(CacheBlk *blk)
} }
CacheBlk* CacheBlk*
FALRU::accessBlock(Addr addr, bool is_secure, Cycles &lat, int context_src) FALRU::accessBlock(Addr addr, bool is_secure, Cycles &lat)
{ {
return accessBlock(addr, is_secure, lat, context_src, 0); return accessBlock(addr, is_secure, lat, 0);
} }
CacheBlk* CacheBlk*
FALRU::accessBlock(Addr addr, bool is_secure, Cycles &lat, int context_src, FALRU::accessBlock(Addr addr, bool is_secure, Cycles &lat, int *inCache)
int *inCache)
{ {
accesses++; accesses++;
int tmp_in_cache = 0; int tmp_in_cache = 0;

View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2012-2013 ARM Limited * Copyright (c) 2012-2013,2016 ARM Limited
* All rights reserved. * All rights reserved.
* *
* The license below extends only to copyright in the software and shall * The license below extends only to copyright in the software and shall
@ -182,19 +182,17 @@ public:
* Returns the access latency and inCache flags as a side effect. * Returns the access latency and inCache flags as a side effect.
* @param addr The address to look for. * @param addr The address to look for.
* @param is_secure True if the target memory space is secure. * @param is_secure True if the target memory space is secure.
* @param asid The address space ID.
* @param lat The latency of the access. * @param lat The latency of the access.
* @param inCache The FALRUBlk::inCache flags. * @param inCache The FALRUBlk::inCache flags.
* @return Pointer to the cache block. * @return Pointer to the cache block.
*/ */
CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat, CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat,
int context_src, int *inCache); int *inCache);
/** /**
* Just a wrapper of above function to conform with the base interface. * Just a wrapper of above function to conform with the base interface.
*/ */
CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat, CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat) override;
int context_src) override;
/** /**
* Find the block in the cache, do not update the replacement data. * Find the block in the cache, do not update the replacement data.

View file

@ -56,9 +56,9 @@ LRU::LRU(const Params *p)
} }
CacheBlk* CacheBlk*
LRU::accessBlock(Addr addr, bool is_secure, Cycles &lat, int master_id) LRU::accessBlock(Addr addr, bool is_secure, Cycles &lat)
{ {
CacheBlk *blk = BaseSetAssoc::accessBlock(addr, is_secure, lat, master_id); CacheBlk *blk = BaseSetAssoc::accessBlock(addr, is_secure, lat);
if (blk != nullptr) { if (blk != nullptr) {
// move this block to head of the MRU list // move this block to head of the MRU list

View file

@ -69,8 +69,7 @@ class LRU : public BaseSetAssoc
*/ */
~LRU() {} ~LRU() {}
CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat, CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat);
int context_src);
CacheBlk* findVictim(Addr addr); CacheBlk* findVictim(Addr addr);
void insertBlock(PacketPtr pkt, BlkType *blk); void insertBlock(PacketPtr pkt, BlkType *blk);
void invalidate(CacheBlk *blk); void invalidate(CacheBlk *blk);

View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2014 The Regents of The University of Michigan * Copyright (c) 2014 The Regents of The University of Michigan
* Copyright (c) 2016 ARM Limited
* All rights reserved. * All rights reserved.
* *
* Redistribution and use in source and binary forms, with or without * Redistribution and use in source and binary forms, with or without
@ -46,9 +47,9 @@ RandomRepl::RandomRepl(const Params *p)
} }
CacheBlk* CacheBlk*
RandomRepl::accessBlock(Addr addr, bool is_secure, Cycles &lat, int master_id) RandomRepl::accessBlock(Addr addr, bool is_secure, Cycles &lat)
{ {
return BaseSetAssoc::accessBlock(addr, is_secure, lat, master_id); return BaseSetAssoc::accessBlock(addr, is_secure, lat);
} }
CacheBlk* CacheBlk*

View file

@ -58,8 +58,7 @@ class RandomRepl : public BaseSetAssoc
*/ */
~RandomRepl() {} ~RandomRepl() {}
CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat, CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat);
int context_src);
CacheBlk* findVictim(Addr addr); CacheBlk* findVictim(Addr addr);
void insertBlock(PacketPtr pkt, BlkType *blk); void insertBlock(PacketPtr pkt, BlkType *blk);
void invalidate(CacheBlk *blk); void invalidate(CacheBlk *blk);