stats: remove duplicate instruction stats from the commit stage
these stats are duplicates of insts/opsCommitted, cause confusion, and are poorly named.
This commit is contained in:
parent
89a5ba1ef8
commit
c6927ed138
2 changed files with 6 additions and 22 deletions
|
@ -447,10 +447,6 @@ class DefaultCommit
|
||||||
/** Updates commit stats based on this instruction. */
|
/** Updates commit stats based on this instruction. */
|
||||||
void updateComInstStats(DynInstPtr &inst);
|
void updateComInstStats(DynInstPtr &inst);
|
||||||
|
|
||||||
/** Stat for the total number of committed instructions. */
|
|
||||||
Stats::Scalar commitCommittedInsts;
|
|
||||||
/** Stat for the total number of committed ops. */
|
|
||||||
Stats::Scalar commitCommittedOps;
|
|
||||||
/** Stat for the total number of squashed instructions discarded by commit.
|
/** Stat for the total number of squashed instructions discarded by commit.
|
||||||
*/
|
*/
|
||||||
Stats::Scalar commitSquashedInsts;
|
Stats::Scalar commitSquashedInsts;
|
||||||
|
|
|
@ -161,14 +161,6 @@ void
|
||||||
DefaultCommit<Impl>::regStats()
|
DefaultCommit<Impl>::regStats()
|
||||||
{
|
{
|
||||||
using namespace Stats;
|
using namespace Stats;
|
||||||
commitCommittedInsts
|
|
||||||
.name(name() + ".commitCommittedInsts")
|
|
||||||
.desc("The number of committed instructions")
|
|
||||||
.prereq(commitCommittedInsts);
|
|
||||||
commitCommittedOps
|
|
||||||
.name(name() + ".commitCommittedOps")
|
|
||||||
.desc("The number of committed instructions")
|
|
||||||
.prereq(commitCommittedInsts);
|
|
||||||
commitSquashedInsts
|
commitSquashedInsts
|
||||||
.name(name() + ".commitSquashedInsts")
|
.name(name() + ".commitSquashedInsts")
|
||||||
.desc("The number of squashed insts skipped by commit")
|
.desc("The number of squashed insts skipped by commit")
|
||||||
|
@ -998,16 +990,6 @@ DefaultCommit<Impl>::commitInsts()
|
||||||
// Set the doneSeqNum to the youngest committed instruction.
|
// Set the doneSeqNum to the youngest committed instruction.
|
||||||
toIEW->commitInfo[tid].doneSeqNum = head_inst->seqNum;
|
toIEW->commitInfo[tid].doneSeqNum = head_inst->seqNum;
|
||||||
|
|
||||||
if (!head_inst->isMicroop() || head_inst->isLastMicroop())
|
|
||||||
++commitCommittedInsts;
|
|
||||||
++commitCommittedOps;
|
|
||||||
|
|
||||||
// To match the old model, don't count nops and instruction
|
|
||||||
// prefetches towards the total commit count.
|
|
||||||
if (!head_inst->isNop() && !head_inst->isInstPrefetch()) {
|
|
||||||
cpu->instDone(tid, head_inst);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (tid == 0) {
|
if (tid == 0) {
|
||||||
canHandleInterrupts = (!head_inst->isDelayedCommit()) &&
|
canHandleInterrupts = (!head_inst->isDelayedCommit()) &&
|
||||||
((THE_ISA != ALPHA_ISA) ||
|
((THE_ISA != ALPHA_ISA) ||
|
||||||
|
@ -1369,6 +1351,12 @@ DefaultCommit<Impl>::updateComInstStats(DynInstPtr &inst)
|
||||||
instsCommitted[tid]++;
|
instsCommitted[tid]++;
|
||||||
opsCommitted[tid]++;
|
opsCommitted[tid]++;
|
||||||
|
|
||||||
|
// To match the old model, don't count nops and instruction
|
||||||
|
// prefetches towards the total commit count.
|
||||||
|
if (!inst->isNop() && !inst->isInstPrefetch()) {
|
||||||
|
cpu->instDone(tid, inst);
|
||||||
|
}
|
||||||
|
|
||||||
//
|
//
|
||||||
// Control Instructions
|
// Control Instructions
|
||||||
//
|
//
|
||||||
|
|
Loading…
Reference in a new issue