sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

x86: fix table walker assertion

Browse source 
In a cycle, we could see a R and W requests corresponding to the same
page walk being sent to the memory. During the cycle that assertion
happens, we have 2 responses corresponding to the R and W above. We
also have a 'read' variable to keep track of the inflight Read
request, this gets reset to NULL right after we send out any R
request; and gets set to the next R in the page walk when a response
comes back.

The issue we are seeing here is when we get a response for W request,
assert(!read) fires because we got a response for R request right
before this, hence we set 'read' to NOT NULL value, pointing to the
next R request in the pagewalk!

This work was done while Binh was an intern at AMD Research.
This commit is contained in:
Binh Pham 2014-06-21 10:39:44 -07:00
parent b72c879868
commit b085db84af
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/arch/x86/pagetable_walker.cc
View file

@ -608,9 +608,11 @@ Walker::WalkerState::recvPacket(PacketPtr pkt)
assert(pkt->isResponse());
assert(inflight);
assert(state == Waiting);
assert(!read);
inflight--;
if (pkt->isRead()) {
// should not have a pending read it we also had one outstanding
assert(!read);
// @todo someone should pay for this
pkt->busFirstWordDelay = pkt->busLastWordDelay = 0;