sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mem: add boolean to disable PacketQueue's size sanity check

Browse source 
the sanity check, while generally useful for exposing memory system bugs,
may be spurious with respect to GPU workloads, which may generate many more
requests than typical CPU workloads. the large number of requests generated
by the GPU may cause the req/resp queues to back up, thus queueing more than
100 packets.
This commit is contained in:
Brad Beckmann 2015-07-20 09:15:18 -05:00
parent 7678ddeb46
commit aef8d851bd
2 changed files with 24 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/mem/packet_queue.cc
View file

@ -48,9 +48,10 @@
using namespace std;
PacketQueue::PacketQueue(EventManager& _em, const std::string& _label)
: em(_em), sendEvent(this), label(_label),
waitingOnRetry(false)
PacketQueue::PacketQueue(EventManager& _em, const std::string& _label,
bool disable_sanity_check)
: em(_em), sendEvent(this), _disableSanityCheck(disable_sanity_check),
label(_label), waitingOnRetry(false)
{
}
@ -114,7 +115,7 @@ PacketQueue::schedSendTiming(PacketPtr pkt, Tick when, bool force_order)
// add a very basic sanity check on the port to ensure the
// invisible buffer is not growing beyond reasonable limits
if (transmitList.size() > 100) {
if (!_disableSanityCheck && transmitList.size() > 100) {
panic("Packet queue %s has grown beyond 100 packets\n",
name());
}

20
src/mem/packet_queue.hh
View file

@ -89,6 +89,13 @@ class PacketQueue : public Drainable
/** Event used to call processSendEvent. */
EventWrapper<PacketQueue, &PacketQueue::processSendEvent> sendEvent;
/*
* Optionally disable the sanity check
* on the size of the transmitList. The
* sanity check will be enabled by default.
*/
bool _disableSanityCheck;
protected:
/** Label to use for print request packets label stack. */
@ -123,8 +130,11 @@ class PacketQueue : public Drainable
*
* @param _em Event manager used for scheduling this queue
* @param _label Label to push on the label stack for print request packets
* @param disable_sanity_check Flag used to disable the sanity check
* on the size of the transmitList. The check is enabled by default.
*/
PacketQueue(EventManager& _em, const std::string& _label);
PacketQueue(EventManager& _em, const std::string& _label,
bool disable_sanity_check = false);
/**
* Virtual desctructor since the class may be used as a base class.
@ -187,6 +197,14 @@ class PacketQueue : public Drainable
*/
void retry();
/**
* This allows a user to explicitly disable the sanity check
* on the size of the transmitList, which is enabled by default.
* Users must use this function to explicitly disable the sanity
* check.
*/
void disableSanityCheck() { _disableSanityCheck = true; }
DrainState drain() override;
};