cpu: remove conditional check (count > 0) on o3 IQ squashes
The o3 cpu instruction queue model uses the count variable to track the number of unissued instructions in the queue. Previously, the squash method used this variable to avoid executing the doSquash method when there were no unissued instructions in the pipeline. A corner case problem exists when only issued instructions exist in the pipeline and a squash occurs; the doSquash code is not invoked and subsequently does not clean up state properly.
This commit is contained in:
parent
4991c29965
commit
a70a83155b
1 changed files with 1 additions and 4 deletions
|
@ -1164,10 +1164,7 @@ InstructionQueue<Impl>::squash(ThreadID tid)
|
|||
// time buffer.
|
||||
squashedSeqNum[tid] = fromCommit->commitInfo[tid].doneSeqNum;
|
||||
|
||||
// Call doSquash if there are insts in the IQ
|
||||
if (count[tid] > 0) {
|
||||
doSquash(tid);
|
||||
}
|
||||
doSquash(tid);
|
||||
|
||||
// Also tell the memory dependence unit to squash.
|
||||
memDepUnit[tid].squash(squashedSeqNum[tid], tid);
|
||||
|
|
Loading…
Reference in a new issue