sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mem: Fix DRAM activationlLimit bug

Browse source 
Ensure that we do the proper event scheduling also when the activation
limit is disabled.
This commit is contained in:
Omar Naji 2014-10-20 18:03:55 -04:00
parent 77f8f5d94c
commit a4a8568bd2
1 changed files with 24 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/mem/dram_ctrl.cc
View file

@ -917,15 +917,15 @@ DRAMCtrl::activateBank(Bank& bank, Tick act_tick, uint32_t row)
}
// next, we deal with tXAW, if the activation limit is disabled
// then we are done
if (actTicks[rank].empty())
return;
// then we directly schedule an activate power event
if (!actTicks[rank].empty()) {
// sanity check
if (actTicks[rank].back() && (act_tick - actTicks[rank].back()) < tXAW) {
panic("Got %d activates in window %d (%llu - %llu) which is smaller "
"than %llu\n", activationLimit, act_tick - actTicks[rank].back(),
act_tick, actTicks[rank].back(), tXAW);
if (actTicks[rank].back() &&
(act_tick - actTicks[rank].back()) < tXAW) {
panic("Got %d activates in window %d (%llu - %llu) which "
"is smaller than %llu\n", activationLimit, act_tick -
actTicks[rank].back(), act_tick, actTicks[rank].back(),
tXAW);
}
// shift the times used for the book keeping, the last element
@ -938,15 +938,18 @@ DRAMCtrl::activateBank(Bank& bank, Tick act_tick, uint32_t row)
// cannot activate more than X times in time window tXAW, push the
// next one (the X + 1'st activate) to be tXAW away from the
// oldest in our window of X
if (actTicks[rank].back() && (act_tick - actTicks[rank].back()) < tXAW) {
DPRINTF(DRAM, "Enforcing tXAW with X = %d, next activate no earlier "
"than %llu\n", activationLimit, actTicks[rank].back() + tXAW);
if (actTicks[rank].back() &&
(act_tick - actTicks[rank].back()) < tXAW) {
DPRINTF(DRAM, "Enforcing tXAW with X = %d, next activate "
"no earlier than %llu\n", activationLimit,
actTicks[rank].back() + tXAW);
for(int j = 0; j < banksPerRank; j++)
// next activate must not happen before end of window
banks[rank][j].actAllowedAt =
std::max(actTicks[rank].back() + tXAW,
banks[rank][j].actAllowedAt);
}
}
// at the point when this activate takes place, make sure we
// transition to the active power state