IGbE: Some fixes to the intel nic model.

--HG--
extra : convert_revision : 1c1275a9fb99966398b3add09da04bd53399ed2b

src/dev/i8254xGBe.cc

@@ -57,7 +57,7 @@ using namespace Net;
 IGbE::IGbE(const Params *p)
     : EtherDevice(p), etherInt(NULL),  drainEvent(NULL), useFlowControl(p->use_flow_control),
       rxFifo(p->rx_fifo_size), txFifo(p->tx_fifo_size), rxTick(false),
-      txTick(false), txFifoTick(false), rdtrEvent(this), radvEvent(this),
+      txTick(false), txFifoTick(false), rxDmaPacket(false), rdtrEvent(this), radvEvent(this),
       tadvEvent(this), tidvEvent(this), tickEvent(this), interEvent(this),
       rxDescCache(this, name()+".RxDesc", p->rx_desc_cache_size),
       txDescCache(this, name()+".TxDesc", p->tx_desc_cache_size), clock(p->clock)
@@ -113,7 +113,7 @@ EtherInt*
 IGbE::getEthPort(const std::string &if_name, int idx)
 {
 
-    if (if_name == "interface" && !etherInt) {
+    if (if_name == "interface") {
         if (etherInt->getPeer())
             panic("Port already connected to\n");
         return etherInt;
@@ -504,8 +504,13 @@ IGbE::write(PacketPtr pkt)
         break;
       case REG_RDT:
         regs.rdt = val;
-        rxTick = true;
+        DPRINTF(EthernetSM, "RXS: RDT Updated.\n");
-        restartClock();
+        if (getState() == SimObject::Running) {
+            DPRINTF(EthernetSM, "RXS: RDT Fetching Descriptors!\n");
+            rxDescCache.fetchDescriptors();
+        } else {
+            DPRINTF(EthernetSM, "RXS: RDT NOT Fetching Desc b/c draining!\n");
+        }
         break;
       case REG_RDTR:
         regs.rdtr = val;
@@ -531,8 +536,13 @@ IGbE::write(PacketPtr pkt)
         break;
       case REG_TDT:
         regs.tdt = val;
-        txTick = true;
+        DPRINTF(EthernetSM, "TXS: TX Tail pointer updated\n");
-        restartClock();
+        if (getState() == SimObject::Running) {
+            DPRINTF(EthernetSM, "TXS: TDT Fetching Descriptors!\n");
+            txDescCache.fetchDescriptors();
+        } else {
+            DPRINTF(EthernetSM, "TXS: TDT NOT Fetching Desc b/c draining!\n");
+        }
         break;
       case REG_TIDV:
         regs.tidv = val;
@@ -566,33 +576,47 @@ IGbE::postInterrupt(IntTypes t, bool now)
     assert(t);
 
     // Interrupt is already pending
-    if (t & regs.icr())
+    if (t & regs.icr() && !now)
         return;
 
-    if (regs.icr() & regs.imr)
+    regs.icr = regs.icr() | t;
-    {
+    if (regs.itr.interval() == 0 || now) {
-        regs.icr = regs.icr() | t;
+        if (interEvent.scheduled()) {
-        if (!interEvent.scheduled())
+            interEvent.deschedule();
-            interEvent.schedule(curTick + Clock::Int::ns * 256 *
-                    regs.itr.interval());
-    } else {
-        regs.icr = regs.icr() | t;
-        if (regs.itr.interval() == 0 || now) {
-            if (interEvent.scheduled())
-                interEvent.deschedule();
-            cpuPostInt();
-        } else {
-           DPRINTF(EthernetIntr, "EINT: Scheduling timer interrupt for %d ticks\n",
-                    Clock::Int::ns * 256 * regs.itr.interval());
-           if (!interEvent.scheduled())
-               interEvent.schedule(curTick + Clock::Int::ns * 256 * regs.itr.interval());
         }
+        cpuPostInt();
+    } else {
+       DPRINTF(EthernetIntr, "EINT: Scheduling timer interrupt for %d ticks\n",
+                Clock::Int::ns * 256 * regs.itr.interval());
+       if (!interEvent.scheduled()) {
+           interEvent.schedule(curTick + Clock::Int::ns * 256 * regs.itr.interval());
+       }
     }
 }
 
+void
+IGbE::delayIntEvent()
+{
+    cpuPostInt();
+}
+
+
 void
 IGbE::cpuPostInt()
 {
+
+    if (!(regs.icr() & regs.imr)) {
+        DPRINTF(Ethernet, "Interrupt Masked. Not Posting\n");
+        return;
+    }
+
+    DPRINTF(Ethernet, "Posting Interrupt\n");
+
+
+    if (interEvent.scheduled()) {
+        interEvent.deschedule();
+    }
+
     if (rdtrEvent.scheduled()) {
         regs.icr.rxt0(1);
         rdtrEvent.deschedule();
@@ -613,7 +637,9 @@ IGbE::cpuPostInt()
     regs.icr.int_assert(1);
     DPRINTF(EthernetIntr, "EINT: Posting interrupt to CPU now. Vector %#x\n",
             regs.icr());
+
     intrPost();
+
 }
 
 void
@@ -630,20 +656,28 @@ IGbE::cpuClearInt()
 void
 IGbE::chkInterrupt()
 {
+    DPRINTF(Ethernet, "Checking interrupts icr: %#x imr: %#x\n", regs.icr(),
+            regs.imr);
     // Check if we need to clear the cpu interrupt
     if (!(regs.icr() & regs.imr)) {
+        DPRINTF(Ethernet, "Mask cleaned all interrupts\n");
         if (interEvent.scheduled())
            interEvent.deschedule();
         if (regs.icr.int_assert())
             cpuClearInt();
     }
+    DPRINTF(Ethernet, "ITR = %#X itr.interval = %#X\n", regs.itr(), regs.itr.interval());
 
     if (regs.icr() & regs.imr) {
         if (regs.itr.interval() == 0)  {
             cpuPostInt();
         } else {
-            if (!interEvent.scheduled())
+            DPRINTF(Ethernet, "Possibly scheduling interrupt because of imr write\n");
+            if (!interEvent.scheduled()) {
+               DPRINTF(Ethernet, "Scheduling for %d\n", curTick + Clock::Int::ns
+                       * 256 * regs.itr.interval());
                interEvent.schedule(curTick + Clock::Int::ns * 256 * regs.itr.interval());
+            }
         }
     }
 
@@ -682,6 +716,7 @@ IGbE::RxDescCache::pktComplete()
     RxDesc *desc;
     desc = unusedCache.front();
 
+
     uint16_t crcfixup = igbe->regs.rctl.secrc() ? 0 : 4 ;
     desc->len = htole((uint16_t)(pktPtr->length + crcfixup));
     DPRINTF(EthernetDesc, "pktPtr->length: %d stripcrc offset: %d value written: %d %d\n",
@@ -754,9 +789,10 @@ IGbE::RxDescCache::pktComplete()
     if (igbe->regs.radv.idv() && igbe->regs.rdtr.delay()) {
         DPRINTF(EthernetSM, "RXS: Scheduling ADV for %d\n",
                 igbe->regs.radv.idv() * igbe->intClock());
-        if (!igbe->radvEvent.scheduled())
+        if (!igbe->radvEvent.scheduled()) {
             igbe->radvEvent.schedule(curTick + igbe->regs.radv.idv() *
                     igbe->intClock());
+        }
     }
 
     // if neither radv or rdtr, maybe itr is set...
@@ -775,10 +811,13 @@ IGbE::RxDescCache::pktComplete()
     DPRINTF(EthernetDesc, "Processing of this descriptor complete\n");
     unusedCache.pop_front();
     usedCache.push_back(desc);
+
+
     pktPtr = NULL;
     enableSm();
     pktDone = true;
     igbe->checkDrain();
+
 }
 
 void
@@ -843,11 +882,13 @@ IGbE::TxDescCache::getPacketSize()
 
         // I think we can just ignore these for now?
         desc = unusedCache.front();
+        DPRINTF(EthernetDesc, "Descriptor upper: %#x lower: %#X\n", desc->d1,
+                desc->d2);
         // is this going to be a tcp or udp packet?
         isTcp = TxdOp::tcp(desc) ? true : false;
 
         // make sure it's ipv4
-        assert(TxdOp::ip(desc));
+        //assert(TxdOp::ip(desc));
 
         TxdOp::setDd(desc);
         unusedCache.pop_front();
@@ -894,7 +935,6 @@ IGbE::TxDescCache::pktComplete()
 
     DPRINTF(EthernetDesc, "DMA of packet complete\n");
 
-
     desc = unusedCache.front();
     assert((TxdOp::isLegacy(desc) || TxdOp::isData(desc)) && TxdOp::getLen(desc));
 
@@ -951,20 +991,21 @@ IGbE::TxDescCache::pktComplete()
             ip->sum(cksum(ip));
             DPRINTF(EthernetDesc, "Calculated IP checksum\n");
         }
-       if (TxdOp::txsm(desc)) {
+        if (TxdOp::txsm(desc)) {
-           if (isTcp) {
+            TcpPtr tcp(ip);
-                TcpPtr tcp(ip);
+            UdpPtr udp(ip);
-                assert(tcp);
+            if (tcp) {
-                tcp->sum(0);
+                 tcp->sum(0);
-                tcp->sum(cksum(tcp));
+                 tcp->sum(cksum(tcp));
-                DPRINTF(EthernetDesc, "Calculated TCP checksum\n");
+                 DPRINTF(EthernetDesc, "Calculated TCP checksum\n");
-           } else {
+            } else if (udp) {
-                UdpPtr udp(ip);
+                 assert(udp);
-                assert(udp);
+                 udp->sum(0);
-                udp->sum(0);
+                 udp->sum(cksum(udp));
-                udp->sum(cksum(udp));
+                 DPRINTF(EthernetDesc, "Calculated UDP checksum\n");
-                DPRINTF(EthernetDesc, "Calculated UDP checksum\n");
+            } else {
-           }
+                panic("Told to checksum, but don't know how\n");
+            }
         }
     }
 
@@ -979,9 +1020,10 @@ IGbE::TxDescCache::pktComplete()
 
         if (igbe->regs.tadv.idv() && igbe->regs.tidv.idv()) {
             DPRINTF(EthernetDesc, "setting tadv\n");
-            if (!igbe->tadvEvent.scheduled())
+            if (!igbe->tadvEvent.scheduled()) {
                 igbe->tadvEvent.schedule(curTick + igbe->regs.tadv.idv() *
                         igbe->intClock());
+            }
         }
     }
 
@@ -1103,8 +1145,11 @@ IGbE::checkDrain()
     if (!drainEvent)
         return;
 
-    if (rxDescCache.hasOutstandingEvents() ||
+    txFifoTick = false;
-            txDescCache.hasOutstandingEvents()) {
+    txTick = false;
+    rxTick = false;
+    if (!rxDescCache.hasOutstandingEvents() &&
+            !txDescCache.hasOutstandingEvents()) {
         drainEvent->process();
         drainEvent = NULL;
     }
@@ -1124,6 +1169,7 @@ IGbE::txStateMachine()
     // iteration we'll get the rest of the data
     if (txPacket && txDescCache.packetAvailable() && txPacket->length) {
         bool success;
+
         DPRINTF(EthernetSM, "TXS: packet placed in TX FIFO\n");
         success = txFifo.push(txPacket);
         txFifoTick = true;
@@ -1146,11 +1192,12 @@ IGbE::txStateMachine()
 
     if (!txDescCache.packetWaiting()) {
         if (txDescCache.descLeft() == 0) {
+            postInterrupt(IT_TXQE);
+            txDescCache.writeback(0);
             DPRINTF(EthernetSM, "TXS: No descriptors left in ring, forcing "
                     "writeback stopping ticking and posting TXQE\n");
-            txDescCache.writeback(0);
+            txDescCache.fetchDescriptors();
             txTick = false;
-            postInterrupt(IT_TXQE, true);
             return;
         }
 
@@ -1170,12 +1217,13 @@ IGbE::txStateMachine()
             txFifo.reserve(size);
             txDescCache.getPacketData(txPacket);
         } else if (size <= 0) {
+            DPRINTF(EthernetSM, "TXS: getPacketSize returned: %d\n", size);
             DPRINTF(EthernetSM, "TXS: No packets to get, writing back used descriptors\n");
             txDescCache.writeback(0);
         } else {
+            txDescCache.writeback((cacheBlockSize()-1)>>4);
             DPRINTF(EthernetSM, "TXS: FIFO full, stopping ticking until space "
                     "available in FIFO\n");
-            txDescCache.writeback((cacheBlockSize()-1)>>4);
             txTick = false;
         }
 
@@ -1190,6 +1238,7 @@ bool
 IGbE::ethRxPkt(EthPacketPtr pkt)
 {
     DPRINTF(Ethernet, "RxFIFO: Receiving pcakte from wire\n");
+
     if (!regs.rctl.en()) {
         DPRINTF(Ethernet, "RxFIFO: RX not enabled, dropping\n");
         return true;
@@ -1235,8 +1284,6 @@ IGbE::rxStateMachine()
         }
 
         if (descLeft == 0) {
-            DPRINTF(EthernetSM, "RXS: No descriptors left in ring, forcing"
-                    " writeback and stopping ticking\n");
             rxDescCache.writeback(0);
             rxTick = false;
         }
@@ -1310,16 +1357,26 @@ IGbE::txWire()
         return;
     }
 
+    if (etherInt->askBusy()) {
+        // We'll get woken up when the packet ethTxDone() gets called
+        txFifoTick = false;
+    } else {
+        if (DTRACE(EthernetSM)) {
+            IpPtr ip(txFifo.front());
+            if (ip)
+                DPRINTF(EthernetSM, "Transmitting Ip packet with Id=%d\n",
+                        ip->id());
+            else
+                DPRINTF(EthernetSM, "Transmitting Non-Ip packet\n");
+        }
 
-    if (etherInt->sendPacket(txFifo.front())) {
+        bool r = etherInt->sendPacket(txFifo.front());
+        assert(r);
+        r += 1;
         DPRINTF(EthernetSM, "TxFIFO: Successful transmit, bytes available in fifo: %d\n",
                 txFifo.avail());
         txFifo.pop();
-    } else {
-        // We'll get woken up when the packet ethTxDone() gets called
-        txFifoTick = false;
     }
-
 }
 
 void
@@ -1348,7 +1405,8 @@ IGbE::ethTxDone()
     // fifo to send another packet
     // tx sm to put more data into the fifo
     txFifoTick = true;
-    txTick = true;
+    if (txDescCache.descLeft() != 0)
+        txTick = true;
 
     restartClock();
     DPRINTF(EthernetSM, "TxFIFO: Transmission complete\n");
@@ -1387,15 +1445,15 @@ IGbE::serialize(std::ostream &os)
     SERIALIZE_SCALAR(radv_time);
 
     if (tidvEvent.scheduled())
-       rdtr_time = tidvEvent.when();
+       tidv_time = tidvEvent.when();
     SERIALIZE_SCALAR(tidv_time);
 
     if (tadvEvent.scheduled())
-       rdtr_time = tadvEvent.when();
+       tadv_time = tadvEvent.when();
     SERIALIZE_SCALAR(tadv_time);
 
     if (interEvent.scheduled())
-       rdtr_time = interEvent.when();
+       inter_time = interEvent.when();
     SERIALIZE_SCALAR(inter_time);
 
     nameOut(os, csprintf("%s.TxDescCache", name()));

src/dev/i8254xGBe.hh

@@ -147,9 +147,10 @@ class IGbE : public EtherDevice
 
     /** Send an interrupt to the cpu
      */
+    void delayIntEvent();
     void cpuPostInt();
     // Event to moderate interrupts
-    EventWrapper<IGbE, &IGbE::cpuPostInt> interEvent;
+    EventWrapper<IGbE, &IGbE::delayIntEvent> interEvent;
 
     /** Clear the interupt line to the cpu
      */
@@ -177,6 +178,7 @@ class IGbE : public EtherDevice
         virtual void updateHead(long h) = 0;
         virtual void enableSm() = 0;
         virtual void intAfterWb() const {}
+        virtual void fetchAfterWb() = 0;
 
         std::deque<T*> usedCache;
         std::deque<T*> unusedCache;
@@ -283,12 +285,6 @@ class IGbE : public EtherDevice
             for (int x = 0; x < wbOut; x++)
                 memcpy(&wbBuf[x], usedCache[x], sizeof(T));
 
-            for (int x = 0; x < wbOut; x++) {
-                assert(usedCache.size());
-                delete usedCache[0];
-                usedCache.pop_front();
-            };
-
 
             assert(wbOut);
             igbe->dmaWrite(igbe->platform->pciToDma(descBase() + curHead * sizeof(T)),
@@ -307,7 +303,6 @@ class IGbE : public EtherDevice
             else
                 max_to_fetch = descLen() - cachePnt;
 
-
             max_to_fetch = std::min(max_to_fetch, (size - usedCache.size() -
                         unusedCache.size()));
 
@@ -369,10 +364,16 @@ class IGbE : public EtherDevice
          */
         void wbComplete()
         {
+
             long  curHead = descHead();
 #ifndef NDEBUG
             long oldHead = curHead;
 #endif
+            for (int x = 0; x < wbOut; x++) {
+                assert(usedCache.size());
+                delete usedCache[0];
+                usedCache.pop_front();
+            };
 
             curHead += wbOut;
             wbOut = 0;
@@ -387,12 +388,17 @@ class IGbE : public EtherDevice
                     oldHead, curHead);
 
             // If we still have more to wb, call wb now
+            bool oldMoreToWb = moreToWb;
             if (moreToWb) {
                 DPRINTF(EthernetDesc, "Writeback has more todo\n");
                 writeback(wbAlignment);
             }
+
             intAfterWb();
-            igbe->checkDrain();
+            if (!oldMoreToWb) {
+                igbe->checkDrain();
+            }
+            fetchAfterWb();
         }
 
 
@@ -502,6 +508,10 @@ class IGbE : public EtherDevice
         virtual long descTail() const { return igbe->regs.rdt(); }
         virtual void updateHead(long h) { igbe->regs.rdh(h); }
         virtual void enableSm();
+        virtual void fetchAfterWb() {
+            if (!igbe->rxTick && igbe->getState() == SimObject::Running)
+                fetchDescriptors();
+        }
 
         bool pktDone;
 
@@ -544,7 +554,13 @@ class IGbE : public EtherDevice
         virtual long descLen() const { return igbe->regs.tdlen() >> 4; }
         virtual void updateHead(long h) { igbe->regs.tdh(h); }
         virtual void enableSm();
-        virtual void intAfterWb() const { igbe->postInterrupt(iGbReg::IT_TXDW);}
+        virtual void intAfterWb() const {
+            igbe->postInterrupt(iGbReg::IT_TXDW);
+        }
+        virtual void fetchAfterWb() {
+            if (!igbe->txTick && igbe->getState() == SimObject::Running)
+                fetchDescriptors();
+        }
 
         bool pktDone;
         bool isTcp;