sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Ruby: Simplify tester ports by not using SimpleTimingPort

Browse source 
This patch simplfies the master ports used by RubyDirectedTester and
RubyTester by avoiding the use of SimpleTimingPort. Neither tester
made any use of the functionality offered by SimpleTimingPort besides
a trivial implementation of recvFunctional (only snoops) and
recvRangeChange (not relevant since there is only one master).

The patch does not change or add any functionality, it merely makes
the introduction of a master/slave port easier (in a future patch).
This commit is contained in:
Andreas Hansson 2012-02-24 11:48:48 -05:00
parent 485d103255
commit 86c2aad482
2 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/cpu/testers/directedtest/RubyDirectedTester.hh
View file

@ -47,14 +47,15 @@ class DirectedGenerator;
class RubyDirectedTester : public MemObject
{
public:
class CpuPort : public SimpleTimingPort
class CpuPort : public Port
{
private:
RubyDirectedTester *tester;
public:
CpuPort(const std::string &_name, RubyDirectedTester *_tester, uint32_t _idx)
: SimpleTimingPort(_name, _tester), tester(_tester), idx(_idx)
CpuPort(const std::string &_name, RubyDirectedTester *_tester,
uint32_t _idx)
: Port(_name, _tester), tester(_tester), idx(_idx)
{}
uint32_t idx;
@ -62,6 +63,8 @@ class RubyDirectedTester : public MemObject
protected:
virtual bool recvTiming(PacketPtr pkt);
virtual Tick recvAtomic(PacketPtr pkt);
virtual void recvFunctional(PacketPtr pkt) { }
virtual void recvRangeChange() { }
};
typedef RubyDirectedTesterParams Params;

6
src/cpu/testers/rubytest/RubyTester.hh
View file

@ -45,14 +45,14 @@
class RubyTester : public MemObject
{
public:
class CpuPort : public SimpleTimingPort
class CpuPort : public Port
{
private:
RubyTester *tester;
public:
CpuPort(const std::string &_name, RubyTester *_tester, int _idx)
: SimpleTimingPort(_name, _tester), tester(_tester), idx(_idx)
: Port(_name, _tester), tester(_tester), idx(_idx)
{}
int idx;
@ -60,6 +60,8 @@ class RubyTester : public MemObject
protected:
virtual bool recvTiming(PacketPtr pkt);
virtual Tick recvAtomic(PacketPtr pkt);
virtual void recvFunctional(PacketPtr pkt) { }
virtual void recvRangeChange() { }
};
struct SenderState : public Packet::SenderState