sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

dev: Fix infinite recursion in DMA devices

Browse source 
The DMA device sometimes calls the process() method on a completion
event directly instead of scheduling it on the current tick. This
breaks some devices that assume that the completion handler won't be
called until the current event handler has returned. Specifically, it
causes infinite recursion in the IdeDisk component because it does not
advance its chunk generator until after a dmaRead()/dmaWrite() has
returned. This changeset removes this mico-optimization and schedules
the event in the current tick instead. This way the semantics event
handling stay the same even when the delay is 0.
This commit is contained in:
Andreas Sandberg 2013-01-07 16:56:39 -05:00
parent 35be32b7ea
commit 8480615d8d
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/dev/dma_device.cc
View file

@ -85,10 +85,7 @@ DmaPort::handleResp(PacketPtr pkt, Tick delay)
if (state->totBytes == state->numBytes) {
if (state->completionEvent) {
delay += state->delay;
if (delay)
device->schedule(state->completionEvent, curTick() + delay);
else
state->completionEvent->process();
device->schedule(state->completionEvent, curTick() + delay);
}
delete state;
}