sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

cpu: fix case with o3 cpu blocking and unblocking decode in cycle

Browse source 
Fix a case in the O3 CPU where the decode stage blocks and unblocks in a
single cycle sending both signals to fetch which causes an assert or worse.
The previous check could never work before since the status was set to Blocked
before a test for the status being Unblocking was executed.
This commit is contained in:
Ali Saidi 2013-02-15 17:40:08 -05:00
parent b84bd3028c
commit 7ae06a3b3b
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/cpu/o3/decode_impl.hh
View file

@ -241,7 +241,9 @@ DefaultDecode<Impl>::block(ThreadID tid)
// Set the status to Blocked. // Set the status to Blocked.
decodeStatus[tid] = Blocked; decodeStatus[tid] = Blocked;
if (decodeStatus[tid] != Unblocking) { if (toFetch->decodeUnblock[tid]) {
toFetch->decodeUnblock[tid] = false;
} else {
toFetch->decodeBlock[tid] = true; toFetch->decodeBlock[tid] = true;
wroteToTimeBuffer = true; wroteToTimeBuffer = true;
} }