sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Properly chack the pkt pointer on upgrades to insure no segfaults when writebacks delete the packet.

Browse source 
--HG--
extra : convert_revision : 72b1c6296a16319f4d16c62bc7038365654dbc40
This commit is contained in:
Ron Dreslinski 2006-10-17 15:07:40 -04:00
parent 288b98eb69
commit 6e8bfa4e63
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/mem/cache/cache_impl.hh vendored
View file

@ -272,10 +272,11 @@ template<class TagStore, class Buffering, class Coherence>
void void
Cache<TagStore,Buffering,Coherence>::sendResult(PacketPtr &pkt, MSHR* mshr, bool success) Cache<TagStore,Buffering,Coherence>::sendResult(PacketPtr &pkt, MSHR* mshr, bool success)
{ {
if (success && !(pkt->flags & NACKED_LINE)) { if (success && !(pkt && (pkt->flags & NACKED_LINE))) {
missQueue->markInService(mshr->pkt, mshr); missQueue->markInService(mshr->pkt, mshr);
//Temp Hack for UPGRADES //Temp Hack for UPGRADES
if (mshr->pkt->cmd == Packet::UpgradeReq) { if (mshr->pkt->cmd == Packet::UpgradeReq) {
assert(pkt); //Upgrades need to be fixed
pkt->flags &= ~CACHE_LINE_FILL; pkt->flags &= ~CACHE_LINE_FILL;
BlkType *blk = tags->findBlock(pkt); BlkType *blk = tags->findBlock(pkt);
CacheBlk::State old_state = (blk) ? blk->status : 0; CacheBlk::State old_state = (blk) ? blk->status : 0;