sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ruby: improved isReadWrite fix me comment

Browse source
This commit is contained in:
Brad Beckmann 2010-03-22 11:19:17 -07:00
parent 7aba8d7db0
commit 66632539b6
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/mem/ruby/system/RubyPort.cc
View file

@ -230,8 +230,10 @@ RubyPort::M5Port::recvTiming(PacketPtr pkt)
type = RubyRequestType_ST;
} else if (pkt->isReadWrite()) {
//
// Fix me. Just because the packet is a read/write request does not
// necessary mean it is a read-modify-write atomic operation.
// Fix me. This conditional will never be executed because
// isReadWrite() is just an OR of isRead() and isWrite().
// Furthermore, just because the packet is a read/write request does
// not necessary mean it is a read-modify-write atomic operation.
//
type = RubyRequestType_RMW_Write;
} else {