sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

arm: Get rid of pointless have_generic_timer param

Browse source 
The ArmSystem class has a parameter to indicate whether it is
configured to use the generic timer extension or not. This parameter
doesn't affect any feature flags in the current implementation and is
therefore completely unnecessary. In fact, we usually don't set it
even if a system has a generic timer. If we ever need to check if
there is a generic timer present, we should just request a pointer and
check if it is non-null instead.
This commit is contained in:
Andreas Sandberg 2015-05-23 13:46:54 +01:00
parent 2278fec1d1
commit 6533f2000b
3 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/arch/arm/ArmSystem.py
View file

@ -58,8 +58,6 @@ class ArmSystem(System):
have_virtualization = Param.Bool(False, have_virtualization = Param.Bool(False,
"True if Virtualization Extensions are implemented") "True if Virtualization Extensions are implemented")
have_lpae = Param.Bool(False, "True if LPAE is implemented") have_lpae = Param.Bool(False, "True if LPAE is implemented")
have_generic_timer = Param.Bool(False,
"True if the Generic Timer extension is implemented")
highest_el_is_64 = Param.Bool(False, highest_el_is_64 = Param.Bool(False,
"True if the register width of the highest implemented exception level " "True if the register width of the highest implemented exception level "
"is 64 bits (ARMv8)") "is 64 bits (ARMv8)")

1
src/arch/arm/system.cc
View file

@ -57,7 +57,6 @@ ArmSystem::ArmSystem(Params *p)
: System(p), bootldr(NULL), _haveSecurity(p->have_security), : System(p), bootldr(NULL), _haveSecurity(p->have_security),
_haveLPAE(p->have_lpae), _haveLPAE(p->have_lpae),
_haveVirtualization(p->have_virtualization), _haveVirtualization(p->have_virtualization),
_haveGenericTimer(p->have_generic_timer),
_genericTimer(nullptr), _genericTimer(nullptr),
_highestELIs64(p->highest_el_is_64), _highestELIs64(p->highest_el_is_64),
_resetAddr64(p->reset_addr_64), _resetAddr64(p->reset_addr_64),

8
src/arch/arm/system.hh
View file

@ -84,11 +84,6 @@ class ArmSystem : public System
*/ */
const bool _haveVirtualization; const bool _haveVirtualization;
/**
* True if this system implements the Generic Timer extension
*/
const bool _haveGenericTimer;
/** /**
* Pointer to the Generic Timer wrapper. * Pointer to the Generic Timer wrapper.
*/ */
@ -157,9 +152,6 @@ class ArmSystem : public System
*/ */
bool haveVirtualization() const { return _haveVirtualization; } bool haveVirtualization() const { return _haveVirtualization; }
/** Returns true if this system implements the Generic Timer extension. */
bool haveGenericTimer() const { return _haveGenericTimer; }
/** Sets the pointer to the Generic Timer. */ /** Sets the pointer to the Generic Timer. */
void setGenericTimer(GenericTimer *generic_timer) void setGenericTimer(GenericTimer *generic_timer)
{ {