sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ruby: Check all VNETs for injection in garnet NetworkInterface

Browse source 
The NetworkInterface wakeup currently iterates over all VNETs and breaks the
loop if a VNET is unable to allocate a VC. This can cause a deadlock if a
lower numbered VNET is unable to allocate a VC while a higher numbered VNET
has idle VCs. This seems like a bug as Garnet 1.0 uses a while loop over an
if-statement, suggesting the break was intended for this while loop. This
patch removes the break statement, which allows up to one message to be
dequeued from a VNET and injected into the network.
This commit is contained in:
Matthew Poremba 2017-01-19 11:58:49 -05:00
parent 1ced08c850
commit 501f170924
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/mem/ruby/network/garnet2.0/NetworkInterface.cc
View file

@ -159,8 +159,6 @@ NetworkInterface::wakeup()
msg_ptr = b->peekMsgPtr(); msg_ptr = b->peekMsgPtr();
if (flitisizeMessage(msg_ptr, vnet)) { if (flitisizeMessage(msg_ptr, vnet)) {
b->dequeue(curTime); b->dequeue(curTime);
} else {
break;
} }
} }
} }