O3: Handle loads when the destination is the PC.

For loads that PC is the destination, check if the load
was mispredicted again when the value being loaded returns from memory
This commit is contained in:
Min Kyu Jeong 2010-08-23 11:18:40 -05:00
parent 5f91ec3f46
commit 43c938d23e
4 changed files with 50 additions and 0 deletions

View file

@ -251,6 +251,9 @@ class DefaultIEW
bool ableToIssue; bool ableToIssue;
/** Check misprediction */
void checkMisprediction(DynInstPtr &inst);
private: private:
/** Sends commit proper information for a squash due to a branch /** Sends commit proper information for a squash due to a branch
* mispredict. * mispredict.

View file

@ -1,4 +1,16 @@
/* /*
* Copyright (c) 2010 ARM Limited
* All rights reserved.
*
* The license below extends only to copyright in the software and shall
* not be construed as granting a license to any other intellectual
* property including but not limited to intellectual property relating
* to a hardware implementation of the functionality of the software
* licensed hereunder. You may use the software subject to the license
* terms below provided that you ensure that this notice is replicated
* unmodified and in its entirety in all distributions of the software,
* modified or unmodified, in source code or in binary form.
*
* Copyright (c) 2004-2006 The Regents of The University of Michigan * Copyright (c) 2004-2006 The Regents of The University of Michigan
* All rights reserved. * All rights reserved.
* *
@ -1585,3 +1597,33 @@ DefaultIEW<Impl>::updateExeInstStats(DynInstPtr &inst)
} }
} }
} }
template <class Impl>
void
DefaultIEW<Impl>::checkMisprediction(DynInstPtr &inst)
{
ThreadID tid = inst->threadNumber;
if (!fetchRedirect[tid] ||
toCommit->squashedSeqNum[tid] > inst->seqNum) {
if (inst->mispredicted()) {
fetchRedirect[tid] = true;
DPRINTF(IEW, "Execute: Branch mispredict detected.\n");
DPRINTF(IEW, "Predicted target was PC:%#x, NPC:%#x.\n",
inst->readPredPC(), inst->readPredNPC());
DPRINTF(IEW, "Execute: Redirecting fetch to PC: %#x,"
" NPC: %#x.\n", inst->readNextPC(),
inst->readNextNPC());
// If incorrect, then signal the ROB that it must be squashed.
squashDueToBranch(inst, tid);
if (inst->readPredTaken()) {
predictedTakenIncorrect++;
} else {
predictedNotTakenIncorrect++;
}
}
}
}

View file

@ -530,6 +530,8 @@ LSQUnit<Impl>::read(Request *req, Request *sreqLow, Request *sreqHigh,
(load_idx != loadHead || !load_inst->isAtCommit())) { (load_idx != loadHead || !load_inst->isAtCommit())) {
iewStage->rescheduleMemInst(load_inst); iewStage->rescheduleMemInst(load_inst);
++lsqRescheduledLoads; ++lsqRescheduledLoads;
DPRINTF(LSQUnit, "Uncachable load [sn:%lli] PC %#x\n",
load_inst->seqNum, load_inst->readPC());
// Must delete request now that it wasn't handed off to // Must delete request now that it wasn't handed off to
// memory. This is quite ugly. @todo: Figure out the proper // memory. This is quite ugly. @todo: Figure out the proper

View file

@ -989,6 +989,9 @@ LSQUnit<Impl>::writeback(DynInstPtr &inst, PacketPtr pkt)
iewStage->instToCommit(inst); iewStage->instToCommit(inst);
iewStage->activityThisCycle(); iewStage->activityThisCycle();
// see if this load changed the PC
iewStage->checkMisprediction(inst);
} }
template <class Impl> template <class Impl>