From 3f2b039c98e57cdcd22376552d77603e6233c371 Mon Sep 17 00:00:00 2001
From: Ali Saidi <saidi@eecs.umich.edu>
Date: Tue, 1 May 2007 18:14:16 -0400
Subject: [PATCH] change the way dprintf works so the cache accesses required
 to fulfill the dprintf aren't show in between the Cycle: name: printing and
 the actual formatted string being printed

--HG--
extra : convert_revision : 8876ba938ba971f854bab490c9af10db039a2e83
---
 src/kern/linux/events.cc | 11 +++++------
 src/kern/linux/events.hh |  8 ++------
 src/kern/linux/printk.cc | 13 +++----------
 src/kern/linux/printk.hh |  4 +++-
 4 files changed, 13 insertions(+), 23 deletions(-)

diff --git a/src/kern/linux/events.cc b/src/kern/linux/events.cc
index 4a3fd9f47..42fa63a27 100644
--- a/src/kern/linux/events.cc
+++ b/src/kern/linux/events.cc
@@ -37,6 +37,7 @@
 #include "kern/system_events.hh"
 #include "sim/system.hh"
 
+#include <sstream>
 
 namespace Linux {
 
@@ -44,13 +45,11 @@ void
 DebugPrintkEvent::process(ThreadContext *tc)
 {
     if (DTRACE(DebugPrintf)) {
-        if (!raw) {
-            StringWrap name(tc->getSystemPtr()->name() + ".dprintk");
-            DPRINTFN("");
-        }
-
+        std::stringstream ss;
         TheISA::Arguments args(tc);
-        Printk(args);
+        Printk(ss, args);
+        StringWrap name(tc->getSystemPtr()->name() + ".dprintk");
+        DPRINTFN("%s", ss.str());
     }
     SkipFuncEvent::process(tc);
 }
diff --git a/src/kern/linux/events.hh b/src/kern/linux/events.hh
index b0510c18f..e36a72dde 100644
--- a/src/kern/linux/events.hh
+++ b/src/kern/linux/events.hh
@@ -38,13 +38,9 @@ namespace Linux {
 
 class DebugPrintkEvent : public SkipFuncEvent
 {
-  private:
-    bool raw;
-
   public:
-    DebugPrintkEvent(PCEventQueue *q, const std::string &desc, Addr addr,
-                     bool r = false)
-        : SkipFuncEvent(q, desc, addr), raw(r) {}
+    DebugPrintkEvent(PCEventQueue *q, const std::string &desc, Addr addr)
+        : SkipFuncEvent(q, desc, addr) {}
     virtual void process(ThreadContext *xc);
 };
 
diff --git a/src/kern/linux/printk.cc b/src/kern/linux/printk.cc
index 0e9fd6620..866353e31 100644
--- a/src/kern/linux/printk.cc
+++ b/src/kern/linux/printk.cc
@@ -32,22 +32,18 @@
 #include <sys/types.h>
 #include <algorithm>
 
-#include "base/trace.hh"
 #include "arch/arguments.hh"
+#include "base/trace.hh"
+#include "kern/linux/printk.hh"
 
 using namespace std;
 
 
 void
-Printk(TheISA::Arguments args)
+Printk(stringstream &out, TheISA::Arguments args)
 {
-    std::ostream &out = Trace::output();
     char *p = (char *)args++;
 
-    ios::fmtflags saved_flags = out.flags();
-    char old_fill = out.fill();
-    int old_precision = out.precision();
-
     while (*p) {
         switch (*p) {
           case '%': {
@@ -258,8 +254,5 @@ Printk(TheISA::Arguments args)
         }
     }
 
-    out.flags(saved_flags);
-    out.fill(old_fill);
-    out.precision(old_precision);
 }
 
diff --git a/src/kern/linux/printk.hh b/src/kern/linux/printk.hh
index 17d59b765..20dfb430f 100644
--- a/src/kern/linux/printk.hh
+++ b/src/kern/linux/printk.hh
@@ -34,8 +34,10 @@
 
 #include "arch/isa_specific.hh"
 
+#include <sstream>
+
 class TheISA::Arguments;
 
-void Printk(TheISA::Arguments args);
+void Printk(std::stringstream &out, TheISA::Arguments args);
 
 #endif // __PRINTK_HH__