sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

misc: Bugfix in TLM integration regarding CleanEvict Command

Browse source 
The CleanEvict command was not considered in /util/tlm/sc_port.cc this could
lead to a simulator crash. This issue is solved by ignoring this special
command type.

Committed by: Nilay Vaish <nilay@cs.wisc.edu>
This commit is contained in:
Abdul Mutaal Ahmad 2015-09-15 08:14:07 -05:00
parent 543efd5ca6
commit 1bb6a100ab
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
util/tlm/README
View file

@ -33,7 +33,7 @@ without python.
> cd ../.. > cd ../..
> scons build/ARM/gem5.opt > scons build/ARM/gem5.opt
> scons --with-cxx-config --without-python build/ARM/libgem5_opt.so > scons --with-cxx-config --without-python build/ARM/libgem5_opt.so
> cd util/systemc_tlm > cd util/tlm
Set a proper LD_LIBRARY_PATH e.g. for bash: Set a proper LD_LIBRARY_PATH e.g. for bash:
> export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/path/to/gem5/build/ARM/" > export LD_LIBRARY_PATH="$LD_LIBRARY_PATH:/path/to/gem5/build/ARM/"

6
util/tlm/sc_port.cc
View file

@ -30,6 +30,7 @@
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
* *
* Authors: Matthias Jung * Authors: Matthias Jung
* Abdul Mutaal Ahmad
*/ */
#include <cctype> #include <cctype>
@ -175,8 +176,9 @@ sc_transactor::recvTimingReq(PacketPtr packet)
* required */ * required */
sc_assert(!needToSendRequestRetry); sc_assert(!needToSendRequestRetry);
/* FIXME screw coherency traffic */ // simply drop inhibited packets and clean evictions
if (packet->memInhibitAsserted()) if (packet->memInhibitAsserted() ||
packet->cmd == MemCmd::CleanEvict)
return true; return true;
/* Remember if a request comes in while we're blocked so that a retry /* Remember if a request comes in while we're blocked so that a retry