sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

sim: Get rid of the non-const serialize() method

Browse source 
The last SimObject using the legacy serialize API with non-const
methods has now been transitioned to the new API. This changeset
removes the serializeOld() methods from the serialization base class
as they are no longer used.
This commit is contained in:
Andreas Sandberg 2015-12-04 09:48:48 +00:00
parent 5a249e03a4
commit 1a34e23603
3 changed files with 1 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/sim/serialize.cc
View file

@ -580,13 +580,6 @@ Serializable::serializeSection(CheckpointOut &cp, const char *name) const
serialize(cp);
}
void
Serializable::serializeSectionOld(CheckpointOut &cp, const char *name)
{
Serializable::ScopedCheckpointSection sec(cp, name);
serializeOld(cp);
}
void
Serializable::unserializeSection(CheckpointIn &cp, const char *name)
{

26
src/sim/serialize.hh
View file

@ -323,32 +323,6 @@ class Serializable
unserializeSection(cp, name.c_str());
}
/**
* @{
* @name Legacy interface
*
* Interface for objects that insist on changing their state when
* serializing. Such state change should be done in drain(),
* memWriteback(), or memInvalidate() and not in the serialization
* method. In general, if state changes occur in serialize, it
* complicates testing since it breaks assumptions about draining
* and serialization. It potentially also makes components more
* fragile since they there are no ordering guarantees when
* serializing SimObjects.
*
* @warn This interface is considered deprecated and should never
* be used.
*/
virtual void serializeOld(CheckpointOut &cp) {
serialize(cp);
}
void serializeSectionOld(CheckpointOut &cp, const char *name);
void serializeSectionOld(CheckpointOut &cp, const std::string &name) {
serializeSectionOld(cp, name.c_str());
}
/** @} */
/** Get the fully-qualified name of the active section */
static const std::string &currentSection();

2
src/sim/sim_object.cc
View file

@ -151,7 +151,7 @@ SimObject::serializeAll(CheckpointOut &cp)
SimObject *obj = *ri;
// This works despite name() returning a fully qualified name
// since we are at the top level.
obj->serializeSectionOld(cp, obj->name());
obj->serializeSection(cp, obj->name());
}
}