sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Clean up arch/*/process.hh includes and std namespace issues.

Browse source 
arch/alpha/process.cc:
arch/mips/process.cc:
arch/sparc/process.cc:
    You really do need the headers in the .cc file.
arch/alpha/process.hh:
    Don't include unnecessary headers in another header.
    Replace with forward class declarations.
arch/mips/process.hh:
arch/sparc/process.hh:
    Don't include unnecessary headers in another header.
    Replace with forward class declarations.
    Also fix std namespace... no "using" in header files!

--HG--
extra : convert_revision : f2cd953d0f4a212bb8148cc54c329aa3c18deb89
This commit is contained in:
Steve Reinhardt 2006-03-12 16:27:52 -05:00
parent e1985e0200
commit 159cee1719
6 changed files with 33 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
arch/alpha/process.cc
View file

@ -27,6 +27,10 @@
*/ */
#include "arch/alpha/process.hh" #include "arch/alpha/process.hh"
#include "arch/alpha/linux/process.hh"
#include "arch/alpha/tru64/process.hh"
#include "base/loader/object_file.hh"
#include "base/misc.hh"
namespace AlphaISA namespace AlphaISA
{ {

11
arch/alpha/process.hh
View file

@ -30,18 +30,19 @@
#define __ALPHA_PROCESS_HH__ #define __ALPHA_PROCESS_HH__
#include <string> #include <string>
#include <vector>
#include "arch/alpha/linux/process.hh" class LiveProcess;
#include "arch/alpha/tru64/process.hh" class ObjectFile;
#include "base/loader/object_file.hh" class System;
namespace AlphaISA namespace AlphaISA
{ {
LiveProcess * LiveProcess *
createProcess(const std::string &nm, ObjectFile * objFile, System * system, createProcess(const std::string &nm, ObjectFile * objFile, System * system,
int stdin_fd, int stdout_fd, int stderr_fd, int stdin_fd, int stdout_fd, int stderr_fd,
std::vector<std::string> &argv, std::vector<std::string> &envp); std::vector<std::string> &argv, std::vector<std::string> &envp);
} // namespace AlphaISA } // namespace AlphaISA

3
arch/mips/process.cc
View file

@ -27,6 +27,9 @@
*/ */
#include "arch/mips/process.hh" #include "arch/mips/process.hh"
#include "arch/mips/linux/process.hh"
#include "base/loader/object_file.hh"
#include "base/misc.hh"
using namespace std; using namespace std;

14
arch/mips/process.hh
View file

@ -29,18 +29,20 @@
#ifndef __MIPS_PROCESS_HH__ #ifndef __MIPS_PROCESS_HH__
#define __MIPS_PROCESS_HH__ #define __MIPS_PROCESS_HH__
#include "arch/mips/linux_process.hh" #include <string>
#include "base/loader/object_file.hh" #include <vector>
using namespace std; class LiveProcess;
class ObjectFile;
class System;
namespace MipsISA namespace MipsISA
{ {
LiveProcess * LiveProcess *
createProcess(const string &nm, ObjectFile * objFile,System * system, createProcess(const std::string &nm, ObjectFile * objFile,System * system,
int stdin_fd, int stdout_fd, int stderr_fd, int stdin_fd, int stdout_fd, int stderr_fd,
vector<string> &argv, vector<string> &envp); std::vector<std::string> &argv, std::vector<std::string> &envp);
} // namespace MipsISA } // namespace MipsISA

3
arch/sparc/process.cc
View file

@ -27,6 +27,9 @@
*/ */
#include "arch/sparc/process.hh" #include "arch/sparc/process.hh"
#include "arch/sparc/linux/process.hh"
#include "base/loader/object_file.hh"
#include "base/misc.hh"
namespace SparcISA namespace SparcISA
{ {

14
arch/sparc/process.hh
View file

@ -29,16 +29,20 @@
#ifndef __SPARC_PROCESS_HH__ #ifndef __SPARC_PROCESS_HH__
#define __SPARC_PROCESS_HH__ #define __SPARC_PROCESS_HH__
#include "arch/sparc/linux/process.hh" #include <string>
#include "base/loader/object_file.hh" #include <vector>
class LiveProcess;
class ObjectFile;
class System;
namespace SparcISA namespace SparcISA
{ {
LiveProcess * LiveProcess *
createProcess(const string &nm, ObjectFile * objFile, createProcess(const std::string &nm, ObjectFile * objFile,
int stdin_fd, int stdout_fd, int stderr_fd, int stdin_fd, int stdout_fd, int stderr_fd,
vector<string> &argv, vector<string> &envp); std::vector<std::string> &argv, std::vector<std::string> &envp);
} // namespace SparcISA } // namespace SparcISA