sanchayanmaity/gem5
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Move code before a early return to make sure it is executed on all paths

Browse source 
--HG--
extra : convert_revision : cfdd5b6911422fbb733677c43d027aa4407fbc85
This commit is contained in:
Ron Dreslinski 2006-11-12 06:44:05 -05:00
parent b22d390721
commit 11accacf7c
1 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/mem/cache/cache_impl.hh vendored
View file

@ -476,6 +476,13 @@ Cache<TagStore,Buffering,Coherence>::snoop(PacketPtr &pkt)
} }
CacheBlk::State new_state; CacheBlk::State new_state;
bool satisfy = coherence->handleBusRequest(pkt,blk,mshr, new_state); bool satisfy = coherence->handleBusRequest(pkt,blk,mshr, new_state);
if (blk && mshr && !mshr->inService && new_state == 0) {
//There was a outstanding write to a shared block, not need ReadEx
//not update, so change No Allocate param in MSHR
mshr->pkt->flags &= ~NO_ALLOCATE;
}
if (satisfy) { if (satisfy) {
DPRINTF(Cache, "Cache snooped a %s request for addr %x and " DPRINTF(Cache, "Cache snooped a %s request for addr %x and "
"now supplying data, new state is %i\n", "now supplying data, new state is %i\n",
@ -485,15 +492,10 @@ Cache<TagStore,Buffering,Coherence>::snoop(PacketPtr &pkt)
respondToSnoop(pkt, curTick + hitLatency); respondToSnoop(pkt, curTick + hitLatency);
return; return;
} }
if (blk) { if (blk)
DPRINTF(Cache, "Cache snooped a %s request for addr %x, " DPRINTF(Cache, "Cache snooped a %s request for addr %x, "
"new state is %i\n", pkt->cmdString(), blk_addr, new_state); "new state is %i\n", pkt->cmdString(), blk_addr, new_state);
if (mshr && !mshr->inService && new_state == 0) {
//There was a outstanding write to a shared block, not need ReadEx
//not update, so change No Allocate param in MSHR
mshr->pkt->flags &= ~NO_ALLOCATE;
}
}
tags->handleSnoop(blk, new_state); tags->handleSnoop(blk, new_state);
} }